How to fix/simplify this Placement System Script? [closed]

Asked by

7 years ago

Me and my friend have worked together on this placement system script for a while now as a school project.

I need to make this code shorter and more efficient/clean.

The whole code is here:

01wait()
02local rs = game:WaitForChild("ReplicatedStorage")
03local base = game.Workspace.GrassTop
04local placeablePart = rs:WaitForChild("PlaceableObjects")
05local Menu = game.Players.LocalPlayer.PlayerGui.PlacementSystem.ObjectMenu.ObjectList
06local CurrentlyPlacing = false
07local rotation = 0
08local canPlace = false
09 
10local first = true
11 
12local player = game.Players.LocalPlayer
13local mouse = player:GetMouse()
14local runService = game:GetService("RunService")
15 
16function roundAToB(a,b)
17    return(math.floor((a/b)+0.5)*b)
18end
19 
20local modelPreview, modelPlace
21 
22modelRotate = mouse.KeyDown:connect(function(key)
23    if (key == "r") then
24        rotation = rotation + 90
25    end
26end)
27 
28---------- OBJECTS ----------
29 
30Menu.Wall.MouseButton1Click:connect(function()
31    script.SelectedPart.Value = placeablePart.Wall
32    CurrentlyPlacing = true
33    cloneModel = script.SelectedPart.Value:clone()
34    cloneModel.Parent = game.Workspace
35end)
36 
37-----------------------------
38 
39count = 0
40modelPreview = runService.RenderStepped:connect(function()
41    if CurrentlyPlacing == true then
42        local modelCFrame = cloneModel:GetModelCFrame()
43        mouse.TargetFilter = cloneModel
44        local hit = mouse.Hit.p
45        cloneModel:SetPrimaryPartCFrame(CFrame.new(roundAToB(hit.X,4),1.5,roundAToB(hit.Z,4)) * CFrame.Angles(0, math.rad(rotation), 0))        
46        if (cloneModel.PrimaryPart.Position.X > base.Position.X-base.Size.X/2) and (cloneModel.PrimaryPart.Position.Z > base.Position.Z-base.Size.Z/2) and (cloneModel.PrimaryPart.Position.X < base.Position.X+base.Size.X/2) and (cloneModel.PrimaryPart.Position.Z < base.Position.Z+base.Size.Z/2) then    
47            canPlace = true        
48            cloneModel:Destroy()
49            cloneModel = script.SelectedPart.Value:clone()
50            cloneModel.Parent = game.Workspace
51            cloneModel:SetPrimaryPartCFrame(CFrame.new(roundAToB(hit.X,4),1.5,roundAToB(hit.Z,4)) * CFrame.Angles(0, math.rad(rotation), 0))
52        -- error is somewhere around here       
53            for i,v in pairs(cloneModel:GetChildren()) do
54                if v:IsA('BasePart') then
55                    v.Transparency = 0.7
56                    v.CanCollide = false
57                end
58            end
59        else
60            canPlace = false
61            for i,v in pairs(cloneModel:GetChildren()) do
62                if v:IsA('BasePart') then
63                    v.Transparency = 1
64                    v.CanCollide = false
65                end
66            end
67        end
68    else
69        if not first then
70            cloneModel:Destroy()
71        end
72    end
73end)
74 
75modelPlace = mouse.Button1Down:connect(function()
76    if CurrentlyPlacing == true then
77        if canPlace == true then
78            local new = cloneModel:clone()
79            new.Parent = workspace.Tycoons.TycoonTemplate.PurchasedObjects
80            for i,v in pairs(new:GetChildren()) do
81                if v:IsA('BasePart') then
82                    v.Transparency = 0
83                    v.CanCollide = true
84    --          Specific part properties below:
85                elseif v.Name == "Arrow" then
86                    v.CanCollide = false
87                    v.Transparency = 0.7
88                elseif v.Name == "Drop" then
89                    v.CanCollide = false
90                    v.Transparency = 0.5
91                end
92            end
93        end
94        cloneModel:Destroy()
95        script.CurrentlyPlacing.Value = false
96        canPlace = false
97    end
98end)
 View all 98 lines...

Is there anything actually broken in this code? I'm happy to look over it for you but it's gonna be on the backburner if there are no actual bugs to fix. adark 5487 — 7y

Since there is no indication that this code isn't functioning, i'm going to moderate. +1 to omit rep loss. Goulstem 8144 — 7y

Closed as Primarily Opinion-Based by adark and Goulstem

This question has been closed because it is a discussion about a topic focused on diverse opinions, which isn't a good fit for our Q&A format.

Why was this question closed?