Is there any way to make this script less tedious to write?

Asked by

7 years ago

Currently I have this script for an axe that allows it to chop down trees as well as deal damage to humanoids or players of the opposite team.

So far the script works however I am also planning to reuse this script for other different tools such as a pickaxe, and many other ones that i plan to add in the future too. I find that reusing the script and changing its variables and functions each time for a different tool is quite tedious to do, so I am wondering if there is a more simple way to make the process less complicated and most importantly less tedious.

I'm thinking of using module scripts however I am not really familiar with using them, mostly because I'm having trouble with finding out the best way to set them up and what parts of the script can be used in a module and what parts that don't.

001Tool = script.Parent
002local character = script.Parent.Parent.Parent.Character
003local coolDown1 = 0.3
004local coolDown2 = 0.3
005local swinging = false
006local canSwing = true
007local damage = 26
008 
009---------------------------------------------------------------------------------------------------------------------
010 
011Tool.Activated:connect(function()
012    if canSwing == false then return end
013    canSwing = false
014    local character = Tool.Parent
015    local humanoid = character.Humanoid
016    local animation = humanoid:LoadAnimation(script.Parent.Animation)
017    animation:Play(0.4,1,1)
018    wait(0.3)
019    animation:AdjustSpeed(0)
020    wait(0.2)
021    animation:AdjustSpeed(2)
022    Tool.Handle.Swoosh:Play()
023    swinging = true
024    wait(0.3)
025    swinging = false
026    wait(coolDown1) --animation cool down time
027    canSwing = true
028end)
029 
030---------------------------------------------------------------------------------------------------------------------
031 
032local canDamage = true
033canChop = true
034Tool.Handle.Touched:connect(function(hit)
035    if swinging == false then return end
036    if canDamage == false or canChop == false then return end
037 
038    local function whenHit()
039        canDamage = false
040       if hit.Parent:FindFirstChild("Humanoid") then
041           local player = game.Players:GetPlayerFromCharacter(hit.Parent)
042           local user = game.Players:GetPlayerFromCharacter(Tool.Parent)
043            if not player then
044                hit.Parent.Humanoid:TakeDamage(damage)
045            end
046           if player then
047               if player.TeamColor == user.TeamColor then
048                   hit.Parent.Humanoid:TakeDamage(0)
049               else
050                   hit.Parent.Humanoid:TakeDamage(damage)
051               end
052           end
053       end
054           Tool.Handle.FleshHit:Play()
055           wait(coolDown2)
056           canDamage = true
057       end
058 
059    local function chop()
060        canChop = false
061        Tool.Handle.Chop:Play()
062        local chopValue = hit.Parent.ChopValue
063        if hit and hit.Parent:FindFirstChild("ChopValue") then
064            if chopValue.Value >= 1 then --if the tree is still choppable then decrease the chopValue
065                local amount = 1
066                chopValue.Value = chopValue.Value - amount
067                local function checkValue() --checks to see if chopValue is less than or equal to 0, if it is then down the tree
068                    --print(chopValue.Value)
069                    if chopValue.Value <= 0 then --if the tree can be downed then
070 
071                        local tree = chopValue.Parent
072                        local function checkSize()
073                            if tree.TreeSize.Value == 1 then
074 
075                                local drop = game.ServerStorage.Drops.Trees.TreeDropSmall
076                                local dropClone = drop:Clone()
077                                dropClone.Parent = game.Workspace
078                                dropClone:MoveTo(tree.Trunk.Position)
079 
080                            elseif tree.TreeSize.Value == 2 then
081 
082                                local drop = game.ServerStorage.Drops.Trees.TreeDropMedium
083                                local dropClone = drop:Clone()
084                                dropClone.Parent = game.Workspace
085                                dropClone:MoveTo(tree.Trunk.Position)
086 
087                            elseif tree.TreeSize.Value == 3 then
088 
089                                local drop = game.ServerStorage.Drops.Trees.TreeDropBig
090                                local dropClone = drop:Clone()
091                                dropClone.Parent = game.Workspace
092                                dropClone:MoveTo(tree.Trunk.Position)
093                            end
094                        end
095                        local function timber() -- Responsible for downing the tree
096 
097                            checkSize()
098                            tree.Leaves.Anchored = false
099                            tree.Trunk:Destroy()
100 
101                        end
102                        timber()
103 
104                    end
105                end
106                checkValue() 
107            end
108        end
109        wait(coolDown2)
110        canChop = true
111    end
112 
113    if hit and hit.Parent:FindFirstChild("Humanoid") then --if hit humanoid then
114        whenHit()   
115    elseif hit and hit.Parent:FindFirstChild("ChopValue") then --if hit tree then
116        chop()
117    end
118end)
 View all 118 lines...

Quick explanation: When the script detects a part with the required IntValues in it or it's parent, it will execute the chop function which treats the part like a tree that can be chopped down.

Well, you could have all of the different functions for each tool in one script, and then define a string variable (local toolType = "Axe") then have the script decide which function to do based on the variable. Then, when you wanna make a new tool, just copy this script to the new tool and change the toolType variable to be "Pickaxe" or "Sword" or any other tools you want, as long is that one var Br4veh3art23 46 — 7y

Alternatively, you could put all the functions in a module script and call them based on the toolType variable. Br4veh3art23 46 — 7y

hmm I think that could actually work, imma go test it out Duksten 20 — 7y

Is there any way to make this script less tedious to write?

1 answer

Answer this question