Scripting Helpers is winding down operations and is now read-only. More info→

Why does my script see players as always swimming?

Asked by

CraneFly 8

7 years ago

Edited 7 years ago

This is the log over 8.5 seconds: 21:32:32.155 - Baseplate was auto-saved (x2) swimming (x17)

01local p = game.Players.LocalPlayer
02local c = p.Character
03local m = p:GetMouse()
04 
05local sprint = false
06 
07local t,f = true,false
08 
09local w,a,s,d = f,f,f,f
10local wt = 0
11 
12function lower() -- player starts drowning if they are swimming
13    c.Humanoid.Health = c.Humanoid.Health -1
14end
15 
16 
17m.KeyDown:connect(function(key)
18    if key == '0' then
19        sprint = t
20    end
21    if key == 'w' then
22        w = t
23    end
24    if key == 'a' then
25        a = t
26    end
27    if key == 's' then
28        s = t
29    end
30    if key == 'd' then
31        d = t
32    end
33end)
34m.KeyUp:connect(function(key)
35    if key == '0' then
36        sprint = f
37    end
38    if key == 'w' then
39        w = f
40    end
41    if key == 'a' then
42        a = f
43    end
44    if key == 's' then
45        s = f
46    end
47    if key == 'd' then
48        d = f
49    end
50end)
51 
52while wait() do
53    wt = wt - .01
54    if wt <= 0 then
55        if script.Parent.Frame.Bar.Size.X.Scale < .9 then
56            script.Parent.Frame.Bar.Size = script.Parent.Frame.Bar.Size + UDim2.new(.009,0,0,0)
57        end
58    end
59    if w or a or s or d then
60        if script.Parent.Frame.Bar.Size.X.Scale > 0 and sprint then
61            script.Parent.Frame.Bar.Size = script.Parent.Frame.Bar.Size - UDim2.new(.009,0,0,0)
62            c.Humanoid.WalkSpeed = 20
63        end
64    end
65    if sprint then
66        wt = 1.3
67    end
68    if not w and not a and not s and not d then c.Humanoid.WalkSpeed = 12 end
69    if not sprint then c.Humanoid.WalkSpeed = 12 end
70    if script.Parent.Frame.Bar.Size.X.Scale <= 0 then c.Humanoid.WalkSpeed = 12 end
71    if c.Humanoid.Swimming:connect(lower) then print("swimming") wait(0.5)end -- detects if a player is swimming
72    end
 View all 72 lines...

1 answer

Answered by

Goulstem 8144

7 years ago

Edited 7 years ago

Swimming is an event of the Humanoid object.. you can't "check" an RbxScriptSignal and expect it to return if the player is swimming or not.

I suggest you use the StateChanged event of the Humanoid object. It fires when the state of the humanoid changes(e.g. Jumping, Falling, Dead, swimming). It returns the previous state of the humanoid, and the current state.

You can compare the second returned value with the HumanoidStateType Enum.

01local p = game.Players.LocalPlayer
02local c = p.Character or p.CharacterAdded:Wait()
03local h = c:WaitForChild("Humanoid")
04local target_state = Enum.HumanoidStateType.Swimming
05local swimming = false
06 
07h.StateChanged:Connect(function(old,new)
08    if new == target_state then --Compare current state
09        swimming = true
10        print(c.Name.." went from "..tostring(old).." to "..tostring(new).."!")
11    else
12        swimming = false
13    end
14end)

Why does my script see players as always swimming?

1 answer

Answer this question