Scripting Helpers is winding down operations and is now read-only. More info→

Punching Damage doesn't work right????

Asked by

DarkWQlfc 20

7 years ago

Edited 7 years ago

01local player = game.Players.LocalPlayer
02local mouse = player:GetMouse()
03 
04local Combo = 1
05local enabled = true
06local CanDamage = false
07 
08mouse.KeyDown:connect(function(key)
09if key == "q" then
10        if Combo == 1 then
11if not enabled then return end
12enabled = false
13            local a = player.Character.Humanoid:LoadAnimation(script.Punch1):Play()
14wait(0.5)
15            Combo = 2
16enabled = true
17mouse.KeyDown:connect(function(key)
18if key == "q" then
19                if Combo == 2 then
20    if not enabled then return end
21enabled = false
22                       local b = player.Character.Humanoid:LoadAnimation(script.Punch2):Play()
23        wait(0.5)
24        Combo = 3
25enabled = true
26mouse.KeyDown:connect(function(key)
27if key == "q" then
28                if Combo == 3 then
29    if not enabled then return end
30enabled = false
31                       local c = player.Character.Humanoid:LoadAnimation(script.Kick):Play()
32        wait(0.5)
33        Combo = 1
34enabled = true
35end
36 
37game.Workspace:FindFirstChild(game.Players.LocalPlayer.Name)['LeftHand'].Touched:connect(function(part)
38    local human= part.Parent:findFirstChild("Humanoid")
39    if human then
40        if human.Parent.Name~= game.Players.LocalPlayer.Name and CanDamage == false then
41    CanDamage = true
42            human:TakeDamage(10)
43            wait(1.2)
44            CanDamage = false
45        end
46    end
47end)
48game.Workspace:FindFirstChild(game.Players.LocalPlayer.Name)['RightHand'].Touched:connect(function(part)
49    local human= part.Parent:findFirstChild("Humanoid")
50    if human then
51        if human.Parent.Name~= game.Players.LocalPlayer.Name and CanDamage == false then
52        CanDamage = true
53            human:TakeDamage(10)
54            wait(1.2)
55            CanDamage=false
56        end
57    end
58end)
59end
60end)
61end
62end
63end)
64end
65end
66end)
 View all 66 lines...

Basically I tried to change the CanDamage Variable to false instead of true i switched places between them and nothing seems to work It does damage even when the animation is not playing.

Help me please.

Why did you do so many separate events? (mouse.KeyDown) RevergeHelps 63 — 7y

You can use and statements like if debounce1 == false and debounce2 == false then hiimgoodpack 2009 — 7y

1 answer

Answered by

Neu_Dev 22

7 years ago

First of all using Mouse to use keyboard is limited use and also deprecated its a bad practice to use it, i suggest start using "UserIputService" which you will have more control on your input.

API http://wiki.roblox.com/index.php?title=API:Class/UserInputService

How to use one http://wiki.roblox.com/index.php?title=API:Class/UserInputService/InputBegan

Example:

This example must be inside of your player or character and must be localscript or else wont work.

this will work also inside of the tool because since tool is equipped then tool is transferred to the player character since localscript is inside the tool. got it?

---LOCALSCRIPT

01local player = game.Players.LocalPlayer -- This will only work on local script, on normal script it is not
02local UIS = game:GetSerivce("UserInputService")
03local Anim = player.Character.Humanoid:LoadAnimation(script.Punch1)
04local Anim2 = player.Character.Humanoid:LoadAnimation(script.Punch2)
05Combo = 1
06CanDamage = false
07 
08 
09UIS.InputBegan:connect(function(key, gameproc)
10    if not gameproc and key.KeyCode == Enum.KeyCode.Q and Combo == 1 then
11        CanDamage = true
12        Combo = 2
13        Anim:Play()
14        local lefthand = player.Character:FindFirstChild("LeftHand")
15        lefthand.Touched:connect(function(hit)
16        if hit.Parent:FindFirstChild("Humanoid") and CanDamage == true then
17            hit.Parent:FindFirstChild("Humanoid"):TakeDamage(10)
18        end
19        wait(0.1)
20        CanDamage = false
21    elseif not gameproc and key.KeyCode == Enum.KeyCode.Q and Combo == 2 then
22        CanDamage = true
23        Combo = 3
24        Anim2:Play()
25        local lefthand = player.Character:FindFirstChild("LeftHand")
26        lefthand.Touched:connect(function(hit)
27        if hit.Parent:FindFirstChild("Humanoid") and CanDamage == true then
28            hit.Parent:FindFirstChild("Humanoid"):TakeDamage(10)
29        end
30        wait(0.1)
31        CanDamage = false
32    ---- and Continue it
33    end
34end)
 View all 34 lines...

Gameproc or GameProcessed needs to be check false so while in the middle of typing in chat the input or key you set is pressed wont activate it. so it will not be annoying sometimes.

Press answer if this helps you! ~~Neuroticxs

also just add a if statement when the tool is equipped or not so it wont punch randomly if the tool is unequipped Neu_Dev 22 — 7y

I am getting an error on the elseif not line . when I fix this , it's saying Error getting Service from DataModel anyway it doesn't get service for the UIS this is why I don't use it . DarkWQlfc 20 — 7y

What do you mean? It perfectly works for me? You did something wrong Neu_Dev 22 — 7y

Also you might have to at a repeat wait() until game.Players.LocalPlayer.Character so it wont automatically runs the script while player is still loading and that might have broke the script Neu_Dev 22 — 7y

Nvm I figured it out DarkWQlfc 20 — 7y

Punching Damage doesn't work right????

1 answer

Answer this question