Scripting Helpers is winding down operations and is now read-only. More info→

How do I fixed this laggy script, Am I not using loops correctly?

Asked by

ArcticDev 9

7 years ago

Is it inefficient? It works for like 2 seconds, and then it is just choppy and laggy. What is causing this?

01enabled = false
02game.Players.LocalPlayer:GetMouse().Move:connect(function()
03    if enabled == true then
04        closestdist = math.huge
05    for i,v in pairs(workspace:FindFirstChild(game.Players.LocalPlayer.Name.."Tycoon"):FindFirstChild("Grid"):GetChildren()) do
06        v.Name = i
07    target = game.Players.LocalPlayer:GetMouse().Hit.p
08    if (target - v.Position).magnitude < closestdist then
09        closestgrid = v
10        print(closestgrid)
11        closestdist = (target - v.Position).magnitude
12    x = v.Position.x
13    y = v.Position.y
14    z = v.Position.z
15    end
16        if object ~=nil then
17            if enabled == true then
18 
19                enabled = false
20            for o=0,1,.2 do wait()
21                object:SetPrimaryPartCFrame(object:GetPrimaryPartCFrame():lerp((CFrame.new(x,y,z)),o))
22            end
23            repeat wait() until object:GetPrimaryPartCFrame() == CFrame.new(x,y,z)
24            enabled = true
25        end
26        --object:MoveTo(Vector3.new(v.Position.x, v.Position.y, v.Position.z))
27        --objectname = object.Name
28        --game.ReplicatedStorage.placeitem:FireServer(x,y,z, objectname)
29        else
30            print('Grid Pos Failure')
31                end
32    end
33    end
34end)
 View all 34 lines...

Try adding a wait() to the end and see if it works better.. 4D_X 118 — 7y

1 answer

Answered by

ArcticDev 9

7 years ago

bump!

How do I fixed this laggy script, Am I not using loops correctly?

1 answer

Answer this question