Scripting Helpers is winding down operations and is now read-only. More info→

Could someone help me make my attack script stop damageing?

Asked by

CaptainJ222 2

7 years ago

Edited 7 years ago

Here is the script its not the best but it my try at it im kinda in experienced

This is my full script i tried my best

01local animation = Instance.new("Animation")
02 
03    animation.AnimationId = "http://www.roblox.com/Asset?id=873178948"
04    Player = game.Players.LocalPlayer
05 mouse = Player:GetMouse()
06 
07local Player = game.Players.LocalPlayer
08 
09local Character = Player.Character
10 
11local Humanoid = Character:WaitForChild("Humanoid")
12 
13local Animation = Instance.new("Animation")
14 
15function Hit(damage)
16 if damage.Parent:FindFirstChild("Humanoid") and damage.Parent.Name ~=
17  Player.Name then
18 damage.Parent.Humanoid.Health = damage.Parent.Humanoid.Health -1
19 end
20 end
21 
22local Player = game.Players.LocalPlayer
23    local Mouse =  Player:GetMouse()
24 
25    local animTrack = nil
26    local CanDamage = true
27    local CanDamage = false
28 
29        CanDamage = false
30    Mouse.KeyDown:connect(function(key)
31        if key:lower() == "q" then
32            local character = Player.Character
33            animTrack = character:WaitForChild("Humanoid"):LoadAnimation(animation)
34            animTrack:Play()
35     Player.Character["Left Arm"].Touched:connect(Hit)
36    local CanDamage = false
37 
38        end
39 
40    end)
 View all 40 lines...

messy thread , please organise it properly. arshad145 392 — 7y

k CaptainJ222 2 — 7y

Why do you define "CanDamage" twice? User#5423 17 — 7y

This should help with formatting your code, https://forum.scriptinghelpers.org/topic/82/how-to-format-questions-answers-on-the-main-site User#5423 17 — 7y

View all comments (8 more)

thank you CaptainJ222 2 — 7y

I didn't know the site had that :o Thank you for the information ^^ arshad145 392 — 7y

lol CaptainJ222 2 — 7y

@CaptainJ222 the problem is the way you are using / creating the CanDamage variable. User#5423 17 — 7y

please explain CaptainJ222 2 — 7y

Where are you connecting the "Hit" function? User#5423 17 — 7y

oh umm CaptainJ222 2 — 7y

dosnt function Hit(damage) CaptainJ222 2 — 7y

1 answer

Answered by

arshad145 392

7 years ago

Hello,

I have tried to help as far as I can because your script is a mess.

Localscript found in Backpack :

01local animation = Instance.new("Animation")
02animation.AnimationId = "rbxassetid://873178948" --Convert it into an assetid by putting it into a AnimationId slot.
03local player = game.Players.LocalPlayer
04local mouse = player:GetMouse()
05--local Character = Player.Character -- In studio , everything loads nearly instantly, but on servers there is a delay.
06repeat wait() until player.Character -- This creates a loop until the player has fully loaded.
07local char = player.Character
08local hum = char:findFirstChild("Humanoid")
09local animTrack = nil
10local CanDamage = true -- Why do you declare both as false and true? 
11--The above is a debounce , which prevents the instant death of a Humanoid.
12 
13 
14mouse.KeyDown:connect(function(key)
15    if key:lower() == "q" then
16        --animTrack = char:WaitForChild("Humanoid"):LoadAnimation(animation)
17        --animTrack:Play()
18        char["Left Arm"].Touched:Connect(function(hit)
19            if (hit.Parent:FindFirstChild("Humanoid")) and (hit.Parent.Name ~= player.Name) and (CanDamage == true) then
20                --hit.Parent.Humanoid.Health = hit.Parent.Humanoid.Health -1 -- Too much effort.
21                hit.Parent:findFirstChild("Humanoid"):TakeDamage(1) -- This is the line that damages the Humanoid.
22                --If that was what you were searching for.
23                CanDamage = false
24                wait(1)
25                CanDamage = true
26            end
27        end)
28    end
29 
30end)
 View all 30 lines...

I am still learning RbxLua.

Thank you for reading.

Thankyou for trying with my messy work im new a well CaptainJ222 2 — 7y

unfortunatly it only dose damage once men this is hard idk why it wont work CaptainJ222 2 — 7y

It will do damage after 1 second...Cooldown just change line 24 : wait(delay you want) arshad145 392 — 7y

Could someone help me make my attack script stop damageing?

1 answer

Answer this question