Scripting Helpers is winding down operations and is now read-only. More info→

Table inside of a ModuleScript is returning nil when it shouldn't be?

Asked by

Troidit 253

7 years ago

Edited 7 years ago

I'm using a ModuleScript to create an index that stores the amount of points a player has, and saves it with DataStores when they leave (as well as during an autosave). With the help of the Roblox Wiki I was able to script what looks to me like it should work. ModuleScript: [EDITED]

01local PlayerStatManager = {}
02 
03local DataStoreService = game:GetService('DataStoreService')
04local playerData = DataStoreService:GetDataStore('PhobiaSave')
05 
06local AUTOSAVE_INTERVAL = 90
07 
08local sessionData = {}
09 
10function PlayerStatManager:ChangeStat(player, statName, changeValue)
11    sessionData[player][statName] = sessionData[player][statName] + changeValue
12end
13 
14function PlayerStatManager:RetrieveData(player) --Function I'm operating from the regular script
15    return sessionData[player]
16end
17 
18local function getPlayerData(player)
19    return playerData:GetAsync(player.UserId)
20end
21 
22 
23local function savePlayerData(player)
24    playerData:SetAsync(player.UserId, sessionData[player])
25end
26 
27local function setupPlayerData(player) --Doesn't operate this function (BREAK HERE)
28    local data = getPlayerData(player)
29    if not data then
30        sessionData[player] = {Intelligence = 0}
31        savePlayerData(player)
32    else
33        sessionData[player] = data
34    end
35end
36 
37local function autosave()
38    while wait(AUTOSAVE_INTERVAL) do
39        for player, data in pairs(sessionData) do
40            savePlayerData(player)
41        end
42    end
43end
44 
45game.Players.PlayerAdded:Connect(setupPlayerData)
46 
47game.Players.PlayerRemoving:Connect(function(player)
48    savePlayerData(player)
49    sessionData[player] = nil
50end)
51 
52 
53spawn(autosave)
54 
55 
56return PlayerStatManager
 View all 56 lines...

Server Script: [EDITED]

1Storage = require(script.StatStorage)
2game:GetService("Players").PlayerAdded:Connect(player)
3    print(Storage:RetrieveData(Player)) --returns nil
4end

When I run in test mode and insert a break where I commented above (BREAK HERE) inside the ModuleScript, it doesn't break showing that it's not running the function when required to on PlayerAdded? I'm not sure if that's related to the problem of my Server Script trying to get something that returns nil from the ModuleScript.

1 answer

Answered by

Azarth 3141

7 years ago

Edited 7 years ago

You put Player, not player. Also, you should be using the two together in unison. You have two PlayerAdded functions going on. You should call it from the script to the module, else they're probably going to fire in different orders and that's not going to work out well online. Ie.. index the player when they join via script calling the setupPlayerData function in the module, return data.

01local module = require(script:WaitForChild('ModuleScript'))
02 
03game.Players.PlayerAdded:connect(function(player)
04    local data = module:setupPlayerData(player) 
05    print(data.Points)
06end)
07 
08game.Players.PlayerRemoving:connect(function(player)
09    module:player_left(player)
10end)

01local PlayerStatManager = {}
02 
03local DataStoreService = game:GetService('DataStoreService')
04local playerData = DataStoreService:GetDataStore('PhobiaSave')
05 
06local AUTOSAVE_INTERVAL = 90
07 
08local sessionData = {}
09 
10function PlayerStatManager:ChangeStat(player, statName, changeValue)
11    sessionData[player][statName] = sessionData[player][statName] + changeValue
12end
13 
14function PlayerStatManager:getPlayerData(player)
15    return playerData:GetAsync(player.UserId)
16end
17 
18local function savePlayerData(player)
19    playerData:SetAsync(player.UserId, sessionData[player])
20end
21 
22local function autosave()
23    while wait(AUTOSAVE_INTERVAL) do
24        for player, data in pairs(sessionData) do
25            savePlayerData(player)
26        end
27    end
28end
29 
30function PlayerStatManager:setupPlayerData(player) 
31    local data = PlayerStatManager:getPlayerData(player)
32    if not data then
33        sessionData[player] = {Points = 0}
34        savePlayerData(player)
35    else
36        sessionData[player] = data
37    end
38    return sessionData[player]
39end
40 
41function PlayerStatManager:player_left(player)
42    savePlayerData(player)
43    sessionData[player] = nil
44end
45 
46spawn(function() autosave() end)
47 
48return PlayerStatManager
 View all 48 lines...

Table inside of a ModuleScript is returning nil when it shouldn't be?

1 answer

Answer this question