Scripting Helpers is winding down operations and is now read-only. More info→

NPC Follow system works but after death it stops working [?]

Asked by

BlackOrange3343 2676

8 years ago

Edited 6 years ago

Goal:

My goal is to create an NPC follow system (I already have the damage system completed). What it should do it if you are within a certain range measured by magnitude you are chased by some NPC's that are within range.

Problem:

The problem is when a Player first spawns in the NPC chases the player and everything but when the player Dies by something (NPC, another player) the NPC's stop chasing the player. The code works but it stops working sometimes.

Script:

Note that this is a ServerScript in ServerScriptService

01local RunService = game:GetService("RunService")
02local Settings = require(game:GetService("ReplicatedStorage").ModuleScripts.SETTINGS)
03local Respawn_Time = Settings.BANDIT.RESPAWN_TIME
04local plrServ = game:GetService('Players')
05local NPCBackup = game:GetService('ServerStorage').NPCBackup.Bandit
06 
07local function getClosestPlayer(myPos)
08    local pos, tor = Settings.BANDIT.RANGE
09    for _, plr in pairs(plrServ:GetPlayers()) do
10        if plr.Character then
11            if (plr.Character.PrimaryPart.Position - myPos).Magnitude < pos then
12                pos = (plr.Character.PrimaryPart.Position - myPos).Magnitude
13                tor = plr.Character.PrimaryPart
14            end
15        end
16    end
17    return tor
18end
19 
20local function setupNPC(Bandit, BanditPosition)
21 
22    local hum = Bandit.Humanoid
23    local npcPrimaryPart = Bandit.PrimaryPart
24    local targetTorso
25    spawn(function() 
26        while wait(1) do
27            targetTorso = getClosestPlayer(npcPrimaryPart.Position)
28            if targetTorso then
29                hum:MoveTo(targetTorso.Position, targetTorso)
30            else
31                return
32            end
33        end
34    end)
35 
36    hum.Died:Connect(function()
37        wait(Settings.BANDIT.RESPAWN_TIME)
38        local cln = NPCBackup:Clone()
39        cln:SetPrimaryPartCFrame(BanditPosition)
40        cln.Parent = workspace.Bandits
41        Bandit:Destroy()
42        setupNPC(cln, BanditPosition)
43        if not cln:FindFirstChild('RobloxAnimation') then
44            local Animation = game:GetService('ServerStorage').Effects.RobloxAnimation:Clone()
45            Animation.Disabled = false
46            Animation.Parent = cln
47            cln.Humanoid.WalkSpeed = Settings.BANDIT.WALKSPEED
48        end
49    end)
50end
51 
52for _, Bandit in pairs(workspace.Bandits:GetChildren()) do
53    spawn(function() setupNPC(Bandit, Bandit.PrimaryPart.CFrame) end)
54end
 View all 54 lines...

Hopefully, this problem gets solved, I appreciate any feedback that fixes this issue or improves the code. I try avoiding loops and RunService mostly because I do not know when is the correct time to use a while true do loop and I know that using a loop incorrectly can be studio crashing and game breaking. Thank you for reading.

Correct me if I'm wrong, but it seems like you only call the setup for each NPC once. That means when the player dies, the NPC can't find the torso and calls "return" in the else function. That would make the NPC stop moving towards the player. Creeperman1524 120 — 6y

I do believe that someone had said this as well on the discord Creeperman1524 120 — 6y

How could I fix this? BlackOrange3343 2676 — 6y

I would think just removing it would work. If it finds the target it will move. If it doesn't instead of never moving, it will constantly look for a new target. Creeperman1524 120 — 6y

2 answers

Answered by

Creeperman1524 120

6 years ago

Although this may no be correct, here is my answer on it

01local RunService = game:GetService("RunService")
02local Settings = require(game:GetService("ReplicatedStorage").ModuleScripts.SETTINGS)
03local Respawn_Time = Settings.BANDIT.RESPAWN_TIME
04local plrServ = game:GetService('Players')
05local NPCBackup = game:GetService('ServerStorage').NPCBackup.Bandit
06 
07local function getClosestPlayer(myPos)
08    local pos, tor = Settings.BANDIT.RANGE
09    for _, plr in pairs(plrServ:GetPlayers()) do
10        if plr.Character then
11            if (plr.Character.PrimaryPart.Position - myPos).Magnitude < pos then
12                pos = (plr.Character.PrimaryPart.Position - myPos).Magnitude
13                tor = plr.Character.PrimaryPart
14            end
15    else
16       tor = nil --Added this here so if it can't find the player, it will return nil
17        end
18    end
19    return tor
20end
21 
22local function setupNPC(Bandit, BanditPosition)
23 
24    local hum = Bandit.Humanoid
25    local npcPrimaryPart = Bandit.PrimaryPart
26    local targetTorso
27    spawn(function() 
28        while wait(1) do
29            targetTorso = getClosestPlayer(npcPrimaryPart.Position)
30            if targetTorso then
31                hum:MoveTo(targetTorso.Position, targetTorso)
32        --Removed the else here
33            end
34        end
35    end)
36 
37    hum.Died:Connect(function()
38        wait(Settings.BANDIT.RESPAWN_TIME)
39        local cln = NPCBackup:Clone()
40        cln:SetPrimaryPartCFrame(BanditPosition)
41        cln.Parent = workspace.Bandits
42        Bandit:Destroy()
43        setupNPC(cln, BanditPosition)
44        if not cln:FindFirstChild('RobloxAnimation') then
45            local Animation = game:GetService('ServerStorage').Effects.RobloxAnimation:Clone()
46            Animation.Disabled = false
47            Animation.Parent = cln
48            cln.Humanoid.WalkSpeed = Settings.BANDIT.WALKSPEED
49        end
50    end)
51end
52 
53for _, Bandit in pairs(workspace.Bandits:GetChildren()) do
54    spawn(function() setupNPC(Bandit, Bandit.PrimaryPart.CFrame) end)
55end
 View all 55 lines...

You may have to return the torso's position from the getClosestPlayer function, but I don't know for sure. Hopefully this works (which it probably doesn't)! :D

Thank you BlackOrange3343 2676 — 6y

-1

Answered by

Zerixa_RBLX -2

6 years ago

Use this:

01local larm = script.Parent:FindFirstChild("Left Arm")
02local rarm = script.Parent:FindFirstChild("Right Arm")
03 
04function findNearestTorso(pos)
05    local list = game.Workspace:children()
06    local torso = nil
07    local dist = 10
08    local temp = nil
09    local human = nil
10    local temp2 = nil
11    for x = 1, #list do
12        temp2 = list[x]
13        if (temp2.className == "Model") and (temp2 ~= script.Parent) then
14            temp = temp2:findFirstChild("Torso")
15            human = temp2:findFirstChild("Humanoid")
16            if (temp ~= nil) and (human ~= nil) and (human.Health > 0) then
17                if (temp.Position - pos).magnitude < dist then
18                    torso = temp
19                    dist = (temp.Position - pos).magnitude
20                end
21            end
22        end
23    end
24    return torso
25end
26 
27while true do
28    wait(0.1)
29    local target = findNearestTorso(script.Parent.Torso.Position)
30    if target ~= nil then
31        script.Parent.Enemy:MoveTo(target.Position, target)
32    end
33end
 View all 33 lines...

Really... You 1 took a free model, 2. Used a loop when I said I wish to prevent that, 3. Didn't even bother explaining anything (probably because you stole it) but still. Thanks for trying though I gotta give you that BlackOrange3343 2676 — 6y

Boy, I've been using this in RPG's for years. Zerixa_RBLX -2 — 6y

Lmao search up zombie in workspace and look at the script. BlackOrange3343 2676 — 6y

NPC Follow system works but after death it stops working [?]

Goal:

Problem:

Script:

2 answers

Answer this question