Scripting Helpers is winding down operations and is now read-only. More info→

How do I optimize my DataStore script?

Asked by

Morficc 36

8 years ago

Edited 8 years ago

Hey guys! I am currently making my first game. I originally started by importing free models, plugins, scripts, etc. But I wasn't learning anything and kept getting "viruses". So I scrapped that project and started fresh, attempting to do everything myself. So far, between using the wiki, and watching youtube videos, I have been able to hash together workable scripts. However.. they are not clean. Many redundancies, and silliness abound.

Today I have come to ask for some input. I am attempting to learn and create a datastore to store players money and lvl. I also am trying to store their abilities (Strength, Constitution, Agility, Intelligence). After watching multiple youtube videos, and reading the wiki, I have not been able to learn how to accomplish this cleanly, and correctly. I do believe what I have works, but I know that I can clean it up a ton, and use some arrays to consolidate redundancy, etc. Also, I am not sure if I am creating more tables than I need to, etc. Im pretty sure I could save all of my abilities to one table, instead of separately, but I don't really know how to accomplish this.

Could someone take a look at my script, and give me some pointers if you have time? Thanks!

01local DSService = game:GetService('DataStoreService'):GetDataStore('xxxxxxxxxxxxxx')
02 
03-- Variables
04local uniquekey = "id-"..plr.userId
05local leaderstats = Instance.new('IntValue',plr)
06local abilities = Instance.new('IntValue',plr)
07local colvalue = Instance.new('IntValue')
08local lvlvalue = Instance.new('IntValue')
09local strvalue = Instance.new('IntValue')
10local convalue = Instance.new('IntValue')
11local agivalue = Instance.new('IntValue')
12local intvalue = Instance.new('IntValue')
13 
14leaderstats.Name =  'leaderstats'
15lvlvalue.Parent = leaderstats
16colvalue.Parent = leaderstats
17strvalue.Parent = abilities
18convalue.Parent = abilities
19agivalue.Parent = abilities
20intvalue.Parent = abilities
21lvlvalue.Name = 'Lvl'
22colvalue.Name = 'Col'
23strvalue.Name = 'Strength'
24convalue.Name = 'Constitution'
25agivalue.Name = 'Agility'
26intvalue.Name = 'Intelligence'
27 
28-- GetAsync
29local GetSaved = DSService:GetAsync(uniquekey)
30if GetSaved then
31    colvalue.Value = GetSaved[1]
32    lvlvalue.Value = GetSaved[2]
33    strvalue.Value = GetSaved[3]
34    convalue.Value = GetSaved[4]
35    agivalue.Value = GetSaved[5]
36    intvalue.Value = GetSaved[6]
37else
38    local colSaving = {colvalue.Value}
39    local lvlSaving = {lvlvalue.Value}
40    local strSaving = {strvalue.Value}
41    local conSaving = {convalue.Value}
42    local agiSaving = {agivalue.Value}
43    local intSaving = {intvalue.Value}
44    DSService:SetAsync(uniquekey,colSaving)
45    DSService:SetAsync(uniquekey,lvlSaving)
46    DSService:SetAsync(uniquekey,strSaving)
47    DSService:SetAsync(uniquekey,conSaving)
48    DSService:SetAsync(uniquekey,agiSaving)
49    DSService:SetAsync(uniquekey,intSaving)
50end
51end)
52 
53game.Players.PlayerRemoving:connect(function(plr)
54local uniquekey = 'id-'..plr.userId
55local coltable = {plr.leaderstats.Col.Value}
56local lvltable = {plr.leaderstats.lvl.Value}
57local strtable = {plr.leaderstats.str.Value}
58local agitable = {plr.leaderstats.agi.Value}
59local inttable = {plr.leaderstats.int.Value}
60DSService:SetAsync(uniquekey,coltable)
61DSService:SetAsyne(uniquekey,lvltable)
62DSService:SetAsync(uniquekey,strtable)
63DSService:SetAsyne(uniquekey,contable)
64DSService:SetAsync(uniquekey,agitable)
65DSService:SetAsyne(uniquekey,inttable)
66end)
 View all 66 lines...

I did it for you this time, but in the future please enclose your code within a code block. https://forum.scriptinghelpers.org/topic/82/how-to-format-questions-answers-on-the-main-site Pyrondon 2089 — 8y

oh thank you Morficc 36 — 8y

2 answers

Answered by

Nogalo 148

8 years ago

Edited 8 years ago

Well for starters, for a cleaner look you could do this

1local colvalue = Instance.new("IntValue",leaderstats)
2    Trophies.Name = "Col"
3    colvalue.Value = 0

for each of the attributes.

When it comes to saving you can make a table that contains all the things you want saved.

1if GetSaved then
2--GetSaved
3else
4local attributeSaving = {colvalue.Value,lvlvalue.Value,strvalue.Value,convalue.Value,agivalue.Value,intvalue.Value}
5 
6local DSService:SetAsync(uniquekey,attributeSaving)
7end

you can do the same thing for the playerremoving event

To add to this, you could just have a 'leaderstats' folder in the script containing all the neccessary values and clone it into the client upon joining. This would save lines 5-26 Goulstem 8144 — 8y

I wasn't sure how to reply to this with my new code, so I replied as an answer to this post. Sorry if this was incorrect! Morficc 36 — 8y

Answered by

Morficc 36

8 years ago

Edited 8 years ago

@Nogalo:

Okay, I have made changes to my script based on your suggestions. It does look much cleaner and I can see how that method is much more efficient than what I had. Thank you :) However, I do have a few questions. In the top right leaderboard area, I now show 4 stats. "lvl, col, strength, constitution". I am curious as to why it only showed those values, and not agility, intelligence. Does the leaderboard area only show a max of 4 values? Secondly, in the script I set the "Value" of my abilities to 5, and the value of lvl to 1, thinking that would be the starting value. But they are all still showing up in the leaderboard area as 0. What does that value section signify?

@Goulstem:

I like the sound of that. How would I go about cloning the folder and where would I place it? Other than cleaning things up, is there any performance based impact from this method, for better or worse?

Thank you so much guys! Here is my newly revamped code, based on Nogalo's suggestions:

01local DSService = game:GetService('DataStoreService'):GetDataStore('xxxxxxxxxxxxxx')
02 
03game.Players.PlayerAdded:connect(function(plr)
04 
05-- Variables
06local uniquekey = "id-"..plr.userId
07local leaderstats = Instance.new('IntValue',plr)
08leaderstats.Name =  'leaderstats'
09 
10local lvlvalue = Instance.new("IntValue",leaderstats)
11    lvlvalue.Name = "lvl"
12  lvlvalue.Value = 1
13local colvalue = Instance.new("IntValue",leaderstats)
14    lvlvalue.Name = "Col"
15  colvalue.Value = 0
16local strvalue = Instance.new("IntValue",leaderstats)
17    lvlvalue.Name = "Strength"
18  strvalue.Value = 5
19local convalue = Instance.new("IntValue",leaderstats)
20    lvlvalue.Name = "Constitution"
21  convalue.Value = 5
22local agivalue = Instance.new("IntValue",leaderstats)
23    lvlvalue.Name = "Agility"
24  agivalue.Value = 5
25local intelvalue = Instance.new("IntValue",leaderstats)
26    lvlvalue.Name = "Intelligence"
27  intelvalue.Value = 5
28 
29-- GetAsync
30local GetSaved = DSService:GetAsync(uniquekey)
31if GetSaved then
32    colvalue.Value = GetSaved[1]
33    lvlvalue.Value = GetSaved[2]
34    strvalue.Value = GetSaved[3]
35    convalue.Value = GetSaved[4]
36    agivalue.Value = GetSaved[5]
37    intelvalue.Value = GetSaved[6]
38else
39local assigndata = {colvalue.Value,lvlvalue.Value,strvalue.Value,convalue.Value,agivalue.Value,intelvalue.Value}
40DSService:SetAsync(uniquekey,assigndata)
41end
42end)
43 
44game.Players.PlayerRemoving:connect(function(plr)
45local uniquekey = 'id-'..plr.userId
46local coltable = {plr.leaderstats.Col.Value}
47local lvltable = {plr.leaderstats.lvl.Value}
48local strtable = {plr.leaderstats.str.Value}
49local contable = {plr.leaderstats.con.Value}
50local agitable = {plr.leaderstats.agi.Value}
51local inttable = {plr.leaderstats.int.Value}
52local savedata = {coltable,lvltable,strtable,contable,agitable,inttable}
53DSService:SetAsync(uniquekey,savedata)
54end)
 View all 54 lines...

EDIT: I was able to answer 1 of my questions. My previous saved data was overriding the starting values. Once I renamed the datastore, all starting values displayed correctly.

also, I was tinkering around with doing something like:

1local Attributes = Player.attributes:GetChildren()
2    for i = 1, #Attributes do
3        Player:SaveNumber(Attributes[i].Name, Attributes[i].Value)
4    end

Would that be feasible? Less optimized/more optimized/roughly the same?

How do I optimize my DataStore script?

2 answers

Answer this question