I am trying to make players get teleported after time runs out. How do i fix?
Here is what i tried
01 | local startime = script.Parent.Timee |
02 | local substraction = - 1 |
03 | while true do |
04 | wait(0.1) |
05 | if startime.Value > 0 then |
06 | script.Parent.Text = startime.Value.. ' Seconds' |
07 | wait(0.5) |
08 | startime.Value = startime.Value - 1 |
09 |
10 | if startime.Value == 0 then |
11 | script.Parent.Text = 'Beginning' |
12 | for i,v in pairs(game.Players.GetChildren()) |
13 | i, torso.CFrame.new = (0, 0, 0) |
14 |
15 |
16 | end |
17 | end |
18 | end |
here is my output
1 | 23:08:34.180 - Plugin_276879563.HE-MONEY.LocalScript:4: '<name>' expected near '(' |
2 | 23:08:34.216 - Plugin_160457204.No Lag Script:7: 'end' expected (to close 'if' at line 6) near '<eof>' |
3 | 23:08:34.578 - Workspace.True.Script:10: 'end' expected (to close 'function' at line 1) near '<eof>' |
4 | 23:08:34.900 - Unable to find module for asset id |
5 | 23:08:34.900 - Stack Begin |
6 | 23:08:34.900 - Script 'Workspace.Kohl's Admin Infinite.Credit', Line 1 |
7 | 23:08:34.901 - Stack End |
8 | 23:08:35.036 - Players.Player1.PlayerGui.Intermission.Backround.Time.Time Changer:12: 'do' expected near 'i' |
0
0
3 answers
At line 12, you forgot to add the word "do" (not a string) to the end of the for loop.
But don't bother with that one, here's another script that will be far more efficient and use far less processor power. NumberValues (Which I assume you're using) have an event called Changed, which fires whenever the value of it is changed. Consider the following:
01 | local startime = script.Parent.Timee |
02 | local substraction = - 1 --Note: I think you may have misspelled here, make sure you don't cause any errors this way. |
03 | starttime.Changed:connect(function(val) --the Changed event provides val, the new value of the NumberValue, as an argument |
04 | wait(0.1) |
05 | if val > 0 then |
06 | script.Parent.Text = startime.Value.. ' Seconds' |
07 | wait(0.5) |
08 |
09 | if val - 1 == 0 then --Note that I didn't actually subtract the value, I simply calculated what would happen if it were to be subtracted |
10 | script.Parent.Text = 'Beginning' |
11 | for i,v in pairs(game.Players.GetChildren()) do --Note my addition of do! |
12 | --Each v is actually a player object, and not the player within the workspace. To get that, simply use v.Character |
13 | v.Character.Torso.CFrame.new = (0, 0, 0) --I also fixed capitalization here - the t in Torso is upercase when it comes to characters! |
14 | end |
15 | end |
16 | end) |
If you need to subtract the NumberValue, you know what to do. Hope I could help!
0
0
0
0
There are a couple of problems with this. The obvious ones being the missing do and the incorrect syntax of your attempt to teleport the player. These can be easily remedied:
01 | local startime = script.Parent.Timee |
02 | local substraction = - 1 |
03 | while true do |
04 | wait(0.1) |
05 | if startime.Value > 0 then |
06 | script.Parent.Text = startime.Value.. ' Seconds' |
07 | wait(0.5) |
08 | startime.Value = startime.Value - 1 |
09 |
10 | if startime.Value == 0 then |
11 | script.Parent.Text = 'Beginning' |
12 | for _,v in pairs(game.Players.GetChildren()) do |
13 | v.Character.Torso.CFrame = CFrame.new(0, 0, 0) |
14 | end; |
15 | end |
16 | end |
17 | end |
Also, using a while loop here isn't good; once it reaches 0, it'll keep running without actually doing anything other than waiting for one tenth of a second. You should use a for loop, instead:
01 | local startime = script.Parent.Timee |
02 | local substraction = - 1 |
03 | for _ = startime.Value, 1, -1 do |
04 | wait(0.1) |
05 | if startime.Value > 0 then |
06 | script.Parent.Text = startime.Value.. ' Seconds' |
07 | wait(0.5) |
08 | startime.Value = startime.Value - 1 |
09 |
10 | if startime.Value == 0 then |
11 | script.Parent.Text = 'Beginning' |
12 | for _,v in pairs(game.Players.GetChildren()) do |
13 | v.Character.Torso.CFrame = CFrame.new(0, 0, 0) |
14 | end; |
15 | end |
16 | end |
17 | end |
While this code should work fine, it can be improved upon. Your substraction variable on line 2 is never used; might as well just remove that entirely. Also, you'll want to check if Character.Torso exists (better safe than sorry).
Since you're using a for loop now, you can remove the if statement if startime.Value > 0, as this will always be true.
You may want to add a Changed event too, in order to run this code whenever the value is updated:
01 | local connection, update; |
02 | local startime = script.Parent.Timee |
03 | update = function() |
04 | connection:Disconnect(); |
05 | for _ = startime.Value, 1, -1 do |
06 | wait(0.1) |
07 | script.Parent.Text = startime.Value.. ' Seconds' |
08 | wait(0.5) |
09 | startime.Value = startime.Value - 1 |
10 |
11 | if startime.Value == 0 then |
12 | script.Parent.Text = 'Beginning' |
13 | for _,v in pairs(game.Players.GetChildren()) do |
14 | if v.Character:FindFirstChild('Torso') then |
15 | v.Character.Torso.CFrame = CFrame.new(0, 0, 0) |
Hope this helped!
Read more about functions, signals, for loops, generic for loops, and FindFirstChild.
First of all you could do this a lot easier than what you are already doing by using a second for loop as shown
01 | start_time = local startime = script.Parent.Timee |
02 |
03 | wait(1) |
04 | for i = start_time.Value, 1, -1 |
05 | local starttime = i |
06 | script.Parent.Text = starttime.Value.. 'Seconds' |
07 | if starttime == 0 then |
08 | script.Parent.Text = 'Beginning' |
09 | for i,v in pairs(game.Players.GetChildren()) do |
10 | if v.Character:FindFirstChild("Torso") then |
11 | v.torso.CFrame = CFrame.new(0, 0, 0) |
12 |
13 |
14 | end |
15 | end |
16 | end |
17 | end |