How would I go about stopping the KeyDown function?

Asked by

8 years ago

So, I've been working on this script for a short while now, and with the help of another SH member, I've been able to get it working.

01lscript = script.Parent:WaitForChild("LocalScript")
02 
03animation = lscript:WaitForChild("ShunStart")
04animation1 = lscript:WaitForChild("Salute")
05animation2 = lscript:WaitForChild("RightDress")
06animation3 = lscript:WaitForChild("AtEaseLoop")
07 
08local Player = game.Players.LocalPlayer
09local Mouse = Player:GetMouse()
10local animation = script.ShunStart
11local animation1 = script.Salute
12local animation2 = script.RightDress
13local animation3 = script.AtEaseLoop
14local animTrack = nil
15 
16script.Parent.Selected:connect(function()
17 
18    Mouse.KeyDown:connect(function(key)
19        if key == "q" then
20            for _,v in pairs(Player.Character:FindFirstChild("Humanoid"):GetPlayingAnimationTracks()) do v:Stop(0) end
21            animTrack = Player.Character:FindFirstChild("Humanoid"):LoadAnimation(animation)
22            animTrack:Play()
23        end
24    end)
25 
26    Mouse.KeyDown:connect(function(key)
27        if key == "r" then
28            for _,v in pairs(Player.Character:FindFirstChild("Humanoid"):GetPlayingAnimationTracks()) do v:Stop(0) end
29            animTrack = Player.Character:FindFirstChild("Humanoid"):LoadAnimation(animation2)
30            animTrack:Play()
31        end
32    end)
33 
34    Mouse.KeyDown:connect(function(key)
35        if key == "t" then
36            for _,v in pairs(Player.Character:FindFirstChild("Humanoid"):GetPlayingAnimationTracks()) do v:Stop(0) end
37            animTrack = Player.Character:FindFirstChild("Humanoid"):LoadAnimation(animation3)
38            animTrack:Play()
39        end
40    end)
41 
42    Mouse.KeyDown:connect(function(key)
43        if key == "e" then
44            for _,v in pairs(Player.Character:FindFirstChild("Humanoid"):GetPlayingAnimationTracks()) do v:Stop(0) end
45            animTrack = Player.Character:FindFirstChild("Humanoid"):LoadAnimation(animation1)
46            animTrack:Play()
47            wait(3)
48            animTrack:Stop()
49            animTrack = Player.Character:FindFirstChild("Humanoid"):LoadAnimation(animation)
50            animTrack:Play()
51        end
52    end)
53 
54    Mouse.KeyDown:connect(function(key)
55        local Key = key:lower()
56        if Key == "p" then
57            for _,v in pairs(Player.Character:FindFirstChild("Humanoid"):GetPlayingAnimationTracks()) do v:Stop(0) end
58        end
59    end)
60 
61    script.Parent.Deselected:connect(function()
62        for _,v in pairs(Player.Character:FindFirstChild("Humanoid"):GetPlayingAnimationTracks()) do v:Stop(0) return end
63    end)
64    end)
 View all 64 lines...

The issue I seem to have is that, I tried to make it so that these animations would only play when the tool is selected, and that they'd stop being played once the tool is deselected.

So, for example; when the tool is selected, the animations will play when a key is pressed, but when the tool is not selected, the animations will not play when the keys are pressed.

It seems all that deselecting the tool does is stop the animations, which, whilst this is helpful, this really isn't what I wish to happen.

Again, help is much appreciated.

To elaborate further, this is a localscript within a hopperbin. The issue I'm having is that when the tool is deselecting, the keys still trigger the animations. I wish to make it so that when the hopperbin is deselected, pressing the keys will not trigger the animations. BritishActuaI 44 — 8y

Use regular tool objects, hopperbins are very outdated, and ROBLOX doesn't recommend use of them anymore. ScriptGuider 5640 — 8y

Creating event listeners

When creating an event listener, you should make sure it's not in any circumstance where it will be re-created over and over again... Unless you plan on disconnecting them after you're done. In your script, you have it so that every time your character equips their tool, it creates all of those event listeners all over again. This is a very bad idea (in retrospect, you could have used one KeyDown event, and had several if/elseif statements for different keys, but I still do not recommend using the PlayerMouse object for user input).

Implementing UserInputService!

Now I'll show you an example of how you can implement UserInputService in your code making it a lot shorter, organized, and efficient.

01local InputService = game:GetService("UserInputService")
02 
03local lscript = script.Parent:WaitForChild("LocalScript")
04 
05local animation = lscript:WaitForChild("ShunStart")
06local animation1 = lscript:WaitForChild("Salute")
07local animation2 = lscript:WaitForChild("RightDress")
08local animation3 = lscript:WaitForChild("AtEaseLoop")
09 
10local Player = game.Players.LocalPlayer
11local Mouse = Player:GetMouse()
12local Tool = script.Parent -- Creating a variable for this is nice too.
13local animation = script.ShunStart
14local animation1 = script.Salute
15local animation2 = script.RightDress
16local animation3 = script.AtEaseLoop
17local animTrack = nil
18local toolSelected = false -- Create a gate for when the Tool is selected
19 
20-- When the tool is equipped, change 'toolSelected' to true allowing our gate in the InputBegan event to open.
21Tool.Equipped:connect(function()
22    toolSelected = true
23end)
24 
25-- When it's unequipped, revert the value.
26Tool.Unequipped:connect(function()
27    toolSelected = false
28end)
29 
30-- InputBegan listener
31InputService.InputBegan:connect(function(Input)
32    local KeyInput = Input.KeyCode
33    if toolSelected then -- Gate to make sure tool is selected
34        if KeyInput == Enum.KeyCode.A then
35            -- Code
36        elseif KeyInput == Enum.KeyCode.B then
37            -- Alternative outcome
38        elseif KeyInput == Enum.KeyCode.C then
39            -- Something else
40        end
41    end
42end)
 View all 42 lines...

If you have any questions, just let me know and I'll get to them asap.

How would I go about stopping the KeyDown function?

1 answer

User input

Creating event listeners

Implementing UserInputService!

Answer this question