Can't find the logical error in my code [Datastores]?

Asked by

8 years ago

Hello.I've spent at least a few hours now trying to debug/find the error of what is causing the issue to occur,but to no avail.Here is my issue:

When a Player joins the game,their data is loaded from the datastore and put into their data folder in ServerStorage.

When a Player leaves the game,their data is put into a metatable and saved to the datastore.

Pretty straightforward,until the bug comes in.

For some odd reason,the weapons and pets that the player owns are cloned repeatedly inside the datastore.Also,data between two players gets mixed together for some odd reason..

For example:

Player A owns the weapon "LinkedSword".It is saved in the 'Weapons' metatable,and inside the 'Weapons' folder when loaded into his/her datafolder.Player A owns the pet "Doge",which is saved inside the 'Pets' metatable,and inside the 'Pets' folder when loaded into the datafolder.

With Player B,the same scenario is in place with how the data is stored. Player B owns the weapon "GolfClub",and owns the pet "Kitty".

All runs well,when the player joins their data is loaded into the server,when they leave the data is put inside a metatable and saved to the datastore.But here's the problem:

Next time Player A's data is loaded,he/she now owns the pets "Doge" and "Kitty" and "Kitty" and "Kitty" (Yes,the cloning is what happens).Same with the saved weapons.The data seems to "Cross" between the two players,even though they have their own seperate datafolders.

I am completely stumped.If someone can point out the logic error,please do. Thanks!

Here is the code:

DataService script:

001--[[
002 
003    Data Service
004    Handles the loading,saving,and handling of user data.   
005 
006--]]
007 
008--Waiting for the main framework to load.
009_G.DataServiceReady=false
010while _G.ServerReady==nil or _G.ServerReady==false do
011wait()
012end
013--Calling the datastore service
014local DataStore=game:GetService("DataStoreService"):GetDataStore(_G.Config.DataStoreName)
015 
016--Declaring vairables and functions
017_G.BaseData={
018ChosenWeapon="", --The weapon that the user is actively using
019Version=1,            --The users data version.Used to add more metatables if the base data is updated.
020Money=0,              --The users current amount of NoobCoins
021Level=1,              --The users current level
022ChosenPet="",     --The current pet the user has chosen
023NoobChance=1,         --How likely the user will become a noob.
024Pets={},              --A table holding the pets the user owns
025Weapons={}            --A table holding the weapons the user owns
026}
027 
028--Gets the specified users data,and returns it.WILL return nil if it doesn't
029--exist.
030--Usage: _G.GetUserData(Object PLAYER)
031--Example:_G.GetUserData(game.Players.Reshiram110)
032_G.GetUserData=function(Player)
033if DataStore:GetAsync("User_"..Player.userId)==nil then
034local dat=_G.BaseData
035dat.ChosenWeapon="LinkedSword"
036table.insert(dat.Weapons,"LinkedSword")
037return dat
038else
039return DataStore:GetAsync("User_"..Player.userId)
040end
041end
042 
043--Saves the specified users data.WILL return nil if it doesn't exist.
044--Usage:_G.SaveUserData(Object PLAYER,Table DATATABLE)
045--Example:_G.SaveUserData(game.Players.Reshiram110,UserDataTable)
046_G.SaveUserData=function(Player,NewValue)
047DataStore:SetAsync("User_"..Player.userId,NewValue)
048end
049 
050--Unpacks the users data loaded from the datastore into the 'UserData' folder.
051--Usage:_G.UnpackUserData(Table Data,Object Player)
052--Example:_G.UnpackUserData(_G.GetUserData(game.Players.Reshiram110))
053_G.UnpackUserData=function(Data,Player)
054local f=Instance.new('Folder',game.ServerStorage.UserData)
055f.Name=Player.Name
056local v=Instance.new('StringValue',f)
057v.Name="ChosenWeapon"
058v.Value=Data.ChosenWeapon
059local v=Instance.new('IntValue',f)
060v.Name="Version"
061v.Value=Data.Version
062local v=Instance.new('IntValue',f)
063v.Name="Money"
064v.Value=Data.Money
065local v=Instance.new('IntValue',f)
066v.Name="Level"
067v.Value=Data.Level
068local v=Instance.new('StringValue',f)
069v.Name="ChosenPet"
070v.Value=Data.ChosenPet
071local v=Instance.new('IntValue',f)
072v.Name="NoobChance"
073v.Value=Data.NoobChance
074--Iterating through the metatables Data
075local v=Instance.new('Folder',f)
076v.Name="Pets"
077for i,v in pairs(Data.Pets) do
078local va=Instance.new('StringValue',f.Pets)
079va.Name="Pet"
080va.Value=v
081end
082local v=Instance.new('Folder',f)
083v.Name="Weapons"
084for i,v in pairs(Data.Weapons) do
085local va=Instance.new('StringValue',f.Weapons)
086va.Name="Weapon"
087va.Value=v
088end
089end
090 
091--Packs the users data from the userdata folder into a table,ready to be saved to the games datastore.
092--Usage:_G.PackuserData(Folder DataFolder)
093--Example:_G.PackUserData(game.ServerStorage.UserData.Reshiram110)
094_G.PackUserData=function(DataFolder)
095local data=_G.BaseData --Defining a 'Frame' for the users data.
096data.ChosenWeapon=DataFolder.ChosenWeapon.Value
097data.Money=DataFolder.Money.Value
098data.Level=DataFolder.Level.Value
099data.ChosenPet=DataFolder.ChosenPet.Value
100--Iterating through the metatable folders
101for i,v in pairs(DataFolder.Pets:GetChildren()) do
102table.insert(data.Pets,v.Value)
103end
104for i,v in pairs(DataFolder.Weapons:GetChildren()) do
105table.insert(data.Weapons,v.Value)
106end
107return data
108end
109 
110 
111--Data Service is ready,mark it as ready.
112_G.DataServiceReady=true
 View all 112 lines...

PlayerEvents script:

01--[[
02 
03    Player Service
04    Handles player events,such as spawning,joining,dyeing,etc.  
05 
06--]]
07 
08--Defining Services and vairables
09local PlayerService=game:GetService("Players")
10 
11--Configuring the services and vairables
12PlayerService.CharacterAutoLoads=false
13 
14--Player joined event
15PlayerService.PlayerAdded:connect(function(Player)
16print("[Player Service] "..Player.Name.." has joined the game.")
17 
18--Waiting for the framework to load.
19while _G.ServerReady==nil or _G.ServerReady==false do
20wait()
21end
22_G.WaitForServices()
23 
24Player:LoadCharacter() --Load the player's character for the first time.
25if _G.Config.Maintence==false then --If maintence mode is turned off...
26_G.UnpackUserData(_G.GetUserData(Player),Player) --Loading their data into the server.
27_G.LoadPet(Player,true) --Loading the players pet
28end
29end)
30 
31 
32--Player leaving event
33PlayerService.PlayerRemoving:connect(function(Player)
34print("[Player Service] ".. Player.Name.." has left the game.")
35_G.LoadPet(Player,false)
36_G.SaveUserData(Player,_G.PackUserData(game.ServerStorage.UserData[Player.Name]))
37end)
 View all 37 lines...

There is a lot that needs to be looked at here, none of your data store processing is 'safe' and there is no need to use global variable her at all. User#5423 17 — 8y

I use global functions so I don't have to type in the same code again and again. Reshiram110 147 — 8y

We use module scripts. User#5423 17 — 8y

I use module scripts as well. I tend to use them as a library. Reshiram110 147 — 8y

Can't find the logical error in my code [Datastores]?

Answer this question