Scripting Helpers is winding down operations and is now read-only. More info→

Why wont my createlabel function work correctly?

Asked by

BadLuke1 2

8 years ago

I am trying to make it easier by making a function that makes textlabels automatically

When I do this they are all together in one position.

01local Plr = game.Players.LocalPlayer
02 
03local function Cc(Nme, Dsc, Prnt, Pos1)
04    local t = Instance.new("TextLabel", Prnt)
05    t.Name = Nme
06    t.BackgroundTransparency = 0.35
07    t.BackgroundColor3 = Color3.new(0,0,0)
08    t.Size = UDim2.new(0,280,0,15)
09    t.BorderSizePixel = 0
10    t.TextColor3 = Color3.new(255,255,255)
11    t.FontSize = Enum.FontSize.Size10
12    t.TextWrapped = true
13    t.Text = Dsc
14    t.Position = UDim2.new(0,7.5,0,0+Pos1)
15end
16 
17if Plr and Plr.PlayerGui then
18    if Plr.PlayerGui:FindFirstChild("CommandsInterface") then
19        game.Debris:AddItem(Plr.PlayerGui["CommandsInterface"],0)
20    end
21    local S = Instance.new("ScreenGui", Plr.PlayerGui)
22    local F = Instance.new("Frame", S)
23    local Sc = Instance.new("ScrollingFrame", F)
24    local C = Instance.new("TextButton", F)
25    S.Name = "CommandsInterface"
26    F.Size = UDim2.new(0,300,0,300)
27    F.Position = UDim2.new(0.5,-150,0.5,-150)
28    F.Active = true
29    F.Draggable = true
30    F.BackgroundTransparency = 0.75
31    F.BorderSizePixel = 3.5
32    F.BorderColor3 = Color3.new(255,255,255)
33    F.BackgroundColor3 = Color3.new(0,0,0)
34    Sc.Size = F.Size
35    Sc.BackgroundTransparency = 1
36    Sc.Position = UDim2.new(0,0,0,0)
37    C.TextColor3 = Color3.new(255,255,255)
38    C.Font = Enum.Font.Arial
39    C.FontSize = Enum.FontSize.Size14
40    C.Position = UDim2.new(0,0,0,0)
41    C.Text = "X"
42    C.Size = UDim2.new(0,10,0,10)
43    C.BackgroundTransparency = 1
44    Cc("t1", "Shutdown  [Owners]",Sc,17)
45    Cc("t2", "Clean  [All]",Sc,17)
46    Cc("t3", "Fix  [All]",Sc,17)
47    Cc("t4", "Disco  [All]",Sc,17)
48    Cc("t5", "Music 'N'  [All]",Sc,17)
49    C.MouseButton1Down:connect(function()
50        game.Debris:AddItem(S,0)
51    end)
52end
 View all 52 lines...

Please help

not an answer, but those are some bad variable names Kampfkarren 215 — 8y

Variable names dont matter when they are just used in a script ;) BadLuke1 2 — 8y

To correct you, variable names do matter, you should never overwrite reserved commands with a variable name Sublimus 992 — 8y

2 answers

Answered by

ClimaxDarkness 170

8 years ago

misiunicholas is right. The Pos1 argument is always set to 17 in the five calls in lines 44 to 48. Either change these, or do the following:

01local Plr = game.Players.LocalPlayer
02local lastTextLabelPosition = 0
03 
04local function Cc(Nme, Dsc, Prnt, Pos1)
05    local t = Instance.new("TextLabel", Prnt)
06    t.Name = Nme
07    t.BackgroundTransparency = 0.35
08    t.BackgroundColor3 = Color3.new(0,0,0)
09    t.Size = UDim2.new(0,280,0,15)
10    t.BorderSizePixel = 0
11    t.TextColor3 = Color3.new(255,255,255)
12    t.FontSize = Enum.FontSize.Size10
13    t.TextWrapped = true
14    t.Text = Dsc
15    t.Position = UDim2.new(0,7.5,0,lastTextLabelPosition+Pos1)
16    lastTextLabelPosition= lastTextLabelPosition+Pos1
17end

Answered by

misiunicholas 50

8 years ago

Well when you execute the function from line 44 to 48 you set the argument Pos1 all to 17

Why wont my createlabel function work correctly?

2 answers

Answer this question