ScrollbarFrame not showing items properly?
Hi, I've made a scrollbar frame that is supposed to list every item in the players backpack. Ill show you what I've done so far before I explain what is wrong.
And just for reference if you're going to post an answer where it checks if a certain item exists in the backpack then doesn't add it again... The player can have more than one of that item if they wish.
01 | local itemTemplate = script.Parent.Item |
02 | player = script.Parent.Parent.Parent.Name |
03 | items = {} |
04 | itemY = -50 |
05 |
06 | while true do |
07 | local backpackItems = game.Players[player].Backpack:getChildren() |
08 | for i=1,#backpackItems do |
09 | table.insert(items, backpackItems[i].Name) |
10 | itemY = itemY + 50 |
11 | print(player .. " has " .. items[i]) |
12 | if #items <= #backpackItems then |
13 | local a = itemTemplate:Clone() |
14 | a.Parent = script.Parent.ScrollingFrame |
15 | a.Position = UDim2.new(0, 0, 0, itemY) |
There are a few bugs I can get my head around ill list them here;
The starting item is one black pickaxe, but for some reason the UI outputs two. I've uploaded a picture below https://gyazo.com/ff243a9ecd690c9648763f22b261edc2
Also I have to clear the table each loop to allow it to add more items, otherwise it thinks you've got 4 pickaxes when you could have two. Which causes there to be an unlimited amount of text buttons (Image below) https://gyazo.com/da4bdd21dce7f455b2a72e88ca5db59f
I've definitely gone horribly wrong somewhere and can quite work out ways around this. Maybe i'm just too tired at the moment, who knows?
But anyway if you've got any idea on how to fix this ill greatly appreciate it! Thanks, Cuv
2 answers
In your while loop, you set the itemY to 0 when you actually want it set to -50.
Before the wait(0.5), change itemY = 0 to itemY = -50
You should probably clear the ScrollingFrame every loop to make sure you don't have thousands of text buttons.
Soo, after the wait(0.5), script.Parent.ScrollingFrame:ClearAllChildren()
0
01 | itemTemplate = script.Parent.Item |
02 | items = {} |
03 | NewPos = UDim2.new(0,0,0.1,0) -- X.Scale, X.Offset, Y.Scale, Y.Offset. |
04 | game.Players.LocalPlayer.Backpack.ChildAdded:connect(function() -- Fires when child is added |
05 | script.Parent.ScrollingFrame:ClearAllChildren() --Clears all children |
06 | for i = 1,#items do |
07 | table.remove(items,i) -- Clears the table |
08 | end |
09 | for i,v in pairs (game.Players.LocalPlayer.Backpack:GetChildren()) do -- Grabs all tools |
10 | print(v.Name) |
11 | table.insert(items,#items+1,v.Name) -- Inserts into table |
12 | local a = itemTemplate:Clone() |
13 | a.Parent = script.Parent.ScrollingFrame |
14 | a.Position = a.Position + NewPos |
15 | a.Text = items[i] |
16 | a.Visible= true |
17 | a.Name = v.Name |
18 | end |
19 | end) |
So basicly, read my notes, You can create this function in general, but .changed doesnt want to work. Maby just a bug.
And please, DONT use space, press the tab button once.... thanks!