Scripting Helpers is winding down operations and is now read-only. More info→
Log in to vote
0
Redstone in Roblox, Script not Working, Needs to be fixed, nothing happens?
01 | while wait() do |
02 | function onTouched(hit) |
03 | local a = hit:FindFirstChild("Power") |
04 | if (a==nil)==false then |
05 | if (a.Value==nil)==false |
06 | then script.Parent.Power.Value=true |
07 | else script.Parent.Power.Value=false |
08 | end |
09 | end |
10 | end |
11 | end |
12 |
13 | script.Parent.touched:connect(onTouched) |
This script doesn't work.
Basically in workspace there is a part which is supposed to be like redstone (except in Roblox), if this part contacts another part, it goes to see if it has a bool value called "Power", if it finds a bool value called power it will check it's value, if it's value is true, then the part's own power value will be put onto true, and transmit it to the next part. Please help.
1 answer
Log in to vote
2
1: ~= is "does not equal"
2: not is the same as == false (and is shorter and less messy
3: a == nil can be shortened to not a
4: not not a can be shortened to a
5: That is not how you connect events.
01 | --We don't need no loops. |
02 | function onTouched(hit) |
03 | local a = hit:FindFirstChild("Power") |
04 | if a and a.Value then --Use and to reduce if statements. |
05 | script.Parent.Power.Value = true |
06 | else |
07 | script.Parent.Power.Value = false |
08 | end |
09 | --Alternate: script.Parent.Power.Value = (a and a.Value) |
10 | end |
11 |
12 | script.Parent.Touched:connect(onTouched) --uppercase T in "Touched" |
0
@RobloxianDav Also note that the while loop was pointless and infinite (so it'll stop your code there indefinitely), meaning that Line 13 couldn't run. TheDeadlyPanther 2460 — 8y