Scripting Helpers is winding down operations and is now read-only. More info→

Why is this script detecting words out of context?

Asked by

chrono2 189

8 years ago

This script is supposed to detect when a player says anything with the words "What", "He", and "Do", or "What", "It", and "Do", or "What", "You", and "Do".

However, while it does so just fine, it also detects "He", "It", and "You" in any context with or without the other words.

01        words = {
02--["Explain Function"]
03        words = {
04            {"What","It","Do"},
05            {"What","He","Do"},
06            {"What","You","Do"},
07        },
08                func = function( p ) -- functions go HERE
09            print(p.Name .. " asked Faraday to explain his function")
10            game.ServerScriptService.FaraVoice.Value = "Currently I am programmed to respond to certain phrases, however soon I will run this house."
11            wait(0.3)
12            local text = game.ServerScriptService.FaraVoice.Value
13            local y = game:GetService("Chat"):Chat(Interfaces, ""..text, Enum.ChatColor.Green)  
14        end
15}
16}
17function onChatted(msg, recipient, speaker)
18    print("chatted")
19    local source = speaker
20    msg = string.lower(msg)
21    print(#phrases,type(phrases))
22    for a=1,#phrases do--search command types
23        local _a = phrases[a].words
24        for b=1,#_a do -- search words
25            local _b = _a[b]
26            if(msg:match(string.lower(_b[2])))then
27                print(msg,_a[2])
28                phrases[a].func(source)
29                return
30            end
31        end
32    end
33end
34function onPlayerEntered(newPlayer)
35    newPlayer.Chatted:connect(function(msg, recipient) onChatted(msg, recipient, newPlayer) end)
36end
37game.Players.ChildAdded:connect(onPlayerEntered)
 View all 37 lines...

2 answers

Answered by

patrline5599 150

8 years ago

You altered the code I gave you in a way that makes it work really differently. I don't really even know what your word sort algorithm results in. Anyways, I updated the same one I made you yesterday to do what you want.

Should be straightforward

01match = nil
02 
03phrases = {
04    ["Amour"] = {
05        words = {
06            {"Jarvis" , "Armour" , "pls"},
07            {"Jarvis" , "Armour"},
08            {"Jarvis" , "Give" , "Armour"} 
09        },
10        func = function( p ) -- functions go HERE
11            print(p.Name .. " activated armor function")    
12        end
13    },
14    ["Health"] = {
15        words = {
16            {"Jarvis","Heal"},
17            {"Jarvis","Dying","Help"},
18            {"Jarvis","love","cocaine"}
19        },
20 
21        func = function( p ) -- functions go HERE
22            print(p.Name .. " activated health function")   
23        end
24 
25    }
26}
27 
28 
29function onChatted(msg, recipient, speaker) 
30 
31    print("chatted")
32    local source = speaker
33    msg = string.lower(msg) 
34 
35    match = nil
36 
37    for i,v in pairs(phrases) do
38        if match~=nil then break end
39        print("no match, scanning")
40 
41 
42        for b,wT in pairs(v.words) do
43            local allFound = true
44            if match ~= nil then break end
45            print("# words = " .. #wT)
46            for u,c in pairs(wT) do
47                if not msg:match(string.lower(c)) then
48                    allFound = false
49                else
50                    --print("match = " .. string.lower(c))
51                end
52            end
53            if allFound and match == nil then
54                match = v
55                --print("match = " .. tostring(v))
56            end
57        end
58 
59    end
60 
61    if match then
62        print("match found, running function")
63        match.func(source)
64        match = nil
65    end
66 
67end
68 
69function onPlayerEntered(newPlayer) 
70newPlayer.Chatted:connect(function(msg, recipient) onChatted(msg, recipient, newPlayer) end) 
71end
72 
73game.Players.ChildAdded:connect(onPlayerEntered) 
 View all 73 lines...

Thanks for that. I basically just used your code as a template to make my own with some help from a friend, because I couldn't understand yours well enough to make it do what I wanted it to. I thought I PMed you about it, but I guess I was wrong. Anyway, thanks again! You're the reason this project is even possible. chrono2 189 — 8y

Answered by

Objectly 49

8 years ago

Edited 8 years ago

Please provide code with your answers. Simply posting an explanation does not help someone new to programming understand how to implement a concept programatically.

1function onChatted(message, recipient, speaker)
2    local actualRecipient = "Admin"
3    if recipient == actualRecipient then
4        --The rest of your code there.
5    end
6end

That's because it happens anytime when the player chats.

I believe the solution is for you to specify the recipient that should respond and if the recipient argument matches the variable, then the function executes.

The above code does that for you. You can paste your code within the if/then. If the recipient is the wanted recipient, then your function should check the words.

How would that change anything though? It works fine if I'm using only 2 word phrases, but when I put in a third it detects it without the other two. chrono2 189 — 8y

Why is this script detecting words out of context?

2 answers

Answer this question