Scripting Helpers is winding down operations and is now read-only. More info→

I need help on getting a card selecter to work. Please?

Asked by

8 years ago

I am trying to create a game where it displays a random poker card, but I cannot get it to work. Here is the code I am using:

001c1 = game.workspace.c1.Decal
002function onClicked()
003    local a = math.random("1", "52")
004    print(a)
005    if a==1 then
006        c1.Texture=rbxassetid://393533133
007    elseif a==2 then
008        c1.Texture=rbxassetid://171982569
009    elseif a==3 then
010        c1.Texture=rbxassetid://171982595
011    elseif a==4 then
012        c1.Texture=rbxassetid://171984344
013    elseif a==5 then
014        c1.Texture=rbxassetid://171984333
015    elseif a==6 then
016        c1.Texture=rbxassetid://171984320
017    elseif a==7 then
018        c1.Texture=rbxassetid://171984303
019        elseif a==8 then
020        c1.Texture=rbxassetid://171982720
021        elseif a==9 then
022        c1.Texture=rbxassetid://171982735
023        elseif a==10 then
024        c1.Texture=rbxassetid://171982748
025        elseif a==11 then
026        c1.Texture=rbxassetid://171982776
027        elseif a==12 then
028        c1.Texture=rbxassetid://171982807
029        elseif a==13 then
030        c1.Texture=rbxassetid://171982794
031        elseif a==14 then
032        c1.Texture=rbxassetid://171982338
033        elseif a==15 then
034        c1.Texture=rbxassetid://171982229
035        elseif a==16 then
036        c1.Texture=rbxassetid://171982240
037        elseif a==17 then
038        c1.Texture=rbxassetid://171982250
039        elseif a==18 then
040        c1.Texture=rbxassetid://171982260
041        elseif a==19 then
042        c1.Texture=rbxassetid://171982268
043        elseif a==20 then
044        c1.Texture=rbxassetid://171982281
045        elseif a==21 then
046        c1.Texture=rbxassetid://171982292
047        elseif a==22 then
048        c1.Texture=rbxassetid://171982315
049        elseif a==23 then
050        c1.Texture=rbxassetid://171982324
051        elseif a==24 then
052        c1.Texture=rbxassetid://171982376
053        elseif a==25 then
054        c1.Texture=rbxassetid://171982420
055        elseif a==26 then
056        c1.Texture=rbxassetid://171982407
057        elseif a==27 then
058        c1.Texture=rbxassetid://171983024
059        elseif a==28 then
060        c1.Texture=rbxassetid://171982928
061        elseif a==29 then
062        c1.Texture=rbxassetid://171982942
063        elseif a==30 then
064        c1.Texture=rbxassetid://171982949
065        elseif a==31 then
066        c1.Texture=rbxassetid://171982956
067        elseif a==32 then
068        c1.Texture=rbxassetid://171982965
069        elseif a==33 then
070        c1.Texture=rbxassetid://171982976
071        elseif a==34 then
072        c1.Texture=rbxassetid://171982986
073        elseif a==35 then
074        c1.Texture=rbxassetid://171983007
075        elseif a==36 then
076        c1.Texture=rbxassetid://171983010
077        elseif a==37 then
078        c1.Texture=rbxassetid://171983031
079        elseif a==38 then
080        c1.Texture=rbxassetid://171983046
081        elseif a==39 then
082        c1.Texture=rbxassetid://171983040
083        elseif a==40 then
084        c1.Texture=rbxassetid://171982129
085        elseif a==41 then
086        c1.Texture=rbxassetid://171981991
087        elseif a==42 then
088        c1.Texture=rbxassetid://171982041
089        elseif a==43 then
090        c1.Texture=rbxassetid://171982049
091        elseif a==44 then
092        c1.Texture=rbxassetid://171982055
093        elseif a==45 then
094        c1.Texture=rbxassetid://171982068
095        elseif a==46 then
096        c1.Texture=rbxassetid://171982074
097        elseif a==47 then
098        c1.Texture=rbxassetid://171982085
099        elseif a==48 then
100        c1.Texture=rbxassetid://171982096
101        elseif a==49 then
102        c1.Texture=rbxassetid://171982119
103        elseif a==50 then
104        c1.Texture=rbxassetid://171982151
105        elseif a==51 then
106        c1.Texture=rbxassetid://171982169
107        elseif a==52 then
108        c1.Texture=rbxassetid://171982157
109    end
110end
111 
112game.Workspace.Reset.ClickDetector.MouseClick:connect(onClicked)
 View all 112 lines...

I get the error (6,25) Expected identifier, got '/' in Script Analysis, as well as error Workspace.Reset.Script:6: '<name>' expected near '/' in output.

It needs to be a string, .Texture = "rbxassetid://1234", also, try using tables and iterations next time,it's easier. 1N0body 206 — 8y

1 answer

Answered by

User#5423 17

8 years ago

Building upon 1N0body comment there are two general rules of programming which needs to be looked at.

"Duplicate code" - a big giveaway that your design/method of codeing needs to be changed, we write code once and only once. Then we can re-use it, this makes our code much more maintainable in the long run. There may be exceptions to this.

"Maintainability" - with this current design of code it would take a long time to add to e.g. in the middle of your if statements as well as you have fixed variables for something which may change.

optimize code

01local c1 = game.workspace.c1.Decal
02 
03-- just make a list so we dont need have lots of elseif 
04local textureList = {
05    'rbxassetid://393533133','rbxassetid://171982569','rbxassetid://171982595','rbxassetid://171984344',
06    'rbxassetid://171984333','rbxassetid://171984320','rbxassetid://171984303','rbxassetid://171982720',
07    'rbxassetid://171982735','rbxassetid://171982748','rbxassetid://171982776','rbxassetid://171982807',
08    'rbxassetid://171982794','rbxassetid://171982338','rbxassetid://171982229','rbxassetid://171982240',
09    'rbxassetid://171982250','rbxassetid://171982260','rbxassetid://171982268','rbxassetid://171982281',
10    'rbxassetid://171982292','rbxassetid://171982315','rbxassetid://171982324','rbxassetid://171982376',
11    'rbxassetid://171982420','rbxassetid://171982407','rbxassetid://171983024','rbxassetid://171982928',
12    'rbxassetid://171982942','rbxassetid://171982949','rbxassetid://171982956','rbxassetid://171982965',
13    'rbxassetid://171982976','rbxassetid://171982986','rbxassetid://171983007','rbxassetid://171983010',
14    'rbxassetid://171983031','rbxassetid://171983046','rbxassetid://171983040','rbxassetid://171982129',
15    'rbxassetid://171981991','rbxassetid://171982041','rbxassetid://171982049','rbxassetid://171982055',
16    'rbxassetid://171982068','rbxassetid://171982074','rbxassetid://171982085','rbxassetid://171982096',
17    'rbxassetid://171982119','rbxassetid://171982151','rbxassetid://171982169','rbxassetid://171982157'
18}
19 
20function onClicked()
21    local num = math.random(1, #textureList) -- the #  is used to get then number of elements within the table
22    --this means that we do not need to change this code when we add or remove from the list
23 
24    print(num)
25    c1.Texture=textureList[num] -- instead of using the long if statement we can simply pick the index from out pre made table
26    -- this save both processing time and allows us to easily add to the list
27end
28 
29game.Workspace.Reset.ClickDetector.MouseClick:connect(onClicked)
 View all 29 lines...

I need help on getting a card selecter to work. Please?

1 answer

Answer this question