Playerlist not functioning properly?
01 | local frame = script.Parent |
02 | local labels = {} |
03 |
04 | for i = 1, game.Players.MaxPlayers do |
05 | labels[i] = frame:WaitForChild("Player"..i) |
06 | end |
07 |
08 | local players = game.Players:GetPlayers() |
09 |
10 | for number = 1, #labels do |
11 | labels[number].Text = tostring(players[number] or "") |
12 | end |
08:39:02.906 - Infinite yield possible on 'Players.Player1.PlayerGui.PlayerListUI.PlayerListFrame:WaitForChild("Player11")'
08:39:02.908 - Script 'Players.Player1.PlayerGui.PlayerListUI.PlayerListFrame.LocalScript', Line 7
08:39:02.909 - Stack End
I have 10 TextLabels inside the frame, and I have it set so the MaxPlayers is 10 per server. It works when I join the actual game, but it doesn't work in studio, and I have the error that is printed in the output above.
1 answer
You don't need to be checking how many players there are, you can just iterate through the labels and set the text of that label to the name of that player (or blank if there are no more players.)
1 | local frame = script.Parent |
2 | local labels = {} |
3 | for i = 1, game.Players.MaxPlayers do |
4 | labels[i] = frame:WaitForChild("Player"..i) |
5 | end |
6 | local players=game.Players:GetPlayers() |
7 | for number = 1, #labels do |
8 | labels[number].Text = tostring(players[number] or "") |
9 | end |
edit: If you want it to update whenever a player joins/leaves, connect it to PlayerAdded and PlayerRemoving:
01 | local frame = script.Parent |
02 | local labels = {} |
03 | for i = 1, game.Players.MaxPlayers do |
04 | labels[i] = frame:WaitForChild("Player"..i) |
05 | end |
06 | function update() |
07 | local players=game.Players:GetPlayers() |
08 | for number = 1, #labels do |
09 | labels[number].Text = tostring(players[number] or "") |
10 | end |
11 | end |
12 | game.Players.PlayerAdded:connect(update) |
13 | game.Players.PlayerRemoving:connect(update) |
14 | update() |
0
0
0
0
0
0
0
0