My TextLabel's text doesn't change when I run this script?
I'm building an airport with a friend, and I want to make a single main script that handles all the functions that the airport does.
There is a SurfaceGui in the airport that shows departure times (in seconds). I managed to make a NumberValue stored in a Folder count down, but I need to make it so the time shows on the screen as well.
My friend somehow did this without using tostring() for the NumberValue, but he used multiple scripts, which I want to avoid, since it's very unorganized.
Below I'll post my script and then my friends' scripts. These are normal Scripts placed in Workspace.
My script:
01 | local airport = game.Workspace.Airport |
02 | local booths = game.Workspace.Airport.Booths |
03 | local screen = game.Workspace.Airport.AirportTV |
04 | local screen2 = game.Workspace.Airport.AirportTV2 |
05 | local times = game.Workspace.Airport.DepartureTimes |
06 |
07 | -- air canada departure times |
08 | while times.AirCanada.Value > -1 do |
09 | wait (1) |
10 | times.AirCanada.Value = times.AirCanada.Value - 1 |
11 | if times.AirCanada.Value == 0 then |
12 | times.AirCanada.Value = 120 |
13 | end |
14 | end |
15 |
Friend's scripts
01 | --script 1 |
02 | while wait(1) do |
03 | script.Parent.Value = script.Parent.Value - 1 |
04 | if script.Parent.Value == -1 then |
05 | script.Parent.Value = 120 |
06 | end |
07 | end |
08 | --script 2 |
09 |
10 | while wait() do |
11 | script.Parent.Text = script.Parent.Time.Value |
12 | end |
My friend has a habit of making scripts "while wait() do" -_-
0
0
2 answers
From what I can tell your script should be ok but there are two thing that should be looked at, 1st.
1 | game.Workspace.Airport.DepartureTimes.AirCanada.Changed:connect(function(ins) -- there is variable for what has changed so I would use it |
2 | local val = game.Workspace.Airport.DepartureTimes.AirCanada |
3 | local label = game.Workspace.Airport.AirportTV.TVScreen.SurfaceGui.AirCanada.Arrival |
4 | label.Text = tostring(val.Value) |
5 | end) |
2nd
1 | --this loop will not show the changes as the event has not been added |
2 | while times.AirCanada.Value > -1 do |
3 | wait (1) |
4 | times.AirCanada.Value = times.AirCanada.Value - 1 |
5 | if times.AirCanada.Value == 0 then |
6 | times.AirCanada.Value = 120 |
7 | end |
8 | end |
I would use a thread for this task as you said you wanted to a script that will do more than one task Constructing_a_thread
01 | local airport = game.Workspace.Airport |
02 | local booths = game.Workspace.Airport.Booths |
03 | local screen = game.Workspace.Airport.AirportTV |
04 | local screen2 = game.Workspace.Airport.AirportTV2 |
05 | local times = game.Workspace.Airport.DepartureTimes |
06 |
07 | -- this will add the thread then allow the rest of your code to run |
08 | spawn(function() while times.AirCanada.Value > -1 do |
09 | wait (1) |
10 | times.AirCanada.Value = times.AirCanada.Value - 1 |
11 | if times.AirCanada.Value == 0 then |
12 | times.AirCanada.Value = 120 |
13 | end |
14 | end |
15 | end) |
Hope this helps
This is how your script looks:
1 | local variables = values |
2 |
3 | while wait(1) do |
4 | -- stuff |
5 | end |
6 |
7 | AirCanada.Changed:connect(function() end) |
The while-loop will go on forever. The code after the loop will never run, so the AirCanana.Changed:connect() neither. A simple fix would be connecting the event before starting the while-loop.
A combined version would be this:
01 | local airport = game.Workspace.Airport |
02 | local booths = airport.Booths |
03 | local screen = airport.AirportTV |
04 | local screen2 = screen.AirportTV2 |
05 | local times = airport.DepartureTimes |
06 | local tvscreen = screen.TVScreen |
07 | local gui = tvscreen.SurfaceGui |
08 |
09 | -- air canada departure times |
10 | while times.AirCanada.Value > -1 do |
11 | wait (1) |
12 | local value = times.AirCanada.Value - 1 |
13 | if value == 0 then |
14 | value = 120 |
15 | end |
16 | times.AirCanada.Value = value |
17 | gui.AirCanana.Arrival.Text = tostring(value) |
18 | end |
Although it is advised to use WaitForChild.