Scripting Helpers is winding down operations and is now read-only. More info→

Add Texture to nearby parts?

Asked by

8 years ago

I've recently been trying to add texture to all sides of nearby parts, I also have been trying to add texture to parts that may be inside nearby models. For some reason the textures are only added directly to the model itself when ran. Is there any way I can get my script to work?

001me = game.Players.LocalPlayer.Character
002bin = script.Parent
003 
004function onButton1Down(mouse)
005if not enabled then
006                return
007        end
008 
009 
010   local player = game.Players.LocalPlayer
011        if player == nil then return end
012       enabled = false
013 
014 
015 
016for u, c in pairs(workspace:GetChildren()) do
017      h = workspace:GetChildren()
018      t = c:findFirstChild("Torso")
019if h ~= nil and t ~= nil then
020 
021for i = 1, #h do
022    if h[i]:IsA("Model") then
023        X = h[i]:GetChildren()
024                   for i = 1, #X do
025        if X[i]:IsA("Model") then
026        Z = X[i]:GetChildren()
027 
028        for i = 1, #X do
029 
030        if X[i]:IsA("Part") or X[i]:IsA("UnionOperation") then
031        if (X[i].Position-t.Position).magnitude <= 60 then
032        if (X[i].Position-t.Position).magnitude >= 60 then return end
033        if X[i]:IsA("Part") or X[i]:IsA("UnionOperation") then
034            print("bruh")
035        for i = 1, #X do
036                A = Instance.new("Texture")
037                A.Texture = "http://www.roblox.com/asset/?id=108208815"
038                A.StudsPerTileV = 2
039                A.StudsPerTileU = 2
040                A.Face = "Top"
041                A.Transparency = 0.2
042                A.Parent = X[i]
043                B = Instance.new("Texture")
044                B.Texture = "http://www.roblox.com/asset/?id=108208815"
045                B.StudsPerTileV = 2
046                B.StudsPerTileU = 2
047                B.Face = "Bottom"
048                B.Transparency = 0.2
049                B.Parent = X[i]
050                C = Instance.new("Texture")
051                C.Texture = "http://www.roblox.com/asset/?id=108208815"
052                C.StudsPerTileV = 2
053                C.StudsPerTileU = 2
054                C.Face = "Front"
055                C.Transparency = 0.2
056                C.Parent = X[i]
057                D = Instance.new("Texture")
058                D.Texture = "http://www.roblox.com/asset/?id=108208815"
059                D.StudsPerTileV = 2
060                D.StudsPerTileU = 2
061                D.Face = "Back"
062                D.Transparency = 0.2
063                D.Parent = X[i]
064                E = Instance.new("Texture")
065                E.Texture = "http://www.roblox.com/asset/?id=108208815"
066                E.StudsPerTileV = 2
067                E.StudsPerTileU = 2
068                E.Face = "Left"
069                E.Transparency = 0.2
070                E.Parent = X[i]
071                F = Instance.new("Texture")
072                F.Texture = "http://www.roblox.com/asset/?id=108208815"
073                F.StudsPerTileV = 2
074                F.StudsPerTileU = 2
075                F.Face = "Right"
076                F.Transparency = 0.2
077                F.Parent = X[i]
078                wait(.15)
079                end
080        for i = 1, #Z do 
081        if Z[i]:IsA("BasePart") or Z[i]:IsA("UnionOperation") then
082            print("test")
083        if (Z[i].Position-t.Position).magnitude <= 60 then
084        if (Z[i].Position-t.Position).magnitude >= 60 then return end
085            if Z[i]:IsA("BasePart") or Z[i]:IsA("UnionOperation") then
086            for i = 1, #Z do
087                G = Instance.new("Texture")
088                G.Texture = "http://www.roblox.com/asset/?id=108208815"
089                G.StudsPerTileV = 2
090                G.StudsPerTileU = 2
091                G.Face = "Top"
092                G.Transparency = 0.2
093                G.Parent = Z[i]
094                H = Instance.new("Texture")
095                H.Texture = "http://www.roblox.com/asset/?id=108208815"
096                H.StudsPerTileV = 2
097                H.StudsPerTileU = 2
098                H.Face = "Bottom"
099                H.Transparency = 0.2
100                H.Parent = Z[i]
101                L = Instance.new("Texture")
102                L.Texture = "http://www.roblox.com/asset/?id=108208815"
103                L.StudsPerTileV = 2
104                L.StudsPerTileU = 2
105                L.Face = "Front"
106                L.Transparency = 0.2
107                L.Parent = Z[i]
108                M = Instance.new("Texture")
109                M.Texture = "http://www.roblox.com/asset/?id=108208815"
110                M.StudsPerTileV = 2
111                M.StudsPerTileU = 2
112                M.Face = "Back"
113                M.Transparency = 0.2
114                M.Parent = Z[i]
115                N = Instance.new("Texture")
116                N.Texture = "http://www.roblox.com/asset/?id=108208815"
117                N.StudsPerTileV = 2
118                N.StudsPerTileU = 2
119                N.Face = "Left"
120                N.Transparency = 0.2
121                N.Parent = Z[i]
122                O = Instance.new("Texture")
123                O.Texture = "http://www.roblox.com/asset/?id=108208815"
124                O.StudsPerTileV = 2
125                O.StudsPerTileU = 2
126                O.Face = "Right"
127                O.Transparency = 0.2
128                O.Parent = Z[i]
129                wait(.15)
130                end
131                print("yo")
132                if Z[i]:IsA("Model") then
133        K = Z[i]:GetChildren()
134            for i = 1, #K do 
135        if K[i]:IsA("BasePart") or K[i]:IsA("UnionOperation") then
136        if (K[i].Position-t.Position).magnitude <= 60 then
137        if (K[i].Position-t.Position).magnitude >= 60 then return end
138            if K[i]:IsA("BasePart") or K[i]:IsA("UnionOperation") then
139            for i = 1, #K do
140            AA = Instance.new("Texture")
141                AA.Texture = "http://www.roblox.com/asset/?id=108208815"
142                AA.StudsPerTileV = 2
143                AA.StudsPerTileU = 2
144                AA.Face = "Top"
145                AA.Transparency = 0.2
146                AA.Parent = K[i]
147                BB = Instance.new("Texture")
148                BB.Texture = "http://www.roblox.com/asset/?id=108208815"
149                BB.StudsPerTileV = 2
150                BB.StudsPerTileU = 2
151                BB.Face = "Bottom"
152                BB.Transparency = 0.2
153                BB.Parent = K[i]
154                CC = Instance.new("Texture")
155                CC.Texture = "http://www.roblox.com/asset/?id=108208815"
156                CC.StudsPerTileV = 2
157                CC.StudsPerTileU = 2
158                CC.Face = "Front"
159                CC.Transparency = 0.2
160                CC.Parent = K[i]
161                DD = Instance.new("Texture")
162                DD.Texture = "http://www.roblox.com/asset/?id=108208815"
163                DD.StudsPerTileV = 2
164                DD.StudsPerTileU = 2
165                DD.Face = "Back"
166                DD.Transparency = 0.2
167                DD.Parent = K[i]
168                EE = Instance.new("Texture")
169                EE.Texture = "http://www.roblox.com/asset/?id=108208815"
170                EE.StudsPerTileV = 2
171                EE.StudsPerTileU = 2
172                EE.Face = "Left"
173                EE.Transparency = 0.2
174                EE.Parent = K[i]
175                FF = Instance.new("Texture")
176                FF.Texture = "http://www.roblox.com/asset/?id=108208815"
177                FF.StudsPerTileV = 2
178                FF.StudsPerTileU = 2
179                FF.Face = "Right"
180                FF.Transparency = 0.2
181                FF.Parent = K[i]
182                print("hi")
183                wait(.15)
184                end
185            for i = 1, #X do
186        if X[i]:IsA("Part") or X[i]:IsA("UnionOperation") then
187             if (X[i].Position-t.Position).magnitude <= 60 then
188                print("not I")
189                if (X[i].Position-t.Position).magnitude <= 60 then return end
190        if X[i]:IsA("Part") or X[i]:IsA("UnionOperation") then
191        for i = 1, #X do
192                A = Instance.new("Texture")
193                A.Texture = "http://www.roblox.com/asset/?id=108208815"
194                A.StudsPerTileV = 2
195                A.StudsPerTileU = 2
196                A.Face = "Top"
197                A.Transparency = 0.2
198                A.Parent = X[i]
199                B = Instance.new("Texture")
200                B.Texture = "http://www.roblox.com/asset/?id=108208815"
201                B.StudsPerTileV = 2
202                B.StudsPerTileU = 2
203                B.Face = "Bottom"
204                B.Transparency = 0.2
205                B.Parent = X[i]
206                C = Instance.new("Texture")
207                C.Texture = "http://www.roblox.com/asset/?id=108208815"
208                C.StudsPerTileV = 2
209                C.StudsPerTileU = 2
210                C.Face = "Front"
211                C.Transparency = 0.2
212                C.Parent = X[i]
213                D = Instance.new("Texture")
214                D.Texture = "http://www.roblox.com/asset/?id=108208815"
215                D.StudsPerTileV = 2
216                D.StudsPerTileU = 2
217                D.Face = "Back"
218                D.Transparency = 0.2
219                D.Parent = X[i]
220                E = Instance.new("Texture")
221                E.Texture = "http://www.roblox.com/asset/?id=108208815"
222                E.StudsPerTileV = 2
223                E.StudsPerTileU = 2
224                E.Face = "Left"
225                E.Transparency = 0.2
226                E.Parent = X[i]
227                F = Instance.new("Texture")
228                F.Texture = "http://www.roblox.com/asset/?id=108208815"
229                F.StudsPerTileV = 2
230                F.StudsPerTileU = 2
231                F.Face = "Right"
232                F.Transparency = 0.2
233                F.Parent = X[i]
234                wait(.15)
235        end
236        end
237        end
238    end
239    end
240    end
241        end
242        end
243        end
244    end
245end
246end
247        end
248        end
249        end
250        end
251        end
252        end
253        end
254        end
255    end
256    end
257end
258end
259 enabled = true
260 
261        end
262 
263enabled = true
264function onS(mouse) 
265mouse.Button1Down:connect(function() onButton1Down(mouse) end) 
266end
267bin.Selected:connect(onS)
 View all 267 lines...

1 answer

Answered by

BlueTaslem 18071

8 years ago

Edited 8 years ago

Tab your code correctly

The spaces to the left of code are not random.

A block of code grouped under an if/function/for, etc. all share the same left margin. You increase the indent once per group.

You do this so that you can see, e.g., what happens in this if?

What code is part of this function? What isn't?

Right now, this is the way your code is grouped.

Notice how it nearly goes off the page, it's so deeply grouped?

That's a problem.

What you want to do

You currently have several nested for loops, all modifying X in a non-local way. This is not only messy, it's very, very wrong.

Just the children are not enough, so you do children and children's children and children's children's children. In general, these are called descendants, and you would be better served by just getting a list of all of the descendants.

You can define this recursively quite easily:

1function descendants(model, r)
2    r= r or {}
3    for _, child in pairs(model:GetChildren()) do
4        table.insert(r, child)
5        descendants(child, r)
6    end
7    return r
8end

Thus, you would use, e.g.,

1X = descendants(m)
2 
3-- instead of
4X = m:GetChildren()

Locals and fors

You should use local variables always.

Whenever you first refer to a variable in a function, you should have a local in front. This prevents a lot of headaches, and it makes Script Analysis be able to better help you. It also reminds you just how much garbage you're introducing into your script (since definitions are more obvious).

Thus you should use

1    local x = descendants(m)
2    for i = 1, #x do
3        blah( x[i] )
4    end
5 
6-- NOT
7    x = descendants(m)

Notice how you use i over and over, but the only thing you do with it is [i]? Lua provides iterators to make this much nicer.

1for _, obj in pairs( descendants(mod) ) do
2    dostuffwith( obj )
3end
4 
5-- INSTEAD OF
6x = descendants(mod)
7for i = 1, #x do
8    dostuffwith( x[i] )
9end

Use functions

Good code reads like well written prose. - Grady Booch

You have a really long block of code that is just to put textures onto a X[i]. Instead of having that really long block of code in the middle of your already complicated logic, put it into a function:

01function putTextures(part)
02    local A = Instance.new("Texture")
03    A.Texture = "http://www.roblox.com/asset/?id=108208815"
04    A.StudsPerTileV = 2
05    A.StudsPerTileU = 2
06    A.Face = "Top"
07    A.Transparency = 0.2
08    A.Parent = part
09    local B = Instance.new("Texture")
10    B.Texture = "http://www.roblox.com/asset/?id=108208815"
11    B.StudsPerTileV = 2
12    B.StudsPerTileU = 2
13    B.Face = "Bottom"
14    B.Transparency = 0.2
15    B.Parent = X[i]
16    local C = Instance.new("Texture")
17    C.Texture = "http://www.roblox.com/asset/?id=108208815"
18    C.StudsPerTileV = 2
19    C.StudsPerTileU = 2
20    C.Face = "Front"
21    C.Transparency = 0.2
22    C.Parent = part
23    local D = Instance.new("Texture")
24    D.Texture = "http://www.roblox.com/asset/?id=108208815"
25    D.StudsPerTileV = 2
26    D.StudsPerTileU = 2
27    D.Face = "Back"
28    D.Transparency = 0.2
29    D.Parent = part
30    local E = Instance.new("Texture")
31    E.Texture = "http://www.roblox.com/asset/?id=108208815"
32    E.StudsPerTileV = 2
33    E.StudsPerTileU = 2
34    E.Face = "Left"
35    E.Transparency = 0.2
36    E.Parent = part
37    local F = Instance.new("Texture")
38    F.Texture = "http://www.roblox.com/asset/?id=108208815"
39    F.StudsPerTileV = 2
40    F.StudsPerTileU = 2
41    F.Face = "Right"
42    F.Transparency = 0.2
43    F.Parent = part
44end
45 
46-- OR BETTER YET!
47-- just keep them as objects inside the script!
48 
49function putTextures(part)
50    for _, texture in pairs(script.Textures:GetChildren()) do
51        texture:Clone().Parent = part
52    end
53end
 View all 53 lines...

Now you can just use putTextures(obj) and pull the complicated work of putting textures out of the rest of your complicated code.

You can shorten it by eliminating the .Parent lines; the second parameter to Instance.new is the parent to use:

`1`	`local` `A` `=` `Instance.new("Texture", part)`

Your answer

It's time for your to go back, think about why it's been so difficult to move forward, and resolve to try again, but this time, keep your stuff clean.

If you're having trouble keeping things manageable, it means you've got to learn about solving the problems you're having.

This answer has suggestions for bringing your code to a much, much better state -- but if I do it for you, I'll spend an hour doing it and you won't learn how two apply these tips yourself.