Can't get this script to insert fire and smoke into these bricks?

Asked by

8 years ago

Hello. Just to get this off first, I don't really have any experience scripting in .lua. So, there's probably a lot wrong with this script. What I'm trying to do is get it so when the on button is touched, it inserts smoke and fire into the bricks listed. Right now it doesn't do that.

Model layout: http://prntscr.com/bc9zbc

Code:

01local b = script.Parent.Parent.FireB
02local c = script.Parent.Parent.FireC
03local d = script.Parent.Parent.FireD
04local e = script.Parent.Parent.FireE
05local f = script.Parent.Parent.FireF
06local g = script.Parent.Parent.FireG
07local h = script.Parent.Parent.FireH
08local fir = Instance.new("Fire",b,c,d,e,f,g)
09local smo = Instance.new("Smoke",b,c,d,e,f,g)
10 
11function onClicked()
12    print "Fire on"
13    fir = Instance.new("Fire",b,c,d,e,f,g)
14    smo = Instance.new("Smoke",b,c,d,e,f,g)
15 
16 
17 
18 
19    script.Parent.Parent.b.Fire.Size = 25
20    script.Parent.Parent.b.Smoke.Size = 20
21    script.Parent.Parent.b.Smoke.Color = "Black"
22    script.Parent.Parent.b.Smoke.RiseVelocity = 3
23 
24    script.Parent.Parent.c.Fire.Size = 25
25    script.Parent.Parent.c.Smoke.Color = "Black"
26    script.Parent.Parent.c.Smoke.Size = 20
27    script.Parent.Parent.c.Smoke.RiseVelocity = 3
28 
29    script.Parent.Parent.d.Fire.Size = 25
30    script.Parent.Parent.d.Smoke.Color = "Black"
31    script.Parent.Parent.d.Smoke.Size = 20
32    script.Parent.Parent.d.Smoke.RiseVelocity = 3
33 
34    script.Parent.Parent.e.Fire.Size = 25
35    script.Parent.Parent.e.Smoke.Color = "Black"
36    script.Parent.Parent.e.Smoke.Size = 20
37    script.Parent.Parent.e.Smoke.RiseVelocity = 3
38 
39    script.Parent.Parent.f.Fire.Size = 25
40    script.Parent.Parent.f.Smoke.Color = "Black"
41    script.Parent.Parent.f.Smoke.Size = 20
42    script.Parent.Parent.f.Smoke.RiseVelocity = 3
43 
44    script.Parent.Parent.g.Fire.Size = 25
45    script.Parent.Parent.g.Smoke.Color = "Black"
46    script.Parent.Parent.g.Smoke.Size = 20
47    script.Parent.Parent.g.Smoke.RiseVelocity = 3
48 
49    script.Parent.Parent.h.Fire.Size = 25
50    script.Parent.Parent.h.Smoke.Color = "Black"
51    script.Parent.Parent.h.Smoke.Size = 20
52    script.Parent.Parent.h.Smoke.RiseVelocity = 3
53end
54 
55script.Parent.Touched:connect(onClicked)
 View all 55 lines...

Solution

Since it looks like you're wanting to make multiple of the same parts, what you could do is put all the parts you defined into a table. Then you would be able to use a for loop to go through all elements of the table and create the new items.

You would need to use Color3.new(r/255, g/255, b/255) since all arguments of Color3.new() are floats they have to be between 0 and 1. Alternatively, you can use the new function Color3.fromRGB and use whole numbers from there.

Final Script

01local PartsToSetAblaze = {
02    script.Parent.Parent.FireB,
03    script.Parent.Parent.FireC,
04    script.Parent.Parent.FireD,
05    script.Parent.Parent.FireE,
06    script.Parent.Parent.FireF,
07    script.Parent.Parent.FireG,
08    script.Parent.Parent.FireH,
09    --You can add more parts here.
10}
11 
12function onClicked()
13    print "Fire on"
14    for Index, Value in pairs(PartsToSetAblaze) do --Index and Value are just variables. You can name these however you want. Index is the number the value is in the table. The value is the actual object or value in the table.
15        if Value ~= nil then --We just want to make sure that the part still exists, otherwise the script may error.
16            local fir = Instance.new("Fire",Value) --Create new fire object and put it in the brick.
17            fir.Size = 25 --We can use the variable and change the size immediately.
18            local smo = Instance.new("Smoke",Value)
19            smo.Size = 20
20            smo.Color = Color3.new(255/255, 255/255, 255/255) --You could do 1,1,1 But I jsut wanted to emphasize that Color3.new arguments are floats and shoud be between 0 and 1.
21            smo.RiseVelocity = 3
22        end
23    end
24end
25 
26script.Parent.Touched:connect(onClicked)
 View all 26 lines...

Hopefully this answered your question. If it did, do not forget to hit the accept answer button. If you have any questions, feel free to comment below and I will get back to you.

Can't get this script to insert fire and smoke into these bricks?

1 answer

Problem

Solution

Final Script

Hopefully this answered your question. If it did, do not forget to hit the accept answer button. If you have any questions, feel free to comment below and I will get back to you.

Answer this question