Why do these custom character animations lag? --Update--

Asked by

9 years ago

I've been experimenting with my custom characters in my spare time for some weeks now, attempting to pinpoint the source of a heinous spike in lag. I've finally found that whenever the animations in my custom character are active, my framerate dips drastically. For example, when I begin walking and stop, causing the idle animation to play, my FPS will dip about 5 - 6 frames and Remain at that level. I'm thinking that perhaps the animations are being fired In rapid succession however I am unsure. Can anyone provide some insight and help me debug this? Thanks. The script that animates the model is below.

--UPDATE-- I've removed the animations that don't seem relevant to the problem, and added a debounce. The debounce seemed to correct the issue of the idle animation firing too many times, however if the player taps the w quickly enough, the frames will begin to dip again.

001    -- Ibethia is on the planet Tirren!
002 
003    local player = game:GetService('Players').LocalPlayer
004    Debounce = true
005    local already_ran = false
006    local grounded = false
007    --local idleAnimation = Instance.new("Animation")
008   -- idleAnimation.AnimationId = "rbxassetid://356344446"
009    --local Left = Instance.new("Animation")
010    --Left.AnimationId = "rbxassetid://356869859"
011    --local Right = Instance.new("Animation")
012    --Right.AnimationId = "rbxassetid://326922088"
013    --local Forward = Instance.new("Animation")
014    --Forward.AnimationId = "rbxassetid://312976450"
015    --local Backward = Instance.new("Animation")
016  --  Backward.AnimationId = "rbxassetid://312976450"
017    local Jump = Instance.new("Animation")
018    Jump.AnimationId = "rbxassetid://408621791"
019    local Walk = Instance.new("Animation")
020    Walk.AnimationId = "rbxassetid://408620308"
021    local BackWalk = Instance.new("Animation")
022    BackWalk.AnimationId = "rbxassetid://408620598"
023    local RelaxedIdle = Instance.new("Animation")
024    RelaxedIdle.AnimationId = "rbxassetid://408621630" 
025    local Blink = Instance.new("Animation")
026    Blink.AnimationId = "rbxassetid://408621866"
027    local Sprint = Instance.new("Animation")
028    Sprint.AnimationId = "rbxassetid://409050900"
029 
030--repeat wait() until player.Character
031 
032 
033 
034    function playAnimation(parent)
035        if Debounce == true then
036        Debounce = false
037        local AnimTrack = player.Character.Humanoid:LoadAnimation(parent)
038        AnimTrack:Stop()
039        wait(.01)
040        AnimTrack:Play()
041        wait(0.1)
042        Debounce = true
043        --AnimTrack:AdjustSpeed(1.5)
044        end
045        end
046 
047 
048 
049        function onGround(speed)
050        if grounded == false then
051            grounded = true
052        end
053        if speed > 1  and script.Asset.Value == ("Forward")then
054            if already_ran == false then
055                already_ran = true
056                wait(0.1)
057                playAnimation(Walk)
058 
059            end
060 
061            --elseif speed > 1  and script.Asset.Value == ("Backward")then
062            --if already_ran == false then
063                --already_ran = true
064                --wait(0.1)
065                --playAnimation(BackWalk)
066 
067        --  end
068 
069            --elseif speed > 1  and script.Asset.Value == ("Sprint")then
070            --if already_ran == false then
071            --  already_ran = true
072                --player.Character.Humanoid.WalkSpeed = 16
073            ----    wait(0.1)
074            --  playAnimation(Sprint)
075 
076            --end
077 
078        elseif speed < 1  then
079 
080        script.Asset.Value = ("Chillin")
081            print("Chillin")
082            already_ran = false
083            --wait(0.1)
084            playAnimation(RelaxedIdle)
085            wait(0.5)
086 
087 
088 
089 
090                end
091            end
092 
093 
094 
095function onKeyPress(inputObject, gameProcessedEvent)
096    local D = script.Debounce
097    if inputObject.KeyCode == Enum.KeyCode.A then
098        print("Left!!")
099        script.Asset.Value = ("Left")
100        elseif inputObject.KeyCode == Enum.KeyCode.D then
101        script.Asset.Value = ("Right")
102        elseif  inputObject.KeyCode == Enum.KeyCode.W then
103        script.Asset.Value = ("Forward")
104        elseif  inputObject.KeyCode == Enum.KeyCode.S then
105        script.Asset.Value = ("Backward")
106        elseif  inputObject.KeyCode == Enum.KeyCode.E then
107        script.State.Value = ("Emotional")
108        elseif inputObject.KeyCode == Enum.KeyCode.One and script.State.Value == ("Emotional")  then
109        playAnimation(Sprint)
110    elseif  inputObject.KeyCode == Enum.KeyCode.Space and D.Value == true then
111        print("CantJump")
112 
113    elseif inputObject.KeyCode == Enum.KeyCode.Space and D.Value == false then
114        D.Value = true
115        playAnimation(Jump)
116        wait(0.4)
117        D.Value = false
118    end
119end
120 
121 
122 
123 
124        game:GetService("UserInputService").InputBegan:connect(onKeyPress)
125 
126 
127 
128 
129 
130    player.Character.Humanoid.Running:connect(onGround)
131 
132    while true do
133        wait(math.random(2,5))
134        playAnimation(Blink)
135    end
 View all 135 lines...

Try using WaitForChild instead of the repeat wait() until player.Character TheHospitalDev 1134 — 9y

Why do these custom character animations lag? --Update--

1 answer

Answer this question