Why doesn't this script work?
So, I made a script that SHOULD remove weapons (in this case, the "ClassicSword") when touched a brick called "RedInteractive". For some reason - it doesn't work. Output is not giving any errors, but it doesn't print out what I've told it to print. Can anyone help? Big thanks!
Sincerely, Director1406.
P.S. Code is bellow
01 | p = game.Players.LocalPlayer |
02 |
03 |
04 | game.Workspace.RedInteractive.Touched:connect(function(hit) |
05 | if p.Backpack:FindFirstChild("ClassicSword") == true then |
06 | print("entering castle, removing weaps") |
07 | p.Backpack.ClassicSword:Destroy() |
08 | elseif p.Backpack:FindFirstChild("ClassicSword") == false then |
09 | print("leaving castle, giving back weaps") |
10 | local copy = game.Lighting.ClassicSword:Clone() |
11 | copy.Parent = p.Backpack |
12 | end |
13 | end) |
0
0
1 answer
If you're using a local script, DON'T. You don't need to use a local script for this process. The main reason your code is not working is because you use game.Players.LocalPlayer in order to get the player. The problem with this is that the script is probably in Workspacemeaning there is no local player. Meaning p = nil. The way you can fix this is by getting the player from the part that touched the brick. In this case, "hit". The code would look something like this,
01 | -- IN REGULAR SCRIPT |
02 | -- remove local player |
03 | game.Workspace.RedInteractive.Touched:connect(function(hit)-- I would recomend that you put this inside of the part and use script.Parent.Touched instead because that would work much better |
04 |
05 | if not hit.Parent:FindFirstChild("Humanoid") then return end-- if hit isn't part of a character returns end |
06 |
07 | local p = game.Players:GetPlayerFromCharacter(hit.Parent)--Gets the player from the character. |
08 |
09 | if p.Backpack:FindFirstChild("ClassicSword") == true then |
10 | print("entering castle, removing weaps") |
11 | p.Backpack.ClassicSword:Destroy() |
12 |
13 | elseif p.Backpack:FindFirstChild("ClassicSword") == false then |
14 | print("leaving castle, giving back weaps") |
15 | local copy = game.Lighting.ClassicSword:Clone()-- I would also recomend using ServerStorage instead of Lighting |
16 |
17 | copy.Parent = p.Backpack |
18 | end |
19 | end) |
That should work. Good luck!