Scripting Helpers is winding down operations and is now read-only. More info→

DataStore not working?[unsolved]

Asked by

ScriptsAhoy 202

9 years ago

01datastore = game:GetService("DataStoreService"):GetDataStore("FarmStatsCJ")
02 
03local function set(key,value)
04        datastore:SetAsync(key,value)
05end
06 
07local function get(key)
08    datastore:GetAsync(key)
09end
10 
11game.Players.PlayerRemoving:connect(function(player)
12    wait(1)
13    local l = player.leaderstats
14    set('leaderstatsFarmCJ1'..player.userId,l.Money)
15    set('leaderstatsFarmCJ2'..player.userId,l.level)
16    set('leaderstatsFarmCJ3'..player.userId,l.Harvests)
17    set('valsFarmCJ1'..player.userId,player.storage.ex.Value)
18    set('valsFarmCJ2'..player.userId,player.storage.exm.Value)
19    set('valsFarmCJ3'..player.userId,player.storage.waittime.Value)
20    set('valsFarmCJ4'..player.userId,player.storage.code.Value)
21    set('inventoryFarmCJ1'..player.userId,player.inventory.Carrots.Value)
22    set('inventoryFarmCJ2'..player.userId,player.inventory.Wheat.Value)
23    set('inventoryFarmCJ3'..player.userId,player.inventory.Corn.Value)
24end)
25 
26game.Players.PlayerAdded:connect(function(play)
27    wait(2)
28    local l = play.leaderstats
29    local i = play.inventory
30    local s = play.storage
31    if l.Money then
32        l.Money.Value = get('leaderstatsFarmCJ1'..play.userId)
33        l.level.Value = get('leaderstatsFarmCJ2'..play.userId)
34        l.Harvests.Value = get('leaderstatsFarmCJ3'..play.userId)
35        s.ex.Value = get('valsFarmCJ1'..play.userId)
36        s.exm.Value = get('valsFarmCJ2'..play.userId)
37        s.waittime.Value = get('valsFarmCJ3'..play.userId)
38        i.Carrots.Value = get('inventoryFarmCJ1'..play.userId)
39        i.Wheat.Value = get('inventoryFarmCJ2'..play.userId)
40        i.Corn.Value = get('inventoryFarmCJ3'..play.userId)
41    end
42end)
 View all 42 lines...

The datastore doesn't work, and since I've never used datastore before, I don't know what i did wrong.

1 answer

Answered by

einsteinK 145

9 years ago

What if the player doesn't have saved data yet? Doing get('idk') would return nil. Doing Money.Value = nil isn't very good.
Why don't you make the leaderstats/inv/... in that script too? Then you don't have to wait.
Why do you wait(1) on PlayerRemoving? The server might shutdown before you can save.
Instead of saving every stat in a separate key, why not put it all in one table?

01-- Saving
02local stats = {}
03stats.Money = Money.Value
04stats.Role = Role.Value
05set("Data_"..play.userId,stats)
06-- Loading
07local stats = get("Data_"..play.userId)
08if not stats then return end -- NO STATS, USE DEFAULT
09Money.Value = stats.Money
10Role.Value = stats.Role

thank you. the consept of what this is helped me ScriptsAhoy 202 — 9y

DataStore not working?[unsolved]

1 answer

Answer this question