Scripting Helpers is winding down operations and is now read-only. More info→

Am I scripting local functions and events correctly in this script?

Asked by

9 years ago

I started scripting around two months ago and decided to start branching out. For my first task, I decided to make a run button, and when the player runs, the game's brightness would increase, however, I need help, as it is not working and no errors are appearing in the output.

01l--Player--
02local Player = game.Players.LocalPlayer
03local character = Player.Character
04if not character or not character.Parent then
05    character = Player.CharacterAdded:wait()
06end
07 
08--Services/Other--
09local mouse = game.Players.LocalPlayer:GetMouse()
10 
11--Variables--
12local Head = character["Head"]
13local LeftArm = character["Left Arm"]
14local LeftLeg = character["Left Leg"]
15local RightArm = character["Right Arm"]
16local RightLeg = character["Right Leg"]
17local Torso = character.Torso
18 
19--Functions--
20function getTool()  
21    for _, kid in ipairs(script.Parent:GetChildren()) do
22        if kid.className == "Tool" then return kid end
23    end
24    return nil
25end
26 
27mouse.KeyDown:connect(function (key)
28    key = string.lower(key)
29    if string.byte(key) == 107 then
30        running = true
31        local keyConnection = mouse.KeyUp:connect(function (key)
32            if string.byte(key) == 108 then
33                running = false
34            end
35        end)
36        for i = 1,5 do
37            game.Workspace.CurrentCamera.FieldOfView = (70+(i*2))
38            wait()
39        end
40    game:GetService("Chat"):Chat(Head, "Clock Up...", Enum.ChatColor.Red)
41        game.Players.LocalPlayer.Character.Humanoid.WalkSpeed = 150
42        game.Players.LocalPlayer.Character.Humanoid.JumpPower = 65
43        LeftLeg.BottomSurface = "Glue"
44        RightLeg.BottomSurface = "Glue"
45        repeat wait(99999999999999999999999999999999999999999) until running == false
46        keyConnection:disconnect()
47game:GetService("Chat"):Chat(Head, "Clock Over...", Enum.ChatColor.Red)
48        game.Players.LocalPlayer.Character.Humanoid.WalkSpeed = 16
49        game.Players.LocalPlayer.Character.Humanoid.JumpPower = 50
50        LeftLeg.BottomSurface = "Smooth"
51        RightLeg.BottomSurface = "Smooth"
52        for i = 1,5 do
53            game.Workspace.CurrentCamera.FieldOfView = (80-(i*2))
54            wait()
55        end
56    end
57end)
58 
59--Local Functions--
60 
61function brightUp()
62    if running == true then
63        game.Lighting.Brightness = 2
64        if running == false then
65            game.Lighting.Brightness = 1
66        end
67    end
68end
69 
70game.Lighting.LightingChanged:connect(brightUp)
 View all 70 lines...

If more code is needed, just ask!

Just one question. Is anywhere in the script, are you defining 'running'? Nickoakz 231 — 9y

Mhm, I posted the full script just now. Strykebyte 45 — 9y

You should call the function, when he starts running xuefei123 214 — 9y

I will try that, thank you Strykebyte 45 — 9y

What exactly would that look like? Strykebyte 45 — 9y

2 answers

Answered by

Dynamese 35

9 years ago

Well if you make the script wait 99999999999999999999999999999999999999999 until it's allowed to check if running == false then you're gonna have to wait 99999999999999999999999999999999999999999 seconds before it prints anything too!

`1`	`repeat` `wait(99999999999999999999999999999999999999999)` `until` `running` `==` `false`

`2`	`--If you're just yielding until running == false you should drop that timer to something smaller...`

Also, you can have KeyUp events to turn running off instead of waiting for disconnect events, it's how I do my own sprinting systems.

Yea, the "until running == false" part of your repeat loop will NOT be checked until the massive wait is over, Just do repeat wait() until running == false, it will still stop the script until running has stopped alphawolvess 1784 — 9y

Oh wow! You guys are really helpful! Thanks! :D Strykebyte 45 — 9y

-1

Answered by

haloelite27 25

9 years ago

01local function brightUp()
02    if running == true then
03        game.Lighting.Brightness = 2
04        if running == false then
05            game.Lighting.Brightness = 1
06        end
07    end
08end
09 
10brightUp()

It didn't work, but thank you for attempting to help. Strykebyte 45 — 9y

Am I scripting local functions and events correctly in this script?

2 answers

Answer this question