Scripting Helpers is winding down operations and is now read-only. More info→

Sound Glitches On Death?

Asked by

yoshi8080 445

9 years ago

Making a little sound stage thing for a friend, however it's a bit glitchy after a player dies. No errors though. This is a local script placed in StarterGui

Problem: After player once or more, the sound stops and won't play.

01Sounds = script:WaitForChild'SongFolder'
02 
03Player = game.Players.LocalPlayer
04PlayerGui = Player.PlayerGui
05Leaderstats = Player:WaitForChild'leaderstats'
06Stage = Leaderstats:WaitForChild'Stage'
07 
08Song1 = Sounds:WaitForChild'Sound1'
09Song2 = Sounds:WaitForChild'Sound2'
10Song3 = Sounds:WaitForChild'Sound3'
11Song4 = Sounds:WaitForChild'Sound4'
12 
13 
14if Stage.Value == 1 and Song1.IsPlaying ~= true then
15Song1:Play()
16end
17 
18 
19Stage.Changed:connect(function(NewValue)
20if NewValue == 2 and Song2.IsPlaying ~= true then
21Song2:Play()
22Song1:Stop()
23 
24end
25end)
26 
27Stage.Changed:connect(function(NewValue)
28if NewValue == 3 and Song3.IsPlaying ~= true then
29Song3:Play() 
30Song2:Stop()
31 
32end
33end)
34 
35Stage.Changed:connect(function(NewValue)
36if NewValue == 4 and Song4.IsPlaying ~= true then
37Song4:Play() 
38Song3:Stop()
39 
40end
41end)
 View all 41 lines...

2 answers

Answered by

XAXA 1569

9 years ago

Problem

Every time the player spawns, if Stage.Value is > 1, the appropriate song will not play.

Suggestions

Given how you name your sounds, it would be best if these were stored in a table so you can iterate through it and index them neatly. As a plus, you can get rid of those ugly redundant if-statements.

Solution

01Sounds = script:WaitForChild'SongFolder'
02 
03local Songs = {
04Sounds:WaitForChild'Sound1',
05Sounds:WaitForChild'Sound2',
06Sounds:WaitForChild'Sound3',
07Sounds:WaitForChild'Sound4'
08}
09 
10Player = game.Players.LocalPlayer
11PlayerGui = Player.PlayerGui
12Leaderstats = Player:WaitForChild'leaderstats'
13Stage = Leaderstats:WaitForChild'Stage'
14 
15function PlaySound(id) -- Stops all the songs that are currently playing, then plays the sound.
16    for _, v in pairs(Songs) do
17        v:Stop()
18    end
19    Songs[id]:Play()
20end
21 
22PlaySound(Stage.Value) -- play the appropriate song every time the player spawns
23Stage.Changed:connect(function(NewValue) -- whenever the stage changes, play the appropriate song.
24    PlaySound(NewValue)
25end)
 View all 25 lines...

Answered by

Dominus113 0

9 years ago

01Sounds = script:WaitForChild'SongFolder'
02 
03Player = game.Players.LocalPlayer
04PlayerGui = Player.PlayerGui
05Leaderstats = Player:WaitForChild'leaderstats'
06Stage = Leaderstats:WaitForChild'Stage'
07 
08Song1 = Sounds:WaitForChild'Sound1'
09Song2 = Sounds:WaitForChild'Sound2'
10Song3 = Sounds:WaitForChild'Sound3'
11Song4 = Sounds:WaitForChild'Sound4'
12 
13if Stage.Value == 1 and Song1.IsPlaying ~= true then
14Song1:Play()
15end
16 Stage.Changed:connect(function(NewValue)
17if NewValue == 2 and Song2.IsPlaying ~= true then
18Song2:Play()
19Song1:Stop()
20 end
21end)
22Stage.Changed:connect(function(NewValue)
23if NewValue == 3 and Song3.IsPlaying ~= true then
24Song3:Play()
25Song2:Stop() 
26end
27end)
28 
29Stage.Changed:connect(function(NewValue)
30if NewValue == 4 and Song4.IsPlaying ~= true then
31Song4:Play()
32Song3:Stop()
33end
34end)
35if
36game.Players:FindFirstChilden():LoadCharacter() == true and song1 or song2 or song3 or song4.IsPlaying == true then
37for i,v = 1,4
38song[i,v]:stop()
39end
40end
 View all 40 lines...

Tell me if it works, didn't test it in studio.

I think line 37 is wrong, it's seems incomplete yoshi8080 445 — 9y

oops, for i,v = 1,4 do See if that works? I'm not good with i,v. Dominus113 0 — 9y

I see yoshi8080 445 — 9y

Sound Glitches On Death?

2 answers

Answer this question