Is there a way to shorten the length of this script, or make it more efficient?

Asked by

9 years ago

I'm trying to make my own inventory, so far so good. But to me, this script that updates the inventory seems very long, and inefficient. Is there any way I can improve it?

01local plr = game.Players.LocalPlayer
02local buttons = script.Parent.IFrame:GetChildren()
03local items = plr.Backpack:GetChildren()
04local iframe = script.Parent.IFrame
05 
06function updateinven()
07    for i = 1,#items do
08        if #items == 1 then
09            iframe.Button1.Visible = true
10            iframe.Button1.ItemName.Value = items[1].Name
11            iframe.Button1.Text = items[1].Name
12        elseif #items == 2 then
13            iframe.Button1.Visible = true
14            iframe.Button1.ItemName.Value = items[1].Name
15            iframe.Button1.Text = items[1].Name
16            iframe.Button2.Visible = true
17            iframe.Button2.ItemName.Value = items[2].Name
18            iframe.Button2.Text = items[2].Name
19        elseif #items == 3 then
20            iframe.Button1.Visible = true
21            iframe.Button1.ItemName.Value = items[1].Name
22            iframe.Button1.Text = items[1].Name
23            iframe.Button2.Visible = true
24            iframe.Button2.ItemName.Value = items[2].Name
25            iframe.Button2.Text = items[2].Name
26            iframe.Button3.Visible = true
27            iframe.Button3.ItemName.Value = items[3].Name
28            iframe.Button3.Text = items[3].Name
29        elseif #items == 4 then
30            iframe.Button1.Visible = true
31            iframe.Button1.ItemName.Value = items[1].Name
32            iframe.Button1.Text = items[1].Name
33            iframe.Button2.Visible = true
34            iframe.Button2.ItemName.Value = items[2].Name
35            iframe.Button2.Text = items[2].Name
36            iframe.Button3.Visible = true
37            iframe.Button3.ItemName.Value = items[3].Name
38            iframe.Button3.Text = items[3].Name
39            iframe.Button4.Visible = true
40            iframe.Button4.ItemName.Value = items[4].Name
41            iframe.Button4.Text = items[4].Name
42        end
43    end
44end
45 
46plr.Backpack.ChildAdded:connect(updateinven)
47plr.Character.ChildAdded:connect(updateinven)
 View all 47 lines...

`05`	`local` `buttons` `=` `{iframe.Button1, iframe.Button2, iframe.Button3, iframe.Button4}`

Is there a way to shorten the length of this script, or make it more efficient?

1 answer

Answer this question