Script Works when testing but not online when published?

Asked by
9 years ago
I have a bow script that works when i test play it in studio, but when i publish the game and play it online the GUI doesn't show up and the bow doesn't work. Why is that? Thanks for any help and suggestions!
001local TOOL = script.Parent
002 
003local DAMAGE = 30
004local RANGE = 50
005local REST_TIME = 0.5
006local CRIT_MULT = 2
007 
008local DEBOUNCE = true
009 
010local AMMO_TYPE = "ARROW"
011local AMMO_BOX = TOOL.Ammo
012local AMMO_GUI = TOOL.ScreenGui
013local AMMO_NUM_LABEL = AMMO_GUI.Frame.TotalAmmoLabel
014local AMMO_TYPE_LABEL = AMMO_GUI.Frame.AmmoTypeLabel
015local CURRENT_SHOT = nil
016 
017function getPC()
018    local char = TOOL.Parent
019    local player = game.Players:GetPlayerFromCharacter(char)
020 
021    return player, char
022end
023 
024function humanCheck(part)
025    local parent = part.Parent
026 
027    if parent == nil then
028        return false
029    end
030 
031    local humanoid = parent:findFirstChild("ANIMAL")
032 
033    if humanoid ~= nil then
034        return true
035    end
036 
037    return false
038end
039 
040function distanceCheck(part)
041    local player, char = getPC()
042    local head = char.Head
043 
044    local dist = (head.Position - part.Position).magnitude
045 
046    return (dist < RANGE)
047end
048 
049function ammoCheck(part)
050    local typeValue = part:findFirstChild("AmmoType")
051 
052    if typeValue ~= nil then
053        return (typeValue.Value == AMMO_TYPE)
054    end
055end
056 
057function hasAmmo()
058    local ammo = AMMO_BOX:GetChildren()
059    local ammoNum = #ammo
060 
061    return (ammoNum > 0)
062end
063 
064function canHit(part)
065    local bool = false
066 
067    bool = (bool or humanCheck(part))
068    bool = (bool and distanceCheck(part))
069    bool = (bool and hasAmmo())
070 
071    return bool
072end
073 
074function canPickup(part)
075    local bool = false
076 
077    bool = (bool or ammoCheck(part))
078 
079    return bool
080end
081 
082function attack(body_part, human)
083    body_part = body_part.Name
084 
085    local health = human.HEALTH
086 
087    local final_damage = DAMAGE + CURRENT_SHOT.Damage.Value
088 
089    if body_part == "Head" or body_part == "Torso" then
090        health.Value = health.Value - (final_damage * CRIT_MULT)
091    end
092 
093    if body_part == "Right Arm" or body_part == "Left Arm" then
094        health.Value = health.Value - (final_damage / CRIT_MULT)
095    end
096 
097    if body_part == "Right Leg" or body_part == "Left Leg" then
098        health.Value = health.Value - (final_damage)
099    end
100end
101 
102function updateAmmo()
103    local ammo = AMMO_BOX:GetChildren()
104    local ammo_num = #ammo
105 
106    CURRENT_SHOT = ammo[1]
107 
108    if CURRENT_SHOT ~= nil then
109        AMMO_NUM_LABEL.Text = "Ammo: "..ammo_num
110        AMMO_TYPE_LABEL.Text = "Current: "..CURRENT_SHOT.Name
111    else
112        AMMO_NUM_LABEL.Text = "No ammo!"
113        AMMO_TYPE_LABEL.Text = ""
114    end
115end
116 
117function slash()
118    local s = Instance.new("StringValue")
119    s.Name = "toolanim"
120    s.Value = "Slash"
121    s.Parent = TOOL
122end
123 
124function fire(v)
125 
126 
127    local vCharacter = TOOL.Parent
128 
129    local vPlayer = game.Players:playerFromCharacter(vCharacter)
130 
131 
132    local missile = TOOL.Bolt:Clone()
133 
134    -- find firing direction
135 
136    local v1 = -TOOL.Bolt.CFrame.lookVector.unit
137    local v2 = v.unit
138 
139 
140    local dot = (v1.x * v2.x) + (v1.y * v2.y) + (v1.z * v2.z)
141    local ang = math.acos(dot)
142 
143    -- test if in cone
144    if (ang < 3.14 / 8) then
145 
146    else
147        -- not in cone, find projection
148         --n = v1 x v2
149        --local n = Vector3.new(v1.y * v2.z - v1.z * v2.y, v1.z * v2.x - v1.x * v2.z, v1.z * v2.y - v1.y * v2.x)
150 
151        --return
152    end
153 
154 
155    --missile.CFrame = Tool.Bolt.CFrame + (Tool.Bolt.CFrame.lookVector * -8)
156    missile.CFrame = TOOL.Bolt.CFrame + (v * 8)
157 
158    missile.Transparency = 0
159 
160    missile.Velocity =  v * 150
161 
162    missile.Name = "CrossbowBolt"
163 
164    missile.Elasticity = 0
165 
166 
167    local force = Instance.new("BodyForce")
168 
169    force.force = Vector3.new(0,150,0)
170 
171    force.Parent = missile
172 
173    missile.BodyGyro.cframe = CFrame.new(Vector3.new(0,0,0), -TOOL.Bolt.CFrame.lookVector.unit)
174    missile.BodyGyro.maxTorque = Vector3.new(5e5,5e5,5e5)
175 
176 
177 
178    local new_script = script.Parent.CrossbowBoltScript:clone()
179 
180    new_script.Disabled = false
181 
182    new_script.Parent = missile
183 
184 
185 
186    local creator_tag = Instance.new("ObjectValue")
187 
188    creator_tag.Value = vPlayer
189 
190    creator_tag.Name = "creator"
191 
192    creator_tag.Parent = missile
193 
194 
195    missile.Parent = game.Workspace
196 
197 
198end
199 
200 
201TOOL.Enabled = true
202 
203function onActivated()
204 
205 
206    if not TOOL.Enabled then
207 
208        return
209 
210    end
211 
212    TOOL.Enabled = false
213    end
214 
215function onButton1Down(mouse)
216    if not DEBOUNCE then return end
217 
218    DEBOUNCE = false
219 
220    local character = TOOL.Parent;
221    local humanoid = character.Humanoid
222    local targ = mouse.Target
223    local targetPos = humanoid.TargetPoint
224    local lookAt = (targetPos - character.Head.Position).unit
225 
226 
227    if canHit(targ) then
228        local enemy = targ.Parent
229        local human = enemy.ANIMAL
230 
231        attack(targ, human)
232 
233        CURRENT_SHOT:remove()
234        fire(lookAt)
235 
236    wait(2)
237 
238    TOOL.Enabled = true
239 
240        updateAmmo()    
241    end
242 
243    if canPickup(targ) then
244        targ.Parent = AMMO_BOX
245 
246        updateAmmo()
247    else
248        wait(REST_TIME)
249    end
250 
251    DEBOUNCE = true
252end
253 
254function onEquipped(mouse)
255    local player, char = getPC()
256 
257    AMMO_GUI.Parent = player.PlayerGui
258    updateAmmo()
259 
260    AMMO_BOX.Parent = player.Backpack
261 
262    mouse.Button1Down:connect(function()
263        onButton1Down(mouse)
264    end)
265end
266 
267function onUnequipped()
268    local player, char = getPC()
269 
270    AMMO_GUI.Parent = TOOL
271 
272    AMMO_BOX.Parent = TOOL
273end
274 
275 
276script.Parent.Activated:connect(onActivated)
277TOOL.Equipped:connect(onEquipped)
278TOOL.Unequipped:connect(onUnequipped)
 View all 278 lines...
Read this: https://scriptinghelpers.org/blog/it-works-in-studio-but-not-online BlueTaslem 18071 — 9y
i bet taslem didnt even read all 278 lines koolkid8099 705 — 9y
haha ^ but thanks taslem, so far its looking like that was the problem, most of my scripts were scripts not localscripts, and that also fixed the testing mode in studio so it isn't slow anymore. Gwolflover 80 — 9y
Script Works when testing but not online when published?

1 answer

Answer this question
