Scripting Helpers is winding down operations and is now read-only. More info→

Trouble using Color3 Values?

Asked by

9 years ago

I was making a GUI script for my RPG, which basically makes it so that I have 3 NumberValues: ColourRValue ColourBValue ColourGValue

I wanted to make a script where if you change any of the values, it will change the GUI buttons' BackgroundColor3 value. The problem is, Color3 values don't work up to 255, so I had to divide it by 255. This is where my problem comes in. I divided it but the script doesn't work. Here is my code

01local player = script.Parent.Parent.Parent.Parent
02local character = player.Character or player.CharacterAdded:wait()
03local colourR = script.Parent.ColourRValue --player.leaderstat.ColourR
04local colourG = script.Parent.ColourGValue --player.leaderstat.ColourG
05local colourB = script.Parent.ColourBValue --player.leaderstat.ColourB
06local newColourR = colourR.Value / 255
07local newColourG = colourG.Value / 255
08local newColourB = colourB.Value / 255
09 
10local tut = script.Parent.TutButton
11local stats = script.Parent.StatsButton
12local skills = script.Parent.SkillsButton
13local inv = script.Parent.InvButton
14local settings = script.Parent.SettingsButton
15 
16colourR.Changed:connect(function()
17    local newColourR = colourR.Value / 255
18    local newColourG = colourG.Value / 255
19    local newColourB = colourB.Value / 255
20end)
21colourG.Changed:connect(function()
22    local newColourR = colourR.Value / 255
23    local newColourG = colourG.Value / 255
24    local newColourB = colourB.Value / 255
25end)
26colourB.Changed:connect(function()
27    local newColourR = colourR.Value / 255
28    local newColourG = colourG.Value / 255
29    local newColourB = colourB.Value / 255
30end)
31 
32newColourR.Changed:connect(function()   
33 
34        tut.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
35        stats.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
36        skills.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
37        inv.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
38        settings.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
39 
40        tut.TextLabel.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
41        stats.TextLabel.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
42        skills.TextLabel.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
43        inv.TextLabel.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
44        settings.TextLabel.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
45 
46end)
47 
48newColourG.Changed:connect(function()   
49 
50        tut.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
51        stats.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
52        skills.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
53        inv.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
54        settings.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
55 
56        tut.TextLabel.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
57        stats.TextLabel.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
58        skills.TextLabel.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
59        inv.TextLabel.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
60        settings.TextLabel.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
61 
62end)
63 
64newColourB.Changed:connect(function()   
65 
66        tut.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
67        stats.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
68        skills.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
69        inv.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
70        settings.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
71 
72        tut.TextLabel.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
73        stats.TextLabel.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
74        skills.TextLabel.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
75        inv.TextLabel.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
76        settings.TextLabel.BackgroundColor3 = Color3.new(newColourR, newColourG, newColourB)
77 
78end)
 View all 78 lines...

And my error: 11:51:31.696 - Players.Player1.PlayerGui.ScreenGui.Frame.Colour:32: attempt to index local 'newColourR' (a number value)

Also, the hierarchy: https://gyazo.com/f3de31f100dc10720bb25cc008259819

Thanks for your help!

1 answer

Answered by

User#6546 35

9 years ago

Consider refactoring your code; there's actually very little reason to be checking so many things that way.

01local player = script.Parent.Parent.Parent.Parent
02local character = player.Character or player.CharacterAdded:wait()
03local colourR = script.Parent.ColourRValue --player.leaderstat.ColourR
04local colourG = script.Parent.ColourGValue --player.leaderstat.ColourG
05local colourB = script.Parent.ColourBValue --player.leaderstat.ColourB
06 
07local tut = script.Parent.TutButton
08local stats = script.Parent.StatsButton
09local skills = script.Parent.SkillsButton
10local inv = script.Parent.InvButton
11local settings = script.Parent.SettingsButton
12 
13local updateGui = function()   
14    local colour = Color3.new(colourR.Value/255,colourG.Value/255,colourB.Value/255);
15        tut.BackgroundColor3 = colour;
16        stats.BackgroundColor3 = colour;
17        skills.BackgroundColor3 = colour;
18        inv.BackgroundColor3 = colour;
19        settings.BackgroundColor3 = colour;
20 
21        tut.TextLabel.BackgroundColor3 = colour;
22        stats.TextLabel.BackgroundColor3 = colour;
23        skills.TextLabel.BackgroundColor3 = colour;
24        inv.TextLabel.BackgroundColor3 = colour;
25        settings.TextLabel.BackgroundColor3 = colour;
26end;
27 
28colourR.Changed:connect(updateGui);
29colourG.Changed:connect(updateGui);
30colourB.Changed:connect(updateGui);
 View all 30 lines...

What changed?
Instead of listening for when the Values change, and then trying to listen for when those values change your new values, this new code simply listens for the value change and updates the Gui in a single function, connected to all of the Changed events.
As a side note, only Instance types have the Changed event.

Also, `local player = script.Parent.Parent.Parent.Parent` should be `local player = game.Players.LocalPlayer` instead. XAXA 1569 — 9y

Should be, but doesn't have to be; it works just fine as it is (Assuming the hierarchy is as expected) . If the person isn't using FilteringEnabled then they've got the all clear to put Script objects inside of the PlayerGui to be run on the server instead. User#6546 35 — 9y

Also, what the Asker was trying to do was check if the variable number has changed rather than the ValueObject. I see you've corrected it in this script, but it would be something to point out to the Asker. M39a9am3R 3210 — 9y

"As a side note, only Instance types have the Changed event." User#6546 35 — 9y

View all comments (2 more)

Since this is manipulating the player's gui directly, there is no point in moving this to a server script. XAXA 1569 — 9y

Not that it matters to me. If it's not broken, it doesn't need fixing. User#6546 35 — 9y

Trouble using Color3 Values?

1 answer

Answer this question