Scripting Helpers is winding down operations and is now read-only. More info→

How would you cycle through weapons?

Asked by

9 years ago

So, I've got Backpack turned off, and I'm force equipping the tools. It successfully cycles through to the next/previous gun, but it just stops working afterwards. Should I use "while true do" to keep cycling through the weapons?

Here's the snippet of code I've got at the moment:

01local gun1 = game.Lighting.Guns.Runner.SniperRifle
02local gun2 = game.Lighting.Guns.Runner.London
03gun1.Parent = char --Force equip
04if gun1.Parent == char then
05    print("Gun1 is parented")
06    mouse.WheelForward:connect(function()
07        print("Gun2 is parented")
08        gun1.Parent = game.Lighting.Guns.Runner
09        wait(.5)
10        gun2.Parent = char
11    end)
12    mouse.WheelBackward:connect(function()
13        print("Gun2 is parented")
14        gun1.Parent = game.Lighting.Guns.Runner
15        wait(.5)
16        gun2.Parent = char
17    end)
18end
19if gun2.Parent == char then
20    print("Gun1 is parented")
21    mouse.WheelForward:connect(function()
22        gun2.Parent = game.Lighting.Guns.Runner
23        wait(.5)
24        gun1.Parent = char
25    end)
26end
 View all 26 lines...

Output shows "SniperRifle is not a valid member of Model" Sxerks3 65 — 9y

Well first off that is your problem... the sniper rifle isn't part of the model. Use :WaitForChild() or make sure that it is 100% coded to the right hierarchy NinjoOnline 1146 — 9y

First thing I would do, to prevent the gun scripts from freaking out, is use a function in the Humanoid called :EquipTool() and :UnequipTools(). All you need to do is call the character's humanoid, add :EquipTool(TOOL_GOES_HERE) and then when you want to unequip, then just call it again and say :UnequipTools() lightpower26 399 — 9y

1 answer

Answered by

lightpower26 399

9 years ago

Ok, so I managed to do a whole lot of editing to your snippet of code, and I found many things that would go wrong.

Firstly, when you parent a gun, it won't be in Lighting, so if another player tried to switch, it would brake. Instead, I cloned the gun into the player's backpack.

Secondly, parenting and unparenting tools from the character can break some guns made from popular gun makers like manofthelol and TurboFusion. Use the :EquipTool() and :UnequipTools() functions in the Humanoid.

Third, you don't need a loop, you need the if statement inside the WheelBackward and WheelForward events.

Here's what I did to your snippet. I will add comments to describe why I did what I did:

01game.StarterGui:SetCoreGuiEnabled(Enum.CoreGuiType.Backpack, false) --Turn the backpack off, I'm assuming you did this
02local mouse = game.Players.LocalPlayer:GetMouse() --Get the player's mouse, I'm assuming you did this
03local char = game.Players.LocalPlayer.Character --Get the character, I'm assuming you did this
04local gun1 = game.Lighting.Guns.Runner.SniperRifle:Clone() --Make a copy of the gun in Lighting to put in the player's backpack
05local gun2 = game.Lighting.Guns.Runner.London:Clone() --Make a copy of the gun in Lighting to put in the player's backpack
06local Humanoid = char:WaitForChild("Humanoid") --Easily call the player's Humanoid. But we may need to wait a bit, so use :WaitForChild()
07gun1.Parent = game.Players.LocalPlayer.Backpack --Take the copied guns and paste them into the player's backpack
08gun2.Parent = game.Players.LocalPlayer.Backpack
09 
10Humanoid:EquipTool(gun1) --Force equip
11 
12function Switch() --This is your main function that will fire every time the player moves his/her mouse wheel up or down
13    if gun1.Parent == char then --Check if gun1 is currently equipped
14            print("Gun1 is parented") --Debug
15        Humanoid:UnequipTools() --Unequip all the tools that the Humanoid currently has equipped
16        wait(.5) --Wait a little bit to make sure it unequips
17        print("Gun2 is parented") --Debug
18        Humanoid:EquipTool(gun2) --Equip the next gun
19    elseif gun2.Parent == char then --Same thing here, just reversed
20        print("Gun2 is parented") --Debug
21        Humanoid:UnequipTools()
22        wait(.5)
23        print("Gun1 is parented") --Debug
24        Humanoid:EquipTool(gun1)
25    end
26end
27 
28mouse.WheelForward:connect(Switch) --I'm doing it this way so you can switch with both directions
29mouse.WheelBackward:connect(Switch)
 View all 29 lines...

I tested this to make sure it would work and this is what happened

I made a LocalScript inside the StarterPack for this to work. If the snippet is from a LocalScript and is in StarterPack then you shouldn't have to worry about that.

Good luck with your future Scripting Adventures! ~lightpower26

Thanks this also helped me with my question too! LifeInDevelopment 364 — 9y

I get an error saying 'UnequipTools can only be called on a Humanoid with a corresponding Player object.' LifeInDevelopment 364 — 9y

How would you cycle through weapons?

1 answer

Answer this question