Scripting Helpers is winding down operations and is now read-only. More info→

How can I simplify this script?

Asked by

9 years ago

So I have an instructions GUI with lots of buttons and frames, and the script that makes the frames open and close is extremely inefficient. I have to manually add each frame every time a add a new button to the GUI, and its super time consuming. What I would like to know is if there is a function that can get all the children of a frame except one specific one. Is that possible?

01local BUTTON = script.Parent
02local TlFRAME = BUTTON.Parent.Parent
03local FRAME = TlFRAME.Arbalest
04local NAME = BUTTON.Text
05local ITEMNAME = FRAME.Itemname
06 
07local CRUDECLUB = TlFRAME.CrudeClub
08local HUNTINGCLUB =  TlFRAME.HuntingClub
09local FLINT = TlFRAME.Flint
10local CRUDEBUCKET = TlFRAME.CrudeBucket
11local COPPERAXE = TlFRAME.CopperAxe
12local COPPERPICKAXE = TlFRAME.CopperPickaxe
13local IRONAXE = TlFRAME.IronAxe
14local IRONPICKAXE = TlFRAME.IronPickaxe 
15local CRUDEBOW = TlFRAME.CrudeBow
16local CRUDEFISHINGROD = TlFRAME.CrudeFishingRod
17local LONGBOW = TlFRAME.Longbow
18local SHORTBOW = TlFRAME.Shortbow
19local HUNTINGBOW = TlFRAME.HuntingBow 
20local FISHINGROD = TlFRAME.FishingRod
21local CROSSBOW = TlFRAME.Crossbow 
22local ARBALEST = TlFRAME.Arbalest 
23local STEELAXE = TlFRAME.SteelAxe 
24local STEELPICKAXE = TlFRAME.SteelPickaxe 
25local BUCKET = TlFRAME.Bucket 
26local CRAFTINGKNIFE = TlFRAME.CraftingKnife 
27local SKINNINGKNIFE = TlFRAME.SkinningKnife 
28local LUMBERSAW = TlFRAME.Lumbersaw 
29local SLEDGEHAMMER = TlFRAME.SledgeHammer 
30local MASONRYHAMMER = TlFRAME.MasonryHammer 
31local BLUNDERBUSS = TlFRAME.Blunderbuss 
32local FLINTSTEEL = TlFRAME.FlintSteel 
33local DYE = TlFRAME.Dye 
34 
35FRAME.Visible = false
36 
37function on_button1_down()
38 
39    CRUDECLUB.Visible = false
40    HUNTINGCLUB.Visible = false
41    FLINT.Visible = false
42    CRUDEBUCKET.Visible = false
43    COPPERAXE.Visible = false
44    COPPERPICKAXE.Visible = false
45    IRONAXE.Visible = false
46    IRONPICKAXE.Visible = false
47    CRUDEBOW.Visible = false
48    CRUDEFISHINGROD.Visible = false
49    LONGBOW.Visible = false
50    SHORTBOW.Visible = false
51    HUNTINGBOW.Visible = false
52    FISHINGROD.Visible = false
53    CROSSBOW.Visible = false
54    --ARBALEST.Visible = false
55    STEELAXE.Visible = false
56    STEELPICKAXE.Visible = false
57    BUCKET.Visible = false
58    CRAFTINGKNIFE.Visible = false
59    SKINNINGKNIFE.Visible = false
60    LUMBERSAW.Visible = false
61    SLEDGEHAMMER.Visible = false
62    MASONRYHAMMER.Visible = false
63    BLUNDERBUSS.Visible = false
64    FLINTSTEEL.Visible = false
65    DYE.Visible = false
66 
67    ITEMNAME.Text = NAME
68 
69    FRAME.Visible = (not FRAME.Visible)
70 
71    end
72 
73BUTTON.MouseButton1Down:connect(on_button1_down)
 View all 73 lines...

3 answers

Answered by

raspyjessie 117

9 years ago

Sorry retread question I would still suggest using a for loop but with a conditional statement

1For I,v in pairs (Frame:Getchilrden()) do
2If v.Name ~=  -- item to avoid
3V.visible = false
4end
5end

That's actually a good answer. Since all the assets are held in TlFRAME and they are all being set to a certain property. M39a9am3R 3210 — 9y

Answered by

Gwolflover 80

9 years ago

01local BUTTON = script.Parent
02local ITFRAME = BUTTON.Parent.Parent
03local FRAME = ITFRAME.Hull
04local NAME = BUTTON.Text
05local ITEMNAME = FRAME.Itemname
06local SCROLLINGFRAME = ITFRAME.ScrollingFrame
07 
08FRAME.Visible = false
09 
10function on_button1_down()
11 
12    for I,v in pairs (FRAME:Getchilrden()) do
13if v.Name ~=  SCROLLINGFRAME-- item to avoid
14then v.Visible = false
15else I.Visible = true
16end
17 
18 
19    ITEMNAME.Text = NAME
20 
21    FRAME.Visible = (not FRAME.Visible)
22 
23    end
24    end
25BUTTON.MouseButton1Down:connect(on_button1_down)
 View all 25 lines...

So would this work?

On line 15 I is only a number so it I'll error out, so just name it the thing, I is the number of the object in the table and v is the value raspyjessie 117 — 9y

OHHHHH thanks! Gwolflover 80 — 9y

oh wait now the error is "Getchildren is not a valid member of Frame Gwolflover 80 — 9y

You wrote "Getchilrden" instead of "GetChildren" 1waffle1 2908 — 9y

Answered by

Wutras 294

9 years ago

That's a pretty simple problem and can easily be solved with a for _, fr in pairs(TlFrame:GetChildren()) do which will do the stuff inside of this and an end to anything inside of this table.

01local BUTTON = script.Parent
02local TlFRAME = BUTTON.Parent.Parent
03local FRAME = TlFRAME.Arbalest
04local NAME = BUTTON.Text
05local ITEMNAME = FRAME.Itemname
06 
07FRAME.Visible = false
08 
09function on_button1_down()
10    for _, fr in pairs(TlFrame:GetChildren()) do
11        if fr ~= FRAME then -- This will prevent the content of the FRAME variable from being changed.
12        fr.Visible = false
13        end
14    end
15    ITEMNAME.Text = NAME
16    FRAME.Visible = (not FRAME.Visible)
17end
18 
19BUTTON.MouseButton1Down:connect(on_button1_down)

If this doesn't help you with your problems or isn't what you needed, simply reply in a comment and I'll see what I can do.

ok I've adjusted it a bit and now it works except it makes all of the frames appear instead of just the one frame I want (called FRAME) Gwolflover 80 — 9y

local BUTTON = script.Parent local ITFRAME = BUTTON.Parent.Parent local FRAME = ITFRAME.SmallHandle local NAME = BUTTON.Text local ITEMNAME = FRAME.Itemname local SCROLLINGFRAME = ITFRAME.ScrollingFrame FRAME.Visible = false function on_button1_down() for _, fr in pairs(ITFRAME:GetChildren()) do if fr ~= SCROLLINGFRAME then -- This will prevent the content of the FRAME variable from Gwolflover 80 — 9y

Sorry its not easy to see here, I'll post the edited script on my other post ok? Gwolflover 80 — 9y

How can I simplify this script?

3 answers

Answer this question