Is there a more efficient way of doing this?

Asked by

9 years ago

This script looks, and probably is, very inefficient. And it doesn't want to work. Any help?

01game.Players.PlayerAdded:connect(function(plr)
02    local rank = Instance.new("StringValue", plr)
03        rank.Name = "Rank"
04    local stats = plr:WaitForChild("leaderstats")
05    local rep = stats:WaitForChild("Reputation")
06 
07    --POSITIVE
08 
09    if rep then
10        print("Found "..plr.Name.."'s reputation.")
11    end
12 
13    if rep.Value <= 99 then
14        rank.Value = "Civilian"
15    end
16 
17    if rep.Value >= 100 and rep.Value < 999 then
18        rank.Value = "Constable"
19    end
20 
21    if rep.Value >= 1000 and rep.Value < 2499 then
22        rank.Value = "Vigilante"
23    end
24 
25    if rep.Value >= 2500 and rep.Value < 4999 then
26        rank.Value = "Deputy"
27    end
28 
29    if rep.Value >= 5000 and rep.Value < 9999 then
30        rank.Value = "Lawman"
31    end
32 
33    if rep.Value >= 10000 and rep.Value < 14999 then
34        rank.Value = "Guardian"
35    end
36 
37    if rep.Value >= 15000 and rep.Value < 24999 then
38        rank.Value = "Nobile"
39    end
40 
41    if rep.Value >= 25000 and rep.Value < 99999 then
42        rank.Value = "Hero"
43    end
44 
45    if rep.Value >= 100000 and rep.Value < 249999 then
46        rank.Value = "Omeaga Hero"
47    end
48 
49    if rep.Value >= 250000 then
50        rank.Value = "Saint of Sanctuary"
51    end
52 
53    --NEGATIVE// WILL DO THE SAME TO THIS//
54 
55--  if rep.Value <= -1 then
56--      rank.Value = "Civilian"
57--  end
58--  
59--  if rep.Value <= -5 then
60--      rank.Value = "Felon"
61--  end 
62--  
63--  if rep.Value <= -100 then
64--      rank.Value = "Thug"
65--  end
66--  
67--  if rep.Value <= -1000 then
68--      rank.Value = "Outlaw"
69--  end
70--  
71--  if rep.Value <= -2500 then
72--      rank.Value = "Bandit"
73--  end
74--  
75--  if rep.Value <= -5000 then
76--      rank.Value = "Marauder"
77--  end
78--  
79--  if rep.Value <= -10000 then
80--      rank.Value = "Villian"
81--  end
82--  
83--  if rep.Value <= -15000 then
84--      rank.Value = "Hitman"
85--  end
86--  
87--  if rep.Value <= -25000 then
88--      rank.Value = "Assassin"
89--  end
90--  
91--  if rep.Value <= -100000 then
92--      rank.Value = "Serial Killer"
93--  end
94--  
95--  if rep.Value <= -250000 then
96--      rank.Value = "Destroyer of Worlds"
97--  end
98 
99end)
 View all 99 lines...

Well you certainly should use elseif instead of all those ifs, but I don't know any super clever way to make it much shorter. I hope someone else does. Perci1 4988 — 9y

I had elseifs, but it crashed. Still didn't work, though. SimplyRekt 413 — 9y

Is there a more efficient way of doing this?

1 answer

Answer this question