Scripting Helpers is winding down operations and is now read-only. More info→

Could this return script actually work?

Asked by

NeonicPlasma 181

9 years ago

The Goal

So what I am trying to do is to make a minigame place. It checks if the minigame has a pointbrick and if it does then it means that the minigame is a race. We have to detect when that brick is touched so then when touched it will end the minigame.

The Problem I am not experienced with the 'return' code so can you help with this? The Code

01function round()
02    local minigames = game.Lightning:GetChildren()        
03    local map = minigames[number]
04    local number = math.random(1, #minigames)
05    local spawns = map.Spawns.GetChildren()
06    local pointbrick = map.PointBrick
07    for intermission = 25,1,-1 do
08        game.Workspace.Timer.Value = "Intermission: "..intermission
09 
10    end
11    game.Workspace.Timer.Value = "The game will start shortly."
12    wait(3)
13    game.Workspace.Timer.Value = "Choosing Minigame..."
14    wait(3)
15    game.Workspace.Timer.Value = "Minigame: "..map.Name
16    wait(3)
17    game.Workspace.Timer.Value = "Loading Minigame..."
18    wait(3)
19    mapModel = map:clone()
20    mapModel.Parent = Workspace
21    game.Workspace.Timer.Value = "Teleporting players..."
22    wait(1)   
23    for _, player in pairs(game.Players:GetPlayers()) do
24        local character = player.Character
25        local randomSpawn = spawns[math.random(#spawns)] -- EDIT
26        if character then
27            character:MoveTo(randomSpawn.Position) -- EDIT
28         end
29    end
30    wait(1)
31    for readySetGo = 3,1,-1
32        game.Workspace.Timer.Value = readySetGo
33        wait(1)
34    end
35    game.Workspace.Timer.Value = "Go!"
36    for timer = 150,1,-1 do
37        if pointbrick then
38             function endRoundAuto()
39                game.Workspace.Timer.Value = "Game over!"
40                mapModel:remove()
41                wait(3)
42                return round  
43             end
44        end
45        game.Workspace.Timer.Value = "Time left: "..timer
46    end
47    if pointbrick then
48        game.Workspace.Timer.Value = "Nobody won. Too bad."
49        mapModel:remove()
50        wait(3)
51        return true
52    else
53        game.Workspace.Timer.Value = "Game over! Winners get __ points!"
54        mapModel:remove()
55        wait(3)
56        return true
57     end
58end
59 
60if pointbrick then
61    pointbrick.Touched:connect(endRoundAuto)
62end
 View all 62 lines...

2 answers

Answered by

Marios2 360

9 years ago

What exactly are you trying to return, and why return anyway? All the returns you have there are pointless. And even without return this script doesn't work.

return is used in functions which are used to process a value and return another. It is also used to cut a statement or loop short.

Here's an example of a function with return:

01--Read game.Players.PlayerAdded first!
02 
03function getId(user) -- In the function we decide to refer to the Player instance as "user"
04    id = user.UserId --We make this variable that gets the player's UserId
05    return id --The variable we got above returns to the event function.
06    --This means that, all lines which are inside the event function and which are after getId below now know a new variable: id.
07end
08 
09game.Players.PlayerAdded:connect(function(player)
10    getId(player) -- The Player instance that was added is taken for processing at the function
11    print(id .. " has joined the server") -- The userid that joined gets printed.
12    --Note that in some cases where you want an interger/number to be a string you must use tostring(number).
13    --For reasons i don't know the script works without it.
14end)

Here's an example ofreturn used as an interruption:

01--Back in my early days on Roblox this is just what follower NPCs were.
02repeat
03--Suppose we have script on here that finds closest player and sets a global variable used below
04    repeat
05        if player == nil then return end -- The repeat loop ends abnormally if we have no player or his character
06        if player.Character == nil then return end
07        script.Parent:MoveTo(player.Character.Torso.Position)
08        wait(0.07)
09    until not (player and player.Character) --The repeat loop ends normally on this case
10until false --This makes a repeat loop endless, provided there is no return for this one

Here's your script fixed (which doesn't need return as anything):

01function round()
02    local minigames = game.Lightning:GetChildren()        
03    local map = minigames[number]
04    local number = math.random(1, #minigames)
05    local spawns = map.Spawns.GetChildren()
06    local pointbrick = map.PointBrick
07    for intermission = 25,1,-1 do
08        game.Workspace.Timer.Value = "Intermission: "..intermission
09 
10    end
11    game.Workspace.Timer.Value = "The game will start shortly."
12    wait(3)
13    game.Workspace.Timer.Value = "Choosing Minigame..."
14    wait(3)
15    game.Workspace.Timer.Value = "Minigame: "..map.Name
16    wait(3)
17    game.Workspace.Timer.Value = "Loading Minigame..."
18    wait(3)
19    mapModel = map:clone()
20    mapModel.Parent = Workspace
21    game.Workspace.Timer.Value = "Teleporting players..."
22    wait(1)   
23    for _, player in pairs(game.Players:GetPlayers()) do
24        local character = player.Character
25        local randomSpawn = spawns[math.random(#spawns)] -- EDIT
26        if character then
27            character:MoveTo(randomSpawn.Position) -- EDIT
28         end
29    end
30    wait(1)
31    for readySetGo = 3,1,-1
32        game.Workspace.Timer.Value = readySetGo
33        wait(1)
34    end
35    game.Workspace.Timer.Value = "Go!"
36    for timer = 150,1,-1 do
37        if not pointbrick then --Someone took the brick? End!
38        --Make sure the pointbrick itself makes sure to remove when a player touches it.
39                game.Workspace.Timer.Value = "Game over!"
40                mapModel:Destroy() --Remove() sets parent to nil and the mapModel can be referred to again. Destroy() will remove it completely, as you will never want to refer to it again.. Helps for later performance.
41                wait(3)
42        timer = 0 -- Make this the last loop, it's all over
43    else
44        game.Workspace.Timer.Value = "Time left: "..timer -- Not done yet? Then keep counting, i guess.
45        wait(1) --Wait before the next second counting
46        end
47    end
48    if pointbrick then
49        game.Workspace.Timer.Value = "Nobody won. Too bad."
50        mapModel:Destroy()
51        wait(3)
52    else
53        game.Workspace.Timer.Value = "Game over! Winners get __ points!"
54        mapModel:Destroy()
55        wait(3)
56     end
57end
58 
59--The script you had here was removed on purpose. The main script cannot multitask like that so you'll have to give the pointbrick something to do.
 View all 59 lines...

I hope i helped with both the script and understanding return.

Dude... look down. NeonicPlasma 181 — 9y

Dude, the one I want is cut short. NeonicPlasma 181 — 9y

Answered by

NeonicPlasma 181

9 years ago

So I saw the answer. But you do realize that the game is a minigame place and that it will actually go like this?

01function round()
02    local minigames = game.Lightning:GetChildren()        
03    local map = minigames[number]
04    local number = math.random(1, #minigames)
05    local spawns = map.Spawns.GetChildren()
06    local pointbrick = map.PointBrick
07    for intermission = 25,1,-1 do
08        game.Workspace.Timer.Value = "Intermission: "..intermission
09 
10    end
11    game.Workspace.Timer.Value = "The game will start shortly."
12    wait(3)
13    game.Workspace.Timer.Value = "Choosing Minigame..."
14    wait(3)
15    game.Workspace.Timer.Value = "Minigame: "..map.Name
16    wait(3)
17    game.Workspace.Timer.Value = "Loading Minigame..."
18    wait(3)
19    mapModel = map:clone()
20    mapModel.Parent = Workspace
21    game.Workspace.Timer.Value = "Teleporting players..."
22    wait(1)   
23    for _, player in pairs(game.Players:GetPlayers()) do
24        local character = player.Character
25        local randomSpawn = spawns[math.random(#spawns)] -- EDIT
26        if character then
27            character:MoveTo(randomSpawn.Position) -- EDIT
28         end
29    end
30    wait(1)
31    for readySetGo = 3,1,-1
32        game.Workspace.Timer.Value = readySetGo
33        wait(1)
34    end
35    game.Workspace.Timer.Value = "Go!"
36    for timer = 150,1,-1 do
37        if not pointbrick then --Someone took the brick? End!
38        --Make sure the pointbrick itself makes sure to remove when a player touches it.
39                game.Workspace.Timer.Value = "Game over!"
40                mapModel:Destroy() --Remove() sets parent to nil and the mapModel can be referred to again. Destroy() will remove it completely, as you will never want to refer to it again.. Helps for later performance.
41                wait(3)
42        timer = 0 -- Make this the last loop, it's all over
43    else
44        game.Workspace.Timer.Value = "Time left: "..timer -- Not done yet? Then keep counting, i guess.
45        wait(1) --Wait before the next second counting
46        end
47    end
48    if pointbrick then
49        game.Workspace.Timer.Value = "Nobody won. Too bad."
50        mapModel:Destroy()
51        wait(3)
52    else
53        game.Workspace.Timer.Value = "Game over! Winners get __ points!"
54        mapModel:Destroy()
55        wait(3)
56     end
57end
58 
59while true do
60    wait(1)
61    round()
62end
 View all 62 lines...

Yes, i do. And i forgot to make the minigame loop, my bad. Well the only mistake in the script i gave you is that i forgot to make it loop, is it really that good of a reason to insult? Marios2 360 — 9y

Anyways, I'm just gonna upvote every comment you put. NeonicPlasma 181 — 9y

Could this return script actually work?

2 answers

Answer this question