Please provide explanation with your answers. Simply posting code does not spread knowledge of integral scripting processes which helps people understand the logic and reasoning behind your answer.
Okay, I'll go in depth a bit more.
So, first, let's change our variables to local, so we're not storing unnecessary data in the script's function environment.
03 | local torso = script.Parent.Torso |
09 | function findNearestTarget() |
14 | local plrs = game.Players:GetPlayers() |
16 | for i,plr in ipairs (plrs) do |
18 | if plr.Character:findFirstChild("Humanoid") and plr.Character.Humanoid.Health>0 then |
19 | local tor = plr.Character:FindFirstChild("Torso") |
20 | if target and tor then |
21 | if (torso.Position-tor.Position).Magnitude <= range then |
22 | print(plr.Name.." is in range") |
23 | target = plr.Character |
35 | if hit.Parent and hit then |
36 | if hit.Parent:findFirstChild("Humanoid") then |
37 | hit.Parent.Humanoid:TakeDamage(armDmg) |
43 | if hit.Parent and hit then |
44 | if hit.Parent:findFirstChild("Humanoid") then |
45 | hit.Parent.Humanoid:TakeDamage(torDmg) |
50 | script.Parent["Left Arm"].Touched:connect(hitArm) |
51 | script.Parent["Right Arm"].Touched:connect(hitArm) |
52 | script.Parent["Torso"].Touched:connect(hitTorso) |
57 | script.Parent.Zombie:MoveTo(target.Torso.Position,target.Torso) |
Now, there are a few things we should elaborate on.
1: Comparing positions
We see in your code that we have something like:
1 | if (torso.Position-tor.Position).Magnitude < (torso.Position-target.Torso.Position).Magnitude then |
Now, here, we want to compare the magnitude of these 2 vectors, with the "range" variable.
So it would now look something like this:
1 | if (torso.Position-tor.Position).Magnitude < range then |
Other than that, indenting seems pretty good and you should probably get into the habit of using if statements
like:
Just to make the code seem a bit neater, and eliminate obsolete comparisons.
Hope this helped, let me know if you have any questions.
0