Player is nil in Module Script?

Asked by

LegitimatlyMe 519

9 years ago

Boom boom complicated metatables ahead!

Great, I'm inexperienced in writing questions for I have only written answers, ain't that dandy?

My issue is that whenever I try to access the player in a module script, it thinks it's nil, here is the source code

01local DS = game:GetService("DataStoreService"):GetDataStore("Stuff_DS_V1");
02local PM = {} do
03    PM.RegisteredPlayers = {};
04    local Methods = {}; 
05 
06    Methods.GetData = function(plr, key, defaultVal)
07        local data = DS:GetAsync(plr.player.userId.."_"..key);
08        if data then
09            if type(defaultVal) == "table"then
10                return data;
11            else
12                return data;
13            end
14        else
15            return defaultVal;
16        end
17    end
18 
19    Methods.SaveData = function(plr, key, val)
20        DS:SetAsync(plr.Player.userId.."_"..key, val);
21    end
22 
23    Methods.LoadData = function(plr)
24        local data = plr:GetData("Stats", {Blox = 0, Lvl = 1, Exp = 0});
25        plr.Blox = data.Blox;
26        plr.Lvl = data.Lvl;
27        plr.Exp = data.Exp;
28        local backpack = plr:GetData("Backpack", {Backpack = {"Sword", "Classic"}, Equipped = {Melee = "Sword",Grave = "Classic"}});
29        for i,v in pairs(backpack.Backpack) do
30            table.insert(plr.Backpack, v);
31        end
32        for i,v in pairs(backpack.Equipped) do
33            plr.Equipped[tostring(i)] = tostring(v);
34        end
35    end
36 
37    Methods.Destroy = function(plr)
38        PM.RegisteredPlayers[tostring(plr.player.userId)] = nil;
39    end
40 
41    PM.RegisterPlayer = function(plr)
42        if PM.RegisteredPlayers[tostring(plr.userId)] == nil then
43            local Data = {};
44            Data.Blox = 0;
45            Data.Lvl = 0;
46            Data.Exp = 0;
47            Data.Backpack = {};
48            Data.Equipped = {};
49            setmetatable(Data, {
50                __index = function(tab, key)
51                    if key:lower() == "player" then
52                        return plr;
53                    elseif Methods[key] then
54                        return function(...)
55                            return Methods[key](...);
56                        end
57                    elseif Data[key] then
58                        return Data[key];
59                    else
60                        print("ERROR: "..key.." is nil.")               
61                    end
62                end,
63            });
64            PM.RegisteredPlayers[tostring(plr.userId)] = Data;
65            return Data;
66        else
67            print(plr.Name.." is already registered and will be allowed to access the custom methods.");
68            return PM.RegisteredPlayers[tostring(plr.userId)];
69        end
70    end
71 
72    PM.Get = function(plr)
73        if plr == nil then print("Argument 'plr' is nil.") return; end
74        print("Getting the Player Table for: "..plr.Name);
75        return PM.RegisterPlayer(plr);
76    end
77 
78end
79 
80return PM;
 View all 80 lines...

That is the module script, as you can see, if the index is "player", then it returns the player object

And this is the normal handler script

01local PM = require(game.ServerScriptService:WaitForChild("Modules"):WaitForChild("PlayerManager"));
02 
03game.Players.PlayerAdded:connect(function(plr)
04    local makeshiftPlayer = PM.Get(plr);
05    print(makeshiftPlayer.Player.userId);
06    makeshiftPlayer:LoadData();
07end)
08 
09game.Players.PlayerRemoving:connect(function(plr)
10    local makeshiftPlayer = PM:Get(plr);
11    makeshiftPlayer:SaveData("Stats", {Blox = makeshiftPlayer.Blox, Lvl = makeshiftPlayer.Lvl, Exp = makeshiftPlayer.Exp});
12    makeshiftPlayer:SaveData("Backpack",{Backpack = plr.Backpack, Equipped = plr.Equipped});
13    wait();
14    makeshiftPlayer:Destroy();
15end)

But what's interesting is, the error only happens when a player leaves, I've already tested if the player is nil if you send it to a module, it is not.

The very error happens in the PM.Get function, which isn't even all that complicated, but even the script can't find the player for some reason.

11:49:06.526 - ServerScriptService.Modules.PlayerManager:74: attempt to concatenate field 'Name' (a nil value) 11:49:06.527 - Stack Begin 11:49:06.529 - Script 'ServerScriptService.Modules.PlayerManager', Line 74 - method Get 11:49:06.530 - Script 'ServerScriptService.Scripts.Player', Line 10 11:49:06.531 - Stack End

If I remove the 'print("Getting the Player Table for: "..plr.Name)', it errors in the Methods.SaveData function, where it says userId is nil.

11:49:06.526 - ServerScriptService.Modules.PlayerManager:68: attempt to concatenate field 'userId' (a nil value) 11:49:06.527 - Stack Begin 11:49:06.529 - Script 'ServerScriptService.Modules.PlayerManager', Line 68 - method SaveData 11:49:06.530 - Script 'ServerScriptService.Scripts.Player', Line 11 11:49:06.531 - Stack End

And, like the other error, it only errors when you leave. I suspected that when you index 'player' it returns nil since the player left.

How can I access the player, without it being nil?

Whoops, seems like my output is outdated LegitimatlyMe 519 — 9y

Player is nil in Module Script?

1 answer

Cleanup Aside

Answer this question