Scripting Helpers is winding down operations and is now read-only. More info→
Ad
Log in to vote
0

making this into a on enter script?

Asked by
22To 70
9 years ago

changing this toa on enter script?

view source
01function ChangeMe(hit)
02    if hit.Parent == nil then return end
03    if (hit.Parent:findFirstChild("Humanoid") == nil) then return end
04    local human = hit.Parent:findFirstChild("Humanoid")
05    local char = hit.Parent
06    local player = game.Players:GetPlayerFromCharacter(hit.Parent)
07    if (human ~= nil) and debounce == false then
08        debounce = true
09        originals = char:getChildren()
10        for w = 1, #originals do
11            if originals[w].className == "CharacterMesh" then
12                originals[w]:remove()
13            end
14        end
15        meshes = script:getChildren()
View all 25 lines...

1 answer

Log in to vote
0
Answered by
legobuildermaster 220 Moderation Voter
9 years ago

Hello! So this fix is fairly simple! Let me explain it a little bit first.

The way I approach this is by using the PlayerAdded event! It's simple and easy too. Now the problem is how you have you function setup, so I will edit you code to make it compatible with the new code!

Below, is the framework for the new stuff!

view source
1function changeMe(player) -- Has the player and is called when a player is added!
2end
3 
4game.Players.PlayerAdded:connect(changeMe()) -- "PlayerAdded" returns the player thus we can easily edit them!

Now that we have the framework, let's continue with the explaination!

view source
01function changeMe(player)
02    local character = player.Character or player:WaitForChild("Character") -- Gets the player's character!
03    local humanoid = character.Humanoid or character:WaitForChild("Humanoid")
04    if (humanoid ~= nil) and debounce == false then
05        debounce = true
06        originals = character:GetChildren()
07        for _, object in pairs(originals) do
08            if object:IsA("CharacterMesh") then
09                object:Remove()
10            end
11        end
12        meshes = script:GetChildren()
13        for _, object in pairs(meshes) do
14            copy = object:Clone()
15            copy.Parent = character
View all 22 lines...

I definitely changed A Lot of code, but I won't leave you stranded!

If you see, I changed you "for loops" to be MUCH more efficient! Now what they do specifically, is cycle through a table and return two things, the index and the table item! The _, object are those two parameters, but since we don't need the index, I wrote mine as a garbage variable or "_". Here is also a link for more information on loops, including the one I used!

P.S. Don't copy my code and expect it to fully work! Skim over it to see if there are errors and if there are errors, please let me know!

Ad

Answer this question