Scripting Helpers is winding down operations and is now read-only. More info→

Help with a function not working? [closed]

Asked by

NinjoOnline 1146

9 years ago

01local replicatedstorage = game:GetService("ReplicatedStorage")
02local weapons = replicatedstorage:WaitForChild("Weapons") 
03local woodensword = weapons:WaitForChild("WoodenSword")
04local knightssword = weapons:WaitForChild("KnightsSword")
05 
06function giveSword(player)
07    if player then
08        local backpack = player:WaitForChild("Backpack")
09        if backpack then
10            local startergear = player:WaitForChild("StarterGear")
11            if startergear then
12                if player.Weapon.Value == "WoodenSword" then
13                    woodensword:Clone().Parent = backpack
14                    woodensword:Clone().Parent = startergear
15                elseif player.Weapon.Value == "KnightsSword" then
16                    knightssword:Clone().Parent = backpack
17                    knightssword:Clone().Parent = startergear                   
18                end
19            end
20        end
21    end
22end
23 
24wait(5)
25giveSword()
 View all 25 lines...

This code I want to give swords to players , but it doesn't work when I call the function. Am I missing something? There is no error in the output on both the server and client, so I don't know whats going wrong. Thanks

Locked by NinjoOnline, davness, XToonLinkX123, and BSIncorporated

This question has been locked to preserve its current state and prevent spam and unwanted comments and answers.

Why was this question closed?

1 answer

Answered by

davness 376

9 years ago

Well, let's start:

1. No parameter, end!

The first issue you got was on calling function. You didn't set an parameter for giveSword function:

01local replicatedstorage = game:GetService("ReplicatedStorage")
02local weapons = replicatedstorage:WaitForChild("Weapons") 
03local woodensword = weapons:WaitForChild("WoodenSword")
04local knightssword = weapons:WaitForChild("KnightsSword")
05 
06function giveSword(player) -- you requested a player
07    if player then -- if the player exists then do stuff
08        local backpack = player:WaitForChild("Backpack")
09        if backpack then
10            local startergear = player:WaitForChild("StarterGear")
11            if startergear then
12                if player.Weapon.Value == "WoodenSword" then
13                    woodensword:Clone().Parent = backpack
14                    woodensword:Clone().Parent = startergear
15                elseif player.Weapon.Value == "KnightsSword" then
16                    knightssword:Clone().Parent = backpack
17                    knightssword:Clone().Parent = startergear                   
18                end
19            end
20        end
21    end -- else do nothing
22end
23 
24wait(5)
25giveSword() -- you must to set who is the player, else, player will be set as nil, which means false on an if statement
 View all 25 lines...

So you need to set the player:

`1`	`giveSword(game.Players:WaitForChild("Playername"))`

2. Did you want to give sword for everyone, right?

To do that, you can use PlayerAdded event to apply that function to the new player:

01local replicatedstorage = game:GetService("ReplicatedStorage")
02local weapons = replicatedstorage:WaitForChild("Weapons") 
03local woodensword = weapons:WaitForChild("WoodenSword")
04local knightssword = weapons:WaitForChild("KnightsSword")
05 
06game.Players.PlayerAdded:connect(function(player) -- request the player from the event
07local backpack = player:WaitForChild("Backpack")
08        if backpack then
09            local startergear = player:WaitForChild("StarterGear")
10            if startergear then
11                if player.Weapon.Value == "WoodenSword" then
12                    woodensword:Clone().Parent = backpack
13                    woodensword:Clone().Parent = startergear
14                elseif player.Weapon.Value == "KnightsSword" then
15                    knightssword:Clone().Parent = backpack
16                    knightssword:Clone().Parent = startergear                   
17                end
18            end
19        end
20end)

But if you want to give sword to everyone at a certain time, we must to call a for loop:

01local replicatedstorage = game:GetService("ReplicatedStorage")
02local weapons = replicatedstorage:WaitForChild("Weapons") 
03local woodensword = weapons:WaitForChild("WoodenSword")
04local knightssword = weapons:WaitForChild("KnightsSword")
05 
06function giveSword()
07for i, v in pairs(game.Players:GetChildren()) do
08local backpack = v:WaitForChild("Backpack") -- v is the current player
09        if backpack then
10            local startergear = v:WaitForChild("StarterGear")
11            if startergear then
12                if v.Weapon.Value == "WoodenSword" then
13                    woodensword:Clone().Parent = backpack
14                    woodensword:Clone().Parent = startergear
15                elseif v.Weapon.Value == "KnightsSword" then
16                    knightssword:Clone().Parent = backpack
17                    knightssword:Clone().Parent = startergear                   
18                end
19            end
20        end
21end
22end
 View all 22 lines...

3. If statement for WaitForChild() ?

Statements requesting for a child provided by :WaitForChild() function are useless.

01local replicatedstorage = game:GetService("ReplicatedStorage")
02local weapons = replicatedstorage:WaitForChild("Weapons") 
03local woodensword = weapons:WaitForChild("WoodenSword")
04local knightssword = weapons:WaitForChild("KnightsSword")
05 
06game.Players.PlayerAdded:connect(function(player) -- request the player from the event
07local backpack = player:WaitForChild("Backpack")
08local startergear = player:WaitForChild("StarterGear")
09local weaponval = player:WaitForChild("Weapon")
10    if weaponval.Value == "WoodenSword" then
11        woodensword:Clone().Parent = backpack
12        woodensword:Clone().Parent = startergear
13    end
14    if weaponval.Value == "KnightsSword" then
15        knightssword:Clone().Parent = backpack
16        knightssword:Clone().Parent = startergear
17    end
18end)

4. Server or Client?

A thing you must to understand is that ReplicatedStorage is useful for LocalScripts, while if you use a Server Script, you should use ServerStorage instead.

Final Script

Once you want to give the swords a certain time, here it goes:

01local weapons = game:GetService("ServerStorage"):WaitForChild("Weapons") 
02local woodensword = weapons:WaitForChild("WoodenSword")
03local knightssword = weapons:WaitForChild("KnightsSword")
04 
05function giveSword()
06    for i, v in pairs(game.Players:GetChildren()) do
07        local backpack = v:WaitForChild("Backpack") -- v is the current player
08        local startergear = v:WaitForChild("StarterGear")
09        if v.Weapon.Value == "WoodenSword" then
10            woodensword:Clone().Parent = backpack
11            woodensword:Clone().Parent = startergear
12            elseif v.Weapon.Value == "KnightsSword" then
13                knightssword:Clone().Parent = backpack
14                knightssword:Clone().Parent = startergear                   
15            end
16        end
17    end
18    end
19end
20 
21wait(5)
22giveSword()
 View all 22 lines...

Well, I'm trying to give each player a sword, so some players might be given woodenswords if their weaponvalue is set to "WoodenSword" or they might get the knight sword, and I don't want a player event, I just need when I call the function to give the players the right swords NinjoOnline 1146 — 9y

oh so you want to give the sword at a certain moment? davness 376 — 9y

yeah, I got it working though, thanks for the detailed explanation :) +1 & answer accepted! NinjoOnline 1146 — 9y