Scripting Helpers is winding down operations and is now read-only. More info→

Why is this giving everyone a weapon?

Asked by

bubbaman73 143

9 years ago

So im trying to give one person a weapon, but its giving everyone a weapon when i start a test server in studio

1local choose = game.Players:GetPlayers()[math.random(1,#game.Players:GetPlayers())]
2 
3if choose:FindFirstChild("Backpack") then
4game.ReplicatedStorage.Luger:Clone().Parent = choose.Backpack;
5 
6end

EDIT

thats not all of it though,

01local players = game.Players:GetPlayers()
02local using = false
03 
04while math.huge do
05    wait(5)
06using = false
07if using == false then
08  using = true 
09    if (game.Players.NumPlayers <= 1) then -- This will be the less complicated 'invite more' part
10        using = true
11        game.StarterGui.gui.LocalScript.Event:Fire()
12    else
13    if(game.Players.NumPlayers >= 2) then
14        wait(5)
15 
16     target = CFrame.new(0, 50, 0) --could be near a brick or in a new area
17for i, player in ipairs(game.Players:GetChildren()) do
18   --Make sure the character exists and its torso exists
19   if player.Character and player.Character:FindFirstChild("Torso") then
20       --add an offset of 5 for each character
21      player.Character.Torso.CFrame = target + Vector3.new(0, i * 5, 0)
22 
23wait()
24 
25local choose = game.Players:GetPlayers()[math.random(1,#game.Players:GetPlayers())]
26 
27if choose:FindFirstChild("Backpack") then
28game.ReplicatedStorage.Luger:Clone().Parent = choose.Backpack;
29 
30end
31    end
32    end
33    end
34end
35 end
36end
 View all 36 lines...

EDIT 2

It seems to be giving out a weapon per player, and sometimes gives someones weapon to another person

1 answer

Answered by

adark 5487

9 years ago

This on its own shouldn't be giving every Player a weapon, although it can be optimized slightly:

1local choose = game.Players:GetPlayers()[math.random(game.Players.NumPlayers)]
2 
3if choose:FindFirstChild("Backpack") then
4    game.ReplicatedStorage.Luger:Clone().Parent = chose.Backpack;
5end

First, let's fix your formatting and take a better look at your code:

01local players = game.Players:GetPlayers()
02local using = false
03 
04while true do --No need to be fancy.
05    wait(5)
06    using = false
07    if using == false then
08        using = true   
09        if (game.Players.NumPlayers <= 1) then -- This will be the less complicated 'invite more' part
10            using = true
11            game.StarterGui.gui.LocalScript.Event:Fire()
12        else --The `if` here covered the *entire* other case, so an `else` works just fine on its onw.
13            --For future reference, `elseif` is a valid branch. 
14            wait(5)
15 
16            target = CFrame.new(0, 50, 0) --could be near a brick or in a new area
17            for i, player in ipairs(game.Players:GetChildren()) do
18                --Make sure the character exists and its torso exists
19                if player.Character and player.Character:FindFirstChild("Torso") then
20                    --add an offset of 5 for each character
21                    player.Character.Torso.CFrame = target + Vector3.new(0, i * 5, 0)
22 
23                    wait()
24                end
25            end
26 
27            --This looks like the problem!
28            --Since you put this code inside of the `for` loop above, a random player will get the Luger for *every player in the game!*
29            --I moved some ends further up so that this is outside of the loop.
30            local choose = game.Players:GetPlayers()[math.random(game.Players.NumPlayers)]
31 
32            if choose:FindFirstChild("Backpack") then
33                game.ReplicatedStorage.Luger:Clone().Parent = choose.Backpack;
34            end
35        end
36    end
37end
 View all 37 lines...

no, ill give it all bubbaman73 143 — 9y

(im still working on it so it doesnt delete the weapons yet) bubbaman73 143 — 9y

Thanks! Im new to looping a lot at things at once bubbaman73 143 — 9y

Why is this giving everyone a weapon?

1 answer

Answer this question