Scripting Helpers is winding down operations and is now read-only. More info→

Why can't this script locate multiple enemies at a time?

Asked by

deputychicken 226

10 years ago

So this script is supposed to be something sort of like a mini-map, but for some reason it can't locate multiple enemies at a time, it only puts 1 enemy on the map at a time. Here it is:

01local _FindCharacter = script.Parent.Parent.Parent.Parent.Parent.Character
02function ClearMiniMap()
03    for i,v in pairs(script.Parent:GetChildren()) do
04        if v:IsA("Frame") and v.Name == "Enemy" or v.Name == "Neutral" or v.Name == "Friendly" then
05            v:Destroy()
06        end
07    end
08end
09function enemyDetected(pos)
10    local x = game.Workspace:children()
11    for i=1,#x do
12        local xlist = x[i]
13        if xlist.className == "Model" and xlist~= script.Parent then
14            local islarm = xlist:FindFirstChild("Left Arm")
15            local ishuman = xlist:FindFirstChild("Enemy")
16            if islarm ~=nil and ishuman~=nil then
17                if (xlist.Position - pos).magnitude<50 then
18                return xlist    
19                end
20            end
21        end
22 
23    end
24end
25 
26while wait(4) do
27    ClearMiniMap()
28    if _FindCharacter ~= nil then
29        local target = enemyDetected(_FindCharacter.Torso)
30        if target ~= nil then
31            if target.Detected == true then
32                local CopyEnemy = script.Parent.Storage.Enemy:Clone()
33                CopyEnemy.Parent = script.Parent
34                CopyEnemy.Position =(_FindCharacter.Torso.Position.x - target.Position.x), (_FindCharacter.Torso.Position.z - target.Position.z)
35            end
36        end
37    end
38end
 View all 38 lines...

1 answer

Answered by

adark 5487

10 years ago

Your enemyDetected only returns the first enemy it finds, not every single enemy visible!

To fix this, I made it return a Table of all matches, rather than the first match:

01local _FindCharacter = script.Parent.Parent.Parent.Parent.Parent.Character
02function ClearMiniMap()
03    for i,v in pairs(script.Parent:GetChildren()) do
04        if v:IsA("Frame") and v.Name == "Enemy" or v.Name == "Neutral" or v.Name == "Friendly" then
05            v:Destroy()
06        end
07    end
08end
09 
10function enemyDetected(pos)
11    local detected = {}
12 
13    for _, xlist in ipairs(workspace:GetChildren())
14        if xlist:IsA("Model") and xlist ~= script.Parent then --Directly accessing the className is not recommended.
15            local islarm = xlist:FindFirstChild("Left Arm")
16            local ishuman = xlist:FindFirstChild("Enemy")
17            local torso = xlist:FindFirstChild("Torso")
18            if torso and islarm and ishuman then --`~= nil` is never necessary.
19                If (torso.Position - pos).magnitude < 50 then --Models don't have a Position property!
20                    table.insert(detected, torso)  
21                end
22            end
23        end
24    end
25 
26    return detected
27end
28 
29while wait(4) do
30    ClearMiniMap()
31    if _FindCharacter ~= nil then
32        local targets = enemyDetected(_FindCharacter.Torso)
33        for _, target in ipairs(targets) do
34            if target ~= nil then
35                if target.Detected == true then
36                    local CopyEnemy = script.Parent.Storage.Enemy:Clone()
37                    CopyEnemy.Parent = script.Parent
38 
39            --I assume this is a GUI element?
40                    CopyEnemy.Position = UDim2.new(0, (_FindCharacter.Torso.Position.x - target.Position.x),
41                0, (_FindCharacter.Torso.Position.z - target.Position.z))
42                end
43            end
44        end
45    end
46end
 View all 46 lines...

Why can't this script locate multiple enemies at a time?

1 answer

Answer this question