Saving Script - Fails to save?

Asked by

10 years ago

I'm writing a script to save the leaderstats of a player when they leave. There are no errors, yet it still doesn't save for some reason. I have tried re-writing the code and searching google, But I couldn't find anything. Could I have some help with this?

This is my script :

01function saveScore(player, score)
02    player:SaveNumber("Gold", score)
03end
04 
05function saveLevel(player, score2)
06    player:SaveNumber("Lvl", score2)
07end
08 
09 
10function loadScore(player, killCounter)
11    local score = player:LoadNumber("Gold")
12 
13    if score ~= 0 then
14        killCounter.Value = score
15    else
16        print("Nothing to load/score was 0")
17    end
18 
19end
20 
21function loadLevel(player, killCounter2)
22    local score2 = player:LoadNumber("Lvl") 
23 
24    if score2 ~= 0 then
25        killCounter2.Value = score2
26    else
27        print("Nothing to load/score2 was 0")
28    end
29end
30 
31function onPlayerEntered(newPlayer)
32 
33        local stats = newPlayer:findFirstChild("leaderstats")
34 
35        if (stats ~= nil) then
36 
37        local clicks2 = stats:findFirstChild("Lvl")
38 
39        local clicks = stats:findFirstChild("Gold")
40 
41 
42 
43 
44 
45 
46        newPlayer:WaitForDataReady() 
47        loadScore(newPlayer, clicks)
48        loadLevel(newPlayer, clicks2)
49        end
50 
51end
52 
53function onPlayerRemoving(player)
54    print("Attempting to save score for " .. player.Name)
55    local stats = player:FindFirstChild("leaderstats")
56    if (stats ~= nil) then
57        local clicks = stats:FindFirstChild("Gold")
58        local clicks2 = stats:FindFirstChild("Lvl")
59        if (clicks ~= nil) then
60            saveScore(player, clicks.Value)
61        end
62        if (clicks2 ~= nil) then
63            saveLevel(player, clicks2.Value)
64        end
65    end
66end
67 
68game.Players.PlayerAdded:connect(onPlayerEntered)
69game.Players.PlayerRemoving:connect(onPlayerRemoving)
 View all 69 lines...

I cannot figure this out. Any help is appreciated, Thank you if you could help me out!

I would just really like to know what I've done wrong.

Accept my answer if it helped please! EzraNehemiah_TF2 3552 — 10y

What is the error, cause I knew there would be an error. EzraNehemiah_TF2 3552 — 10y

DataStores

DataStores is a way to save data, but It's better than Data Persistence. Link

1local data = game:GetService("DataStores")
2local save = data:GetDataStores("test")
3save:GetAsync("Bob") --Load
4save:SetAsync("Bob", 1337) --Save
5--When the datastores isn't saved to anything, when you load it, it returns nil!

Final Product

01local gold = game:GetService("DataStoreService"):GetDataStore("Gold") --Add I did was replace data persistence with datastores.
02local lvl = game:GetService("DataStoreService"):GetDataStore("lvl")
03 
04function saveScore(player, score)
05    gold:SetAsync(player.userId, score)
06end
07 
08function saveLevel(player, score)
09    lvl:SetAsync(player.userId, score)
10end
11 
12 
13function loadScore(player, killCounter)
14    local score = gold:GetAsync(player.userId)
15    if score ~= nil then
16        killCounter.Value = score
17    else
18        killCounter.Value = 0
19    gold:SetAsync(player.userId, 0)
20    end
21 
22end
23 
24function loadLevel(player, killCounter)
25    local score = lvl:GetAsync(player.userId)
26 
27    if score ~= nil then
28        killCounter.Value = score
29    else
30        lvl:SetAsync(player.userId, 0)
31    end
32end
33 
34function onPlayerEntered(newPlayer)
35 
36        local stats = newPlayer:findFirstChild("leaderstats")
37 
38        if (stats ~= nil) then
39 
40        local clicks2 = stats:findFirstChild("Lvl")
41 
42        local clicks = stats:findFirstChild("Gold")
43 
44        loadScore(newPlayer, clicks)
45    loadLevel(newPlayer, clicks2)
46        end
47 
48end
49 
50function onPlayerRemoving(player)
51    local stats = player:FindFirstChild("leaderstats")
52    if (stats ~= nil) then
53        local clicks = stats:FindFirstChild("Gold")
54        local clicks2 = stats:FindFirstChild("Lvl")
55        if (clicks ~= nil) then
56            saveScore(player, clicks.Value)
57        end
58        if (clicks2 ~= nil) then
59            saveLevel(player, clicks2.Value)
60        end
61    end
62end
63 
64game.Players.PlayerAdded:connect(onPlayerEntered)
65game.Players.PlayerRemoving:connect(onPlayerRemoving)
 View all 65 lines...

Hope it helps!

Saving Script - Fails to save?

1 answer

DataStores

Final Product

Answer this question