Scripting Helpers is winding down operations and is now read-only. More info→

How do I make this mute script work?

Asked by

docrobloxman52 407

10 years ago

I have tried to my best to try to fix this script. This is a mute script and I am trying to make it work. The mute part of the script works but when I try to press the text button again it doesn't do anything can you please help!

01`m = workspace.Sound.Volume
02 
03function Sound()
04    workspace.Sound.Volume = 0
05    print'No music'
06    script.Parent.TextLabel.Visible = true
07    end
08 
09script.Parent.MouseButton1Down:connect(Sound)
10 
11function offSound()
12    workspace.Sound.Volume = 0.8
13    print'music'
14    script.Parent.TextLabel.Visible = false
15 
16end
17 
18script.Parent.MouseButton1Down:connect(Sound)
19`

Shouldn't line 18 be script.Parent.MouseButton1Down:connect(offSound) UserOnly20Characters 890 — 10y

are you trying to toggle on and off? ImageLabel 1541 — 10y

Yes i am trying to toggle it on and off docrobloxman52 407 — 10y

I did it was already on loop docrobloxman52 407 — 10y

2 answers

Answered by

ImageLabel 1541

10 years ago

Problem

Your TextButton is connect to the function Sound, which from the looks of it only sets the volume of the sound object to 0. You are trying to have it toggled in correspondence with the click of the GuiObject the script in a child of.

Solution

Add a bool value that you will track, allowing you to execute a snippet of code when it's set to true, or false, depending on it's previous value.

01local button, sound, toggle, bool do
02    sound = workspace.Sound
03    button = script.Parent
04    bool = true
05    -- set variables equal to corresponding values
06 
07    toggle = function ()
08        if sound then
09            -- if sound and bool are existent
10            bool = not bool
11            --set bool to the opposite of it's current value
12            -- run code based on true or false
13 
14            if bool == false then
15                button.TextLabel.Visible = false
16                print(button:GetFullName(), 'off')
17                sound.Volume = 0;
18            elseif bool then
19                button.TextLabel.Visible = true
20                print(button:GetFullName(), 'on')
21                sound.Volume = 0.8;             
22            end        
23        end
24    end
25    -- connect the function to click of button (script.Parent)
26    button.MouseButton1Click:connect(toggle)
27end
 View all 27 lines...

@imagelabel this only turned in off... docrobloxman52 407 — 10y

I corrected the mistake, and reproduced it to ensure that it worked. ImageLabel 1541 — 10y

Answered by

NotsoPenguin 705

10 years ago

To toggle the volume you could just set the Volume to the opposite. If it is 0.8 set it to 0 else set it to 0.8.

The below could also be accomplished using an if statement.

1script.Parent.MouseButton1Down:connect(function()
2workspace.Sound.Volume = (workspace.Sound.Volume == 0.8 and 0) or 0.8
3script.Parent.TextLabel.Visible = not script.Parent.TextLabel.Visible
4end)

This only toggled the X I want to toggle the music as well docrobloxman52 407 — 10y

What? NotsoPenguin 705 — 10y

I'm not sure line 2 would work because the use of 'and' and 'or' return a bool value. (that's why they're so often used in if statements.) Perci1 4988 — 10y

@Perci1 The and and or operators do not always return bool values. The and operator returns the last argument or false. The or operator returns the first true argument or false. NotsoPenguin 705 — 10y

How do I make this mute script work?

2 answers

Problem

Solution

Answer this question