Scripting Helpers is winding down operations and is now read-only. More info→

Why isn't this script working?

Asked by

9 years ago

Please make your question title relevant to your question content. It should be a one-sentence summary in question form.

I made a hat that instead of having to touch the hat you have to click it, so i changed the script from an onTouch to an onClicked. But whenever i click on the hat i get the error "Bad Cast". Can anyone help me resolve this?

function onClicked(player)
    if player.Character:FindFirstChild("Humanoid") ~= nil and  player.Character:FindFirstChild("Helmet") == nil then
        local g = script.Parent.Parent.Helm:clone()
        g.Parent = player.Character
        local C = g:GetChildren()
        for i=1, #C do
            if C[i].className == "Part" or "Union" then
                local W = Instance.new("Weld")
                W.Part0 = g.Middle
                W.Part1 = C[i]
                local CJ = CFrame.new(g.Middle.Position)
                local C0 = g.Middle.CFrame:inverse()*CJ
                local C1 = C[i].CFrame:inverse()*CJ
                W.C0 = C0
                W.C1 = C1
                W.Parent = g.Middle
            end
                local Y = Instance.new("Weld")
                Y.Part0 = player.Character.Head
                Y.Part1 = g.Middle
                Y.C0 = CFrame.new(0, 0, 0)
                Y.Parent = Y.Part0
        end

        local h = g:GetChildren()
        for i = 1, # h do
            h[i].Anchored = false
            h[i].CanCollide = false
        end

    end
end
script.Parent.ClickDetector.MouseClick:connect(onClicked)

Check out the response on my answer. Redbullusa 1580 — 9y

1 answer

Answered by

Redbullusa 1580

9 years ago

Tab your code correctly! It will look more organized.

"Bad cast" occurs when ROBLOX functions or object are given something that it is not expecting.

The error I see so far that will stop your script from working is on line 7.

if C[i].className == "Part" or "Union" then

Let's break the code into pieces.

if | C[i].className == "Part" | or | "Union" | then

if
C[i].className == "Part"
or
"Union"
then

The 4th part of this code will create an error, because you're basically saying to the computer...

if "Union" then
-- It's basically saying...
if true then
-- Because "if" statements determine whether the condition is true or not
-- Now let's look at a line of your code
W.Part1 = C[i] -- Line 10
-- At this point, the weld's Part1 is set to the object that the "for" loop is indexing. Unfortunately, if the object is not a BasePart, then it will throw that "bad cast" error.

-- In short, that "bad cast" error happened due to the weld's Part1 set to something that it is not expecting (a "Part" object, for example)

So, if you want to include "UnionOperation" and "Part" objects as the welded parts, see if C[i] is equal to each of the strings.

if C[i].ClassName == "Part" or C[i].ClassName == "UnionOperation" then
-- "UnionOperation" is the actual term for Union objects

To type less for convenience, use the :IsA() method, and use "BasePart" as the argument, because it inherits both "Part" and "UnionOperation".

if C[i]:IsA("BasePart") then

-- Delete line 25
for i = 1, #C do
    if C[i]:IsA("BasePart") then
        C[i].Anchored = false
        C[i].CanCollide = false
    end
end

Your script seemed to have fixed the "Bad Cast" but now i'm getting a " Anchored is not a valid member of SpecialMesh". purplemetro3421 5 — 9y

Create the same "if" statement I discussed about for line 7. Or Replace "h" with "C" on line 26. Redbullusa 1580 — 9y

Now that i have changed the "h" with the "c" on line 26 does that mean that i also have to change the "i" inside the h[i]? purplemetro3421 5 — 9y

No, but you have to change the "h" in each of the "h[i]", resulting "C[i]" for lines 27 and 28. Redbullusa 1580 — 9y

View all comments (3 more)

:( now it went back to " Anchored is not a valid member of SpecialMesh". I'm so sirree if it looks as if i don't understand this. It's because im actually fairly new to scripting purplemetro3421 5 — 9y

Wrap the code within the "for" loop (the one on line 26) with the "if" statement I mentioned in my answer; let me show you how. Redbullusa 1580 — 9y

That did the trick! but why isn't the script recognizing the click detector that i already have inside the Model it keeps saying that click detector is not part of the script". purplemetro3421 5 — 9y

Why isn't this script working?

1 answer

Answer this question