Scripting Helpers is winding down operations and is now read-only. More info→

Gun Purchase script is not working?

Asked by

10 years ago

01player = script.Parent.Parent.Parent.Parent.Parent
02cost = 500
03 
04function checkForColt()
05    found = false
06    for i, v in pairs(player.Backpack:GetChildren()) do
07        if v.Name == "Colt" then
08            found = true
09        end
10    end
11    for i, v in pairs(player.Charater:GetChildren()) do
12        if v.Name == "Colt" then
13            found = true
14        end
15    end
16    if found == true then
17        return true
18    else
19        return false
20    end
21 
22end
23 
24script.Parent.MouseButton1Click:connect(function()
25    leaderstats= player:FindFirstChild("leaderstats")
26    if leaderstats then
27        Money = leaderstats:FindFirstChild("Points")
28        if Money then
29            hasColt = checkForColt()
30            if Money.Value >= cost and hasColt == false then
31                Money.Value = Money.Value - cost
32                NewGun = game.Lighting.Colt:Clone()
33                NewGun.Parent = Money.Backpack
34            end
35        end
36 
37    end
38 
39end)
 View all 39 lines...

My leaderboard stats work fine, it out put's no errors and the colt is correctly labeled. 10+ cookiez to the guy the works it out.

Try using two variables instead of just one called found. It can be overwritten by the second do loop which could cause the checking for Colt to not go as planned. Also, I believe you might be using your function checkForColt() wrong by making it a variable. Instead on line 29, just call the function by doing only `checkForColt()` . Then on line 30, after "and", check your *two* new variables. alphawolvess 1784 — 10y

2 answers

Answered by

davness 376

10 years ago

You comitted several errors:

01player = game.Players.LocalPlayer -- LocalPlayer, LocalScript!
02cost = 500
03 
04function checkForColt()
05    found = false
06    for i, v in pairs(player.Backpack:GetChildren()) do
07        if v.Name == "Colt" then
08            found = true
09        end
10    end
11    for i, v in pairs(player.Charater:GetChildren()) do
12        if v.Name == "Colt" then
13            found = true
14        end
15    end
16    if found then -- You should not put "Condition" == bool
17        return true
18    else
19        return false
20    end
21 
22end
23 
24script.Parent.MouseButton1Click:connect(function()
25    leaderstats= player:FindFirstChild("leaderstats")
26    if leaderstats then
27        Money = leaderstats:FindFirstChild("Points")
28        if Money then
29            hasColt = checkForColt()
30            if Money.Value >= cost and not hasColt then -- if you want to do a thing when a condition is false, use not.
31                Money.Value = Money.Value - cost
32                NewGun = game.ServerStorage.Colt:Clone() -- Why did you put the gun on Lighting???? Put it on ServerStorage - it's for that it exists.
33                NewGun.Parent = game.Players.LocalPlayer.Backpack -- LocalPlayer, local script.
34            end
35        end
36 
37    end
38 
39end)
 View all 39 lines...

Well, i'm not a proscripter. But try to put it inside a LocalScript instead of a normal one (I guess you used the normal one) - Do not get mad if it do not work. I tryed at least.

If it's in a GUI, it should be a LocalScript. Also, LocalScripts don't work for ServerStorage, but they do work for ReplicatedStrorage. alphawolvess 1784 — 10y

I have just noticed in the leaderstats I have money rather than points XD WolfgangVonPrinz 0 — 10y

Wolfgang, i need the hierachy of the game where the script is davness 376 — 10y

Answered by

WolfgangVonPrinz 0

10 years ago

01player = game.Players.LocalPlayer
02 
03cost = 500
04 
05 
06 
07function checkForColt()
08 
09    found = false
10 
11    for i, v in pairs(player.Backpack:GetChildren()) do
12 
13        if v.Name == "Colt" then
14 
15            found = true
16 
17        end
18 
19    end
20 
21    for i, v in pairs(player.Charater:GetChildren()) do
22 
23        if v.Name == "Colt" then
24 
25            found = true
26 
27        end
28 
29    end
30 
31    if found then
32 
33        return true
34 
35    else
36 
37        return false
38 
39    end
40 
41 
42 
43end
44 
45 
46script.Parent.MouseButton1Click:connect(function()
47 
48    leaderstats= player:FindFirstChild("leaderstats")
49 
50    if leaderstats then
51 
52        Money = leaderstats:FindFirstChild("Money")
53 
54        if Money then
55 
56            hasColt = checkForColt()
57 
58            if Money.Value >= cost and not hasColt then
59                Money.Value = Money.Value - cost
60             NewGun = game.ReplicatedStorage.Colt:Clone() 
61 
62                NewGun.Parent = game.Players.LocalPlayer.Backpack -- LocalPlayer, local script.
63          end
64 
65        end
66 
67    end
68 
69end)
 View all 69 lines...

So, I've re-written, but it read's errors I don't know how to solve.

"Charater is not a valid member of player." I tried Humanoid too, but no luck. Those cookies are still up for grabs!

Gun Purchase script is not working?

2 answers

Answer this question