Camera Manipulation with Filtering?

Asked by

10 years ago

Why doesn't this code work with FilteringEnabled? It works when you join the game, then when you die and respawn, it doesn't work anymore.

01repeat wait() until game:GetService("Players").LocalPlayer
02 
03local Player = game:GetService("Players").LocalPlayer
04local Character = Player.Character or Player.CharacterAdded:wait()
05local ReplicatedStorage = game:GetService("ReplicatedStorage")
06local Timer = ReplicatedStorage:WaitForChild("Timer")
07local MapHolder = workspace:WaitForChild("MapHolder")
08local SelectedMap = ReplicatedStorage:WaitForChild("SelectedMap")
09local Playing = Player:WaitForChild("Playing")
10 
11local CurrentCamera = workspace.CurrentCamera
12 
13Angle = 0
14while wait() do
15    if Timer.Value > 0 and Playing.Value == false and Character:FindFirstChild("Humanoid") and Character:FindFirstChild("Humanoid").Health > 0 then
16        CurrentCamera.CameraSubject = MapHolder:FindFirstChild(SelectedMap.Value):FindFirstChild("PartCAM")
17        CurrentCamera.CoordinateFrame = CFrame.new(MapHolder:FindFirstChild(SelectedMap.Value):FindFirstChild("PartCAM").Position) * CFrame.Angles(0, Angle, 0) * CFrame.new(0, 0, -25)
18    elseif Timer.Value < 0 and Playing.Value == false and Character:FindFirstChild("Humanoid") and Character:FindFirstChild("Humanoid").Health > 0 then
19        CurrentCamera.CoordinateFrame = CFrame.new(workspace.Scene:FindFirstChild("PartCAM").Position) * CFrame.Angles(0, Angle, 0) * CFrame.new(0, 0, -10)
20        CurrentCamera.CameraSubject = workspace.Scene:FindFirstChild("PartCAM")
21    elseif Timer.Value > 0 and Playing.Value == true and Character:FindFirstChild("Humanoid") and Character:FindFirstChild("Humanoid").Health > 0 then
22        CurrentCamera.CameraSubject = Character:FindFirstChild("Humanoid")
23    end
24    Angle = Angle + math.rad(0.5)
25end
 View all 25 lines...

So hard to read....Consider using more variables.... NotsoPenguin 705 — 10y

So this helps me with my issue.. how? peoplemove12 148 — 10y

It helps with legibility. You have a lot of repeated code. ex, instead of having 'Character:FindFirstChild("Humanoid")' 7 times, just have it once between lines 14 and 15 as 'local humanoid = Character:FindFirstChild("Humanoid")' and 'if humanoid and humanoid.Health > 0 then --[[lines 15-23 here]] end". Same idea with PartCAM. Also, this script doesn't manage the player respawning; what does? chess123mate 5873 — 10y

Camera Manipulation with Filtering?

Answer this question