Scripting Helpers is winding down operations and is now read-only. More info→

I can't work out what's wrong?

Asked by

JJ_B 250

10 years ago

I created this lengthy (and quite messy) LOCAL script for a shuttle craft. It makes a sound to simulate takeoff, and changes a decal in front of the window every so often to show it's moving. Then it grabs another shuttle from ReplicatedStorage and teleports you to a brick at the new shuttle. I tried putting it in a regular script, to find that this only works in studio. Here is the code:

01repeat wait() until game.Players.LocalPlayer
02char = game.Players.LocalPlayer.Character
03destination = game.Workspace.planshut
04 
05function onClick()
06    script.Parent.Sound:Play()
07    wait(6)
08    script.Parent.Parent.view.Transparency = 0 -- view space
09    wait(1)
10    script.Parent.Parent.view.Decal.Transparency = 0
11    script.Parent.Parent.view.Decal.Texture = "http://www.roblox.com/asset?id=244339877" --view planet
12    wait(1)
13    script.Parent.Parent.view.Decal.Texture = "http://www.roblox.com/asset?id=244339507" -- closer view
14    wait(1)
15    script.Parent.Parent.view.Decal.Texture = "http://www.roblox.com/asset?id=244339544" -- surface view
16    wait(1)
17    local s = game.ReplicatedStorage.planetshut:clone()
18    s.Parent = game.Workspace -- make shuttle on planet
19    if script.Parent.Parent.Door.Transparency == 0 then
20        s.Door.Transparency = 0
21        s.Door.CanCollide = true
22    else
23        s.Door.Transparency = 1
24        s.Door.CanCollide = false
25    end --if door is open, open door on planet shuttle
26    char.Torso.Anchored = true
27    char.Torso.CFrame = destination.CFrame + Vector3.new(0,4,0)
28    wait(0.2)
29    char.Torso.Anchored = false --teleport player to planet shuttle
30    script.Parent.Parent:Destroy() --destroy this shuttle
31end
32 
33script.Parent.ClickDetector.MouseClick:connect(onClick)
 View all 33 lines...

I can't work out what is wrong! It won't do anything, the output won't tell me anything at all either. Help?

1 answer

Answered by

Perci1 4988

10 years ago

When using LocalScripts, remember that LocalPlayer will always exist. No need to wait for it. You do, however, often need to wait for the character.

1local plr = game.Players.LocalPlayer
2    repeat wait() until plr.Character
3local chr = plr.Character

However, LocalScripts only run in PlayerGui or Backpack. They don't run in parts. So you must use a server Script.

But LocalPlayer only works in LocalScripts, so what do you do? Well it turns out that MouseClick events have a built in parameter equal to the Player who clicked. You can use that.

1function sayHi( plr )
2    print(plr.Name.." says hi!")
3end
4script.Parent.ClickDetector.MouseClick:connect( sayHi )

On a side note, you should really define some variables instead of using those long paths over and over.

I changed the script according to this, and the output tells me "Torso is not a valid member of Player" JJ_B 250 — 10y

Like I said, the parameter is equal to the PLAYER who clicked it. It's NOT equal to a Character. You therefore need to use the Player's Character *property*, e.g., plr.Character Perci1 4988 — 10y

I can't work out what's wrong?

1 answer

Answer this question