Scripting Helpers is winding down operations and is now read-only. More info→

User input script refuses to work?

Asked by

yoshiegg6 176

10 years ago

Please, if anyone knows how to fix this please help. I've been debugging this for weeks.

This is in a local script in a tool and it doesn't work. It's supposed to clone a model from replicated storage to right in front of your character when you press r and it uses mouse key down. There is no output but it still doesn't work. Can anyone help me?

01--Normal variables
02local Player = game.Players.LocalPlayer
03local char = Player.Character
04local Mouse = Player:GetMouse()
05local debounce = false
06--Animation setup
07local A = Instance.new("Animation")
08A.AnimationId = "http://www.roblox.com/Asset?ID=211592172"
09local track = char.Humanoid:LoadAnimation(A)
10 
11function firewall(key)
12if key == "r" and not debounce and script.Parent.Equipped == true then
13local CF = game.ReplicatedStorage.FireWall:Clone()
14CF.Parent = workspace
15CF.MainPart.Position = char.Torso.Position + Vector3.new(5,0,0)
16CF.Rotation = char.Torso.Rotation --Edit: I capitalised the f in CF here
17track:Play()
18debounce = true
19wait(3)
20debounce = false
21end
22end
23 
24Mouse.KeyDown:connect(firewall)
 View all 24 lines...

Please, if you can fix this I will upvote every single thing you've posted.

Edit: Followed europes advice, I'm going to test it.

line 13 just remove the .Parent = game.Workspace, cause you already have "=" in your variable. woodengop 1134 — 10y

just place it somewhere else, like below the Variable CF. woodengop 1134 — 10y

I did, thank you. yoshiegg6 176 — 10y

Worked? woodengop 1134 — 10y

View all comments (5 more)

I can't test it at school roblox is blocked. yoshiegg6 176 — 10y

xD, kk woodengop 1134 — 10y

Made a tiny edit yoshiegg6 176 — 10y

did it work? woodengop 1134 — 10y

Nope. I think I'm going to put this project to rest. It obviously doesn't want to work. yoshiegg6 176 — 10y

1 answer

Answered by

Redbullusa 1580

9 years ago

Indent your code in a more professional manner. People will take you as an organized scripter!
Since you're using the .KeyDown event, lower the key, so your key wouldn't be read as a capital "R," else the function will not run.
Wait for the character (just in case if it is nil)!

01--Normal variables
02local Player = game.Players.LocalPlayer
03local Character = Player.Character or Player.CharacterAdded:wait()
04local Humanoid = Character:WaitForChild("Humanoid")
05local Mouse = Player:GetMouse()
06local debounce = false
07--Animation setup
08local Anim = Instance.new("Animation")
09Anim.AnimationId = "http://www.roblox.com/asset/?id=211592172"
10local AnimTrack = Humanoid:LoadAnimation(Anim)
11 
12function firewall(key)
13    if key:lower() == "r" and not debounce and script.Parent.Equipped then
14        debounce = true
15        local CF = game.ReplicatedStorage.FireWall:Clone()
16        CF.Parent = workspace
17        --[[ Give CFrame a try!
18        CF.MainPart.Position = char.Torso.Position + Vector3.new(5,0,0)
19        CF.Rotation = Character.Torso.Rotation
20        --]]
21        CF:SetPrimaryPartCFrame(Character.Torso.CFrame * CFrame.new(0, 0, -5))
22        -- I believe it is the Z-axis is what you want.
23        AnimTrack:Play()
24        wait(3)
25        debounce = false
26    end
27end
28 
29Mouse.KeyDown:connect(firewall)
 View all 29 lines...

I would like to introduce you to the UserInputService.. It's pretty cool. It is way more compatible with other devices than the deprecated .KeyDown event.

01-- The UserInputService Version
02--Normal variables
03local Player = game.Players.LocalPlayer
04local Character = Player.Character or Player.CharacterAdded:wait()
05local Humanoid = Character:WaitForChild("Humanoid")
06local Mouse = Player:GetMouse()
07local debounce = false
08--Animation setup
09local Anim = Instance.new("Animation")
10Anim.AnimationId = "http://www.roblox.com/asset/?id=211592172"
11local AnimTrack = Humanoid:LoadAnimation(Anim)
12 
13UIS = game:GetService("UserInputService")
14 
15function firewall(InputObject)
16    if InputObject.KeyCode == Enum.KeyCode.R and not debounce and script.Parent.Equipped then
17        debounce = true
18        local CF = game.ReplicatedStorage.FireWall:Clone()
19    CF.Parent = workspace
20        --[[
21        CF.MainPart.Position = char.Torso.Position + Vector3.new(5,0,0)
22        CF.Rotation = Character.Torso.Rotation
23        --]]
24        CF:SetPrimaryPartCFrame(Character.Torso.CFrame * CFrame.new(0, 0, -5))
25        AnimTrack:Play()
26        wait(3)
27        debounce = false
28    end
29end
30 
31UIS.InputBegan:connect(firewall)
 View all 31 lines...

User input script refuses to work?

1 answer

Answer this question