Scripting Helpers is winding down operations and is now read-only. More info→

Pairs in game loop won't access all player's Guis. Help?

Asked by

10 years ago

I am having issues, Whenever I try to run my Game script (indev), I try to access all the GUIs of the player's through pairs, yet it only accesses 1 player Gui. Can Someone help?

Here's the code Snippet:

01--[[QuakeScape MainScript]]--
02--=[[All people who See this script other than FOXmcloud021 or Steal this Script will be taxed...]]=--
03--With their life...--
04local LSounds = game.Lighting.LoseSounds:GetChildren()
05local WSounds = game.Lighting.WinSounds:GetChildren()
06local Maps = game.Lighting.Maps:GetChildren()
07 
08while wait(5) do
09    if game.Players.NumPlayers > 1 then
10        for i,v in pairs(game.Players:GetChildren())do
11            v.PlayerGui.TopBar.Frame.Visible = true
12            v.PlayerGui.TopBar.Frame.TextLabel.Text = "Intermission..."
13            wait(15)
14            v.PlayerGui.TopBar.Frame.TextLabel.Text = "Choosing Map..."
15            wait(10)
16        end
17        local MapChoose = math.random(1, #Maps)
18        local MapChosen = Maps[MapChoose]
19        for i,v in pairs (game.Players:GetChildren()) do
20            v.PlayerGui.TopBar.Frame.TextLabel.Text = "Map Found!"
21            wait(5)
22            v.PlayerGui.TopBar.Frame.TextLabel.Text = "Loading map..."
23            for i = 1,1,100 do
24                v.PlayerGui.TopBar.Frame.TextLabel.Text ="Loading map... "..i.."%"
25                wait(.15)
26            end
27            v.PlayerGui.TopBar.Frame.TextLabel.Text = "Map Loaded!"
28        end
29        MapChosenClone = MapChosen:Clone(game.Workspace)
30    else
31        for i,v in pairs(game.Players:GetChildren())do
32            v.PlayerGui.TopBar.Frame.Visible = true
33            v.PlayerGui.TopBar.Frame.TextLabel.Text = "There must be Another Player in order to Play this Game"
34        end
35    end
36end
 View all 36 lines...

2 answers

Answered by

M39a9am3R 3210

10 years ago

I am highly assuming you are running this in a Server Side script, under Workspace or ServerScriptService. The reason it is not looping to all player's ScreenGuis is because of this wait() functions. Seriously, that's the problem. I know this because I have tried making a admin script and a laser tag game looping through all players using the same method presented. The way you can have the script loop through all players at once while not removing the waits if a technique called coroutines. Coroutines basically makes lines of code in a function to run almost like a separate script is being used (that's my best explanation of it). For your script you will want to use the following code:

1coroutine.resume(coroutine.create(function() --coroutines are kind of functions themselves, so at the end of resume and create, add a "(" and then create a function, hence "function()". You can then add code to the next line.
2--Code Here
3end)) --You end the function, then you close the coroutine.create parenthesis and coroutine.resume parenthesis.

With coroutines, the wait time will do the wait for that player only. It is a useful technique especially if you know your script may break, due to a person leaving or something along those lines, the coroutine will break but the entire script will not. Though, caution when using coroutines because any errors will be hidden from the developer console.

As a final output your script should look like this when looping through players.

01--[[QuakeScape MainScript]]--
02--=[[All people who See this script other than FOXmcloud021 or Steal this Script will be taxed...]]=--
03--With their life...--
04local LSounds = game.Lighting.LoseSounds:GetChildren()
05local WSounds = game.Lighting.WinSounds:GetChildren()
06local Maps = game.Lighting.Maps:GetChildren()
07 
08while wait(5) do
09    if game.Players.NumPlayers > 1 then
10        for i,v in pairs(game.Players:GetChildren()) do
11            coroutine.resume(coroutine.create(function() --You can only resume a created coroutine, that's why it creates one in the parenthesis.
12            v.PlayerGui.TopBar.Frame.Visible = true
13            v.PlayerGui.TopBar.Frame.TextLabel.Text = "Intermission..."
14            wait(15)
15            v.PlayerGui.TopBar.Frame.TextLabel.Text = "Choosing Map..."
16            end)) --End the function and coroutines.
17        end
18        wait(25) --I moved this wait and added time to it because the coroutine is basically a separate script and will not make the script wait to choose a map. Change if you need to.
19        local MapChoose = math.random(1, #Maps)
20        local MapChosen = Maps[MapChoose]
21        for i,v in pairs (game.Players:GetChildren()) do
22            coroutine.resume(coroutine.create(function() --And another coroutine was made!
23            v.PlayerGui.TopBar.Frame.TextLabel.Text = "Map Found!"
24            wait(5)
25            v.PlayerGui.TopBar.Frame.TextLabel.Text = "Loading map..."
26            for i = 1,1,100 do
27                v.PlayerGui.TopBar.Frame.TextLabel.Text ="Loading map... "..i.."%"
28                wait(.15)
29            end
30            v.PlayerGui.TopBar.Frame.TextLabel.Text = "Map Loaded!"
31            end)) --End the function and coroutines.
32        end
33        MapChosenClone = MapChosen:Clone(game.Workspace)
34    else
35        for i,v in pairs(game.Players:GetChildren()) do
36            --You will not need a coroutine here since it will be virtually simultaneous. But you actually may want to add a WaitForChild function for protection though.
37            v:WaitForChild("PlayerGui").TopBar.Frame.Visible = true
38            v:WaitForChild("PlayerGui").TopBar.Frame.TextLabel.Text = "There must be Another Player in order to Play this Game"
39        end
40    end
41end
 View all 41 lines...

Some people may complain that coroutine.wrap() is more efficient, but I don't use it since I have not had much luck with it. Though I have seen coroutine.wrap() go coroutine.wrap(function --Code end)() in another script, which I haven't tried yet but will intend on doing.

Hopefully this answer helped and explained what coroutines are a bit, and hope that they help in the long run. If you need a further explanation to coroutines, checkout this wiki article.

Thank You So much! This fixed everything, great thanks! I gave you credit in the mainscript for helping me :) FOXmcloud021 5 — 10y

It'd be nice if the answer were approved, but I guess that works too... M39a9am3R 3210 — 10y

Answered by

Diitto 230

10 years ago

Are you running this in a LocalScript? If so, then the reason why is that LocalScripts can only access the client's PlayerGui. Else if there is an error of joining players, try using Player:waitForChild'PlayerGui'.

I am 99% sure he is not using a LocalScript. The problem is that the script is not looping through all players simultaneously. M39a9am3R 3210 — 10y

Well then, all he needs to do is set the thread scheduler to run the code once it reprocesses it's contents, using either coroutines, spawn, or delay with 0 as the first argument. Diitto 230 — 10y

Pairs in game loop won't access all player's Guis. Help?

2 answers

Answer this question