Help with my spectator script?

Asked by
10 years ago
I have this spectator script that I made, but it is not very efficient, and I would like to improve it. How can I make it so instead of me subtracting numbers, it moves down the table as you click?
001repeat wait() until game.Players.LocalPlayer.Character
002 
003local frame = script.Parent:WaitForChild('Frame')
004local sub = frame:WaitForChild('Subtract')
005local add = frame:WaitForChild('Add')
006local name = frame:WaitForChild('Name')
007local spectating = script.Parent:WaitForChild('SpectatingV')
008local specButton = frame:WaitForChild('Spectating')
009local fixSpecB = frame:WaitForChild('FixSpectate')
010local db = false
011local playerNO = 1
012local players = game.Players:GetChildren()
013if spectating.Value then
014    specButton.Text = 'Spectating: Yes'
015elseif not spectating.Value then
016    specButton.Text = 'Spectating: No'
017end
018 
019 
020local addF = coroutine.wrap(function()
021    add.MouseButton1Click:connect(function()
022        if not db then
023            db = true
024            if playerNO < #players and #players > playerNO then
025                playerNO = playerNO + 1
026            elseif #players == playerNO then
027                --playerNO = playerNO - 1
028            else
029                print('no')
030            end
031            if spectating.Value then
032                game.workspace.CurrentCamera.CameraType = 'Custom'
033                game.Workspace.CurrentCamera.CameraSubject = game.workspace:FindFirstChild(players[playerNO].Name):FindFirstChild('Humanoid')
034                game.Players.LocalPlayer.CameraMode = Enum.CameraMode.Classic
035            end
036            db = false
037        end
038    end)
039end)
040local subF = coroutine.wrap(function()
041    sub.MouseButton1Click:connect(function()
042        if not db then
043            db = true
044            if playerNO < #players and #players > playerNO then
045                playerNO = playerNO - 1
046            elseif playerNO == #players then
047                playerNO = playerNO - 1
048            else
049                print('no')
050            end
051            if spectating.Value then
052                game.workspace.CurrentCamera.CameraType = 'Custom'
053                game.workspace.CurrentCamera.CameraSubject = game.workspace:FindFirstChild(players[playerNO].Name):FindFirstChild('Humanoid')
054                game.Players.LocalPlayer.CameraMode = Enum.CameraMode.Classic
055            end
056            db = false
057        end
058    end)
059end)
060local fixSpec = coroutine.wrap(function()
061    fixSpecB.MouseButton1Click:connect(function()
062        playerNO = 1
063    end)
064end)
065local specB = coroutine.wrap(function()
066    specButton.MouseButton1Click:connect(function()
067        if spectating.Value then
068            spectating.Value = false
069            specButton.Text = 'Spectating: No'
070            game.workspace.CurrentCamera.CameraType = 'Custom'
071            game.workspace.CurrentCamera.CameraSubject = game.Players.LocalPlayer.Character.Humanoid
072            game.Players.LocalPlayer.CameraMode = Enum.CameraMode.Classic
073        elseif not spectating.Value then
074            spectating.Value = true
075            specButton.Text = 'Spectating: Yes'
076            game.workspace.CurrentCamera.CameraType = 'Custom'
077            game.workspace.CurrentCamera.CameraSubject = game.workspace:FindFirstChild(players[playerNO].Name):FindFirstChild('Humanoid')
078            game.Players.LocalPlayer.CameraMode = Enum.CameraMode.Classic
079        end
080    end)
081end)
082local doSpec = coroutine.wrap(function()
083    while wait() do
084        if spectating.Value then
085 
086        elseif not spectating.Value then
087 
088        end
089    end
090end)
091local writeName = coroutine.wrap(function()
092    while wait() do
093        if playerNO == 0 then
094            playerNO = playerNO + 1
095        end
096        players = game.Players:GetChildren()
097    --  if players[playerNO].Name == game.Players.LocalPlayer.Character.Name then
098        --  table.remove(players, playerNO)
099        --end
100        print(playerNO)
101        name.Text = players[playerNO].Name
102    end
103end)
104addF()
105subF()
106specB()
107doSpec()
108writeName()
 View all 108 lines...
Help with my spectator script?

Answer this question
