Scripting Helpers is winding down operations and is now read-only. More info→

How can I properly optimize this GUI fade script?

Asked by

2 years ago

Hi y'all! I've been working on this piece of code that will slowly fade a given UI's transparency. I'm just wondering if there is anything I can do to improve it. Any help or tips would be greatly appreciated.

01local Bindable_Function = script:WaitForChild("Fade_Function")
02 
03function Fade(UI, Fade_Speed, Fade_To)
04 
05    -- Check if it is a Frame
06    if UI:IsA("Frame") then
07        if Fade_To < UI.Transparency then
08            while UI.Transparency >= Fade_To do
09                UI.Transparency -= Fade_Speed
10                wait(0.01)
11            end
12        else
13            while UI.Transparency <= Fade_To do
14                UI.Transparency += Fade_Speed
15                wait(0.01)
16            end
17        end
18    end
19 
20    -- Check if it is an Image
21    if UI:IsA("ImageLabel") then
22        if Fade_To < UI.ImageTransparency then
23            while UI.ImageTransparency >= Fade_To do
24                UI.ImageTransparency -= Fade_Speed
25                wait(0.01)
26            end
27        else
28            while UI.ImageTransparency <= Fade_To do
29                UI.ImageTransparency += Fade_Speed
30                wait(0.01)
31            end
32        end
33    end
34 
35    -- Check if it is a text label or button
36    if UI:IsA("TextLabel") or UI:IsA("TextButton") then
37        if Fade_To < UI.TextTransparency then
38            while UI.TextTransparency >= Fade_To do
39                UI.TextTransparency -= Fade_Speed
40                wait(0.01)
41            end
42        else
43            while UI.TextTransparency <= Fade_To do
44                UI.TextTransparency += Fade_Speed
45                wait(0.01)
46            end
47        end
48    end
49end
50 
51local function Fade_UI(UI, Fade_Speed, Fade_To, Fade_Children, Fade_Parent)
52 
53    -- Check if we want to fade the given UI
54    if Fade_Parent then
55        coroutine.wrap(Fade)(UI, Fade_Speed, Fade_To)
56    end
57 
58    -- Check if we want to fade the children
59    if Fade_Children == true then
60        for _, child in UI:GetChildren() do
61            coroutine.wrap(Fade)(child, Fade_Speed, Fade_To)
62        end
63    end
64end
65 
66Bindable_Function.OnInvoke = Fade_UI
 View all 66 lines...

Does it work? T3_MasterGamer 2189 — 2y

1 answer

Answered by

sergeant_ranger 184

2 years ago

Use Tweens, and combine your functions. In my code, Fade_Speed describes the number of seconds to fully fade. New code with tweenservice instead of loops, and some functions simplified:

01local tweenService = game:GetService("TweenService")
02 
03local Bindable_Function = script:WaitForChild("Fade_Function")
04 
05function Generate_And_Play_Tween(UI, Tween_Properties, Fade_Speed)
06    local tweenInfo = TweenInfo.new(Fade_Speed)
07    local tween = tweenService:Create(UI, tweenInfo, Tween_Properties)
08    tween:Play()
09end
10 
11function Fade(UI, Fade_Speed, Fade_To)
12 
13    -- Check if it is a Frame
14    if UI:IsA("Frame") then
15        local Tween_Properties = {Transparency = Fade_To}
16        Generate_And_Play_Tween(UI, Tween_Properties, Fade_Speed)
17    end
18 
19    -- Check if it is an Image
20    if UI:IsA("ImageLabel") then
21        local Tween_Properties = {ImageTransparency = Fade_To}
22        Generate_And_Play_Tween(UI, Tween_Properties, Fade_Speed)
23    end
24 
25    -- Check if it is a text label or button
26    if UI:IsA("TextLabel") or UI:IsA("TextButton") then
27        local Tween_Properties = {TextTransparency = Fade_To}
28        Generate_And_Play_Tween(UI, Tween_Properties, Fade_Speed)
29    end
30end
31 
32local function Fade_UI(UI, Fade_Speed, Fade_To, Fade_Children, Fade_Parent)
33 
34    -- Check if we want to fade the given UI
35    if Fade_Parent then
36        coroutine.wrap(Fade)(UI, Fade_Speed, Fade_To)
37    end
38 
39    -- Check if we want to fade the children
40    if Fade_Children == true then
41        for _, child in UI:GetChildren() do
42            coroutine.wrap(Fade)(child, Fade_Speed, Fade_To)
43        end
44    end
45end
46 
47Bindable_Function.OnInvoke = Fade_UI
 View all 47 lines...

Thanks! I'll be sure to try this out! Boomboyag 14 — 2y

How can I properly optimize this GUI fade script?

1 answer

Answer this question