Scripting Helpers is winding down operations and is now read-only. More info→

My DataStore Is Not Working To Save Players Leaderstats Any Way To Fix This?

Asked by

2 years ago

So im having trouble with saving players leaderstats and im kind of new to datastores and note I was watching thedevkings video so idk what I did wrong.

01local plr = game:GetService("Players")
02local DSS = game:GetService("DataStoreService")
03local MyData = DSS:GetDataStore("MyData1") -- gets a data store and you can name it
04--- plr name
05plr.PlayerAdded:Connect(function(player)
06    print(player.Name)
07    local text = game.StarterGui.ScreenGui.TextLabel
08    text.Text = player.Name
09    --- leaderstats
10    local leaderstats = Instance.new("Folder")
11    leaderstats.Name = "leaderstats"
12    leaderstats.Parent = player
13    local Coins = Instance.new("IntValue")
14    Coins.Name = "Coins"
15    Coins.Parent = leaderstats
16    Coins.Value = 100
17    while true  do
18        task.wait(5)
19        Coins.Value = Coins.Value + 1
20    end
21    -- datastore
22    local PlrId = "Player_"..player.UserId
23-- syncs player data from datastore GetAsync()
24    local data1
25    local success, errormessage = pcall(function() -- pcall stops errors
26       data1 = MyData:GetAsync(PlrId) 
27    end)
28    if success then
29        -- set our data to our coin value
30        Coins.Value = data1
31    end
32    plr.PlayerRemoving:Connect(function(player)
33        local PlrId = "Player_"..player.UserId
34        local plrdata = plr:WaitForChild(leaderstats)
35        local success, errormessage = pcall(function()
36            MyData:SetAsync(PlrId, plrdata)
37        end)
38        if success then
39            print("SUCCESS")
40        else
41            print("not good")
42            warn(errormessage)
43        end
44    end)
45end)
 View all 45 lines...

Just wanted to add that the `while true do` loop in your script completely stops the rest of the script from executing. DindinYT37 246 — 2y

1 answer

Answered by

T3_MasterGamer 2189

2 years ago

Edited 2 years ago

There's a lot of problems in your script that I'm too lazy to list all. Here's the script, just observe this script and the previous one to learn your mistakes.

01local plr = game:GetService("Players")
02local DSS = game:GetService("DataStoreService")
03local MyData = DSS:GetDataStore("MyData1") -- gets a data store and you can name it
04local RunService = game:GetService("RunService")
05 
06local function waitForRequestBudget(requestType: Enum.DataStoreRequestType)
07    local currentBudget = DataStoreService:GetRequestBudgetForRequestType(requestType)
08 
09    while currentBudget < 1 do
10        currentBudget = DataStoreService:GetRequestBudgetForRequestType(requestType)
11        task.wait(5)
12    end
13end
14 
15function loadData(player)
16    print(player.Name)
17    local text = player:WaitForChild("PlayerGui"):WaitForChild("ScreenGui").TextLabel
18    text.Text = player.Name
19    --- leaderstats
20    local leaderstats = Instance.new("Folder")
21    leaderstats.Name = "leaderstats"
22    leaderstats.Parent = player
23    local Coins = Instance.new("IntValue")
24    Coins.Name = "Coins"
25    Coins.Parent = leaderstats
26    Coins.Value = 100
27    -- datastore
28    local PlrId = "Player_"..player.UserId
29    -- syncs player data from datastore GetAsync()
30    wait
31    waitForRequestBudgetType(Enum.DataStoreRequestType.GetAsync)
32    local success, data1 = pcall(function() -- pcall stops errors
33        return MyData:GetAsync(PlrId) 
34    end)
35    if success then
36        -- set our data to our coin value
37        Coins.Value = data1
38    else
39        warn(data1)
40    end
41 
42    task.spawn(function()
43        while true do
44            task.wait(5)
45            Coins.Value += 1
46        end
47    end)
48end
49 
50function saveData(player, dontWait)
51    local PlrId = "Player_"..player.UserId
52    local plrdata = plr:WaitForChild("leaderstats"):WaitForChild("Coins").Value
53    local success
54    repeat
55        if not dontWait then
56            waitForRequestBudgetType(Enum.DataStoreRequestType.SetAsync)
57        end
58        success = pcall(function()
59            MyData:SetAsync(PlrId, plrdata)
60        end)
61    until success
62end
63 
64for _, player in ipairs(plr:GetPlayers()) do
65    task.spawn(loadData, player)
66end
67 
68plr.PlayerAdded:Connect(loadData)
69plr.PlayerRemoving:Connect(saveData)
70game:BindToClose(function()
71    if RunService:IsStudio() then
72        task.wait(2)
73    else
74        local finished = Instance.new("BindableEvent")
75        local allPlayers = Players:GetPlayers()
76        local leftPlayers = #allPlayers
77 
78        for _,player in ipairs(allPlayers) do
79            task.spawn(function()
80                saveData(player, true)
81                leftPlayers -= 1
82                if leftPlayers == 0 then
83                    finished:Fire()
84                end
85            end)
86        end
87 
88        finished.Event:Wait()
89    end
90end)
 View all 90 lines...

My DataStore Is Not Working To Save Players Leaderstats Any Way To Fix This?

1 answer

Answer this question